[jira] [Comment Edited] (MESOS-5943) Incremental http parsing of URLs leads to decoder error

2016-08-02 Thread Joris Van Remoortere (JIRA)

[ 
https://issues.apache.org/jira/browse/MESOS-5943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15404647#comment-15404647
 ] 

Joris Van Remoortere edited comment on MESOS-5943 at 8/2/16 9:05 PM:
-

{code}
commit 2776a09cbcd836080241a5ad8c1e003984e5a146
Author: Joris Van Remoortere 
Date:   Sat Jul 30 12:58:28 2016 -0700

Libprocess: Fixed decoder to support incremental URL parsing.

Review: https://reviews.apache.org/r/50634
{code}


was (Author: jvanremoortere):
{code}
commit f291d5023e9f2e471c11d4f20590901d9bfc1de4
Author: Joris Van Remoortere 
Date:   Mon Aug 1 17:14:37 2016 -0700

Libprocess: Removed old http_parser code.

We remove the code that supported the `HTTP_PARSER_VERSION_MAJOR` < 2
path.

Review: https://reviews.apache.org/r/50683

commit 2776a09cbcd836080241a5ad8c1e003984e5a146
Author: Joris Van Remoortere 
Date:   Sat Jul 30 12:58:28 2016 -0700

Libprocess: Fixed decoder to support incremental URL parsing.

Review: https://reviews.apache.org/r/50634
{code}

> Incremental http parsing of URLs leads to decoder error
> ---
>
> Key: MESOS-5943
> URL: https://issues.apache.org/jira/browse/MESOS-5943
> Project: Mesos
>  Issue Type: Bug
>  Components: libprocess, scheduler driver
>Affects Versions: 1.0.0
>Reporter: Joris Van Remoortere
>Assignee: Joris Van Remoortere
>Priority: Blocker
>  Labels: mesosphere
> Fix For: 0.28.3, 1.0.1, 0.27.4
>
>
> When requests arrive to the decoder in pieces (e.g. {{mes}} followed by a 
> separate chunk of {{os.apache.org}}) the http parser is not able to handle 
> this case if the split is within the URL component.
> This causes the decoder to error out, and can lead to connection invalidation.
> The scheduler driver is susceptible to this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (MESOS-5943) Incremental http parsing of URLs leads to decoder error

2016-08-02 Thread Joris Van Remoortere (JIRA)

[ 
https://issues.apache.org/jira/browse/MESOS-5943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15404647#comment-15404647
 ] 

Joris Van Remoortere edited comment on MESOS-5943 at 8/2/16 9:03 PM:
-

{code}
commit f291d5023e9f2e471c11d4f20590901d9bfc1de4
Author: Joris Van Remoortere 
Date:   Mon Aug 1 17:14:37 2016 -0700

Libprocess: Removed old http_parser code.

We remove the code that supported the `HTTP_PARSER_VERSION_MAJOR` < 2
path.

Review: https://reviews.apache.org/r/50683

commit 2776a09cbcd836080241a5ad8c1e003984e5a146
Author: Joris Van Remoortere 
Date:   Sat Jul 30 12:58:28 2016 -0700

Libprocess: Fixed decoder to support incremental URL parsing.

Review: https://reviews.apache.org/r/50634
{code}


was (Author: jvanremoortere):
{code}
commit f291d5023e9f2e471c11d4f20590901d9bfc1de4
Author: Joris Van Remoortere 
Date:   Mon Aug 1 17:14:37 2016 -0700

Libprocess: Removed old http_parser code.

We remove the code that supported the `HTTP_PARSER_VERSION_MAJOR` < 2
path.

Review: https://reviews.apache.org/r/50683

commit 2776a09cbcd836080241a5ad8c1e003984e5a146
Author: Joris Van Remoortere 
Date:   Sat Jul 30 12:58:28 2016 -0700

Libprocess: Fixed decoder to support incremental URL parsing.

Review: https://reviews.apache.org/r/50634
{code}

> Incremental http parsing of URLs leads to decoder error
> ---
>
> Key: MESOS-5943
> URL: https://issues.apache.org/jira/browse/MESOS-5943
> Project: Mesos
>  Issue Type: Bug
>  Components: libprocess, scheduler driver
>Affects Versions: 1.0.0
>Reporter: Joris Van Remoortere
>Assignee: Joris Van Remoortere
>Priority: Blocker
>  Labels: mesosphere
> Fix For: 0.28.3, 1.0.1, 0.27.4
>
>
> When requests arrive to the decoder in pieces (e.g. {{mes}} followed by a 
> separate chunk of {{os.apache.org}}) the http parser is not able to handle 
> this case if the split is within the URL component.
> This causes the decoder to error out, and can lead to connection invalidation.
> The scheduler driver is susceptible to this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)