[jira] [Comment Edited] (MESOS-6035) Add non-recursive version of cgroups::get
[ https://issues.apache.org/jira/browse/MESOS-6035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15575167#comment-15575167 ] Alexander Rukletsov edited comment on MESOS-6035 at 10/14/16 12:16 PM: --- {noformat} Commit: fcd5106b5dfa14bc83eae68415bd4782c16f79a4 [fcd5106] Author: Alexander Rukletsov Date: 14 October 2016 at 14:10:23 GMT+2 Commit Date: 14 October 2016 at 14:15:02 GMT+2 Revert "Removed the expired TODO about non-recursive version... `cgroups::get`." This reverts commit e042aa071a77ef1922d9b1a93f6e8adf221979b3. RR https://reviews.apache.org/r/51185/ should have been committed together with https://reviews.apache.org/r/51031/. However, the latter is not going to make it into the 1.1.0 release, hence the former is reverted now to avoid confusion. {noformat} was (Author: alexr): {noformat} Commit: fcd5106b5dfa14bc83eae68415bd4782c16f79a4 [fcd5106] Parents: 9fc2901d23 Author: Alexander Rukletsov Date: 14 October 2016 at 14:10:23 GMT+2 Commit Date: 14 October 2016 at 14:15:02 GMT+2 Labels: HEAD -> master Revert "Removed the expired TODO about non-recursive version... `cgroups::get`." This reverts commit e042aa071a77ef1922d9b1a93f6e8adf221979b3. RR https://reviews.apache.org/r/51185/ should have been committed together with https://reviews.apache.org/r/51031/. However, the latter is not going to make it into the 1.1.0 release, hence the former is reverted now to avoid confusion. {noformat} > Add non-recursive version of cgroups::get > - > > Key: MESOS-6035 > URL: https://issues.apache.org/jira/browse/MESOS-6035 > Project: Mesos > Issue Type: Improvement >Reporter: haosdent >Assignee: haosdent >Priority: Minor > > In some cases, we only need to get the top level cgroups instead of to get > all cgroups recursively. Add a non-recursive version could help to avoid > unnecessary paths. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (MESOS-6035) Add non-recursive version of cgroups::get
[ https://issues.apache.org/jira/browse/MESOS-6035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15425251#comment-15425251 ] Yan Xu edited comment on MESOS-6035 at 8/22/16 5:35 PM: I commented on the review. This is relevant to MESOS-5879 as well. [~swsnider] brought up a point if we default to *not* recursively descend into nested cgroups, a lot of problems including MESOS-5879 go aways. I can't think of a reason that we should traverse the cgroups recursively today (except {{cgroups::remove()}} and {{cgroups::destroy()}} but they are different in that they are within the cgroups util and encapsulate such details). Of course if we do have cases in the future they can set {{recursive=true}} explicitly. [~jieyu] [~idownes] what are your thoughts on this? was (Author: xujyan): I commented on the review. This is relevant to MESOS-5879 as well. [~swsnider] brought up a point if we default to *not* recursively descend into nested cgroups, a lot of problems including MESOS-5879 go aways. I can't think of a reason that we should traverse the cgroups recursively today. Of course if we do have cases in the future they can set {{recursive=true}} explicitly. [~jieyu] [~idownes] what are your thoughts on this? > Add non-recursive version of cgroups::get > - > > Key: MESOS-6035 > URL: https://issues.apache.org/jira/browse/MESOS-6035 > Project: Mesos > Issue Type: Improvement >Reporter: haosdent >Assignee: haosdent >Priority: Minor > > In some cases, we only need to get the top level cgroups instead of to get > all cgroups recursively. Add a non-recursive version could help to avoid > unnecessary paths. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (MESOS-6035) Add non-recursive version of cgroups::get
[ https://issues.apache.org/jira/browse/MESOS-6035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15425251#comment-15425251 ] Yan Xu edited comment on MESOS-6035 at 8/22/16 5:36 PM: I commented on the review. This is relevant to MESOS-5879 as well. [~swsnider] brought up a point if we default to *not* recursively descend into nested cgroups, a lot of problems including MESOS-5879 go aways. I can't think of a reason that we should traverse the cgroups recursively today (except for {{cgroups::remove()}} and {{cgroups::destroy()}} but they are different in that they are within the cgroups util and encapsulate such details). Of course if we do have cases in the future they can set {{recursive=true}} explicitly. [~jieyu] [~idownes] what are your thoughts on this? was (Author: xujyan): I commented on the review. This is relevant to MESOS-5879 as well. [~swsnider] brought up a point if we default to *not* recursively descend into nested cgroups, a lot of problems including MESOS-5879 go aways. I can't think of a reason that we should traverse the cgroups recursively today (except {{cgroups::remove()}} and {{cgroups::destroy()}} but they are different in that they are within the cgroups util and encapsulate such details). Of course if we do have cases in the future they can set {{recursive=true}} explicitly. [~jieyu] [~idownes] what are your thoughts on this? > Add non-recursive version of cgroups::get > - > > Key: MESOS-6035 > URL: https://issues.apache.org/jira/browse/MESOS-6035 > Project: Mesos > Issue Type: Improvement >Reporter: haosdent >Assignee: haosdent >Priority: Minor > > In some cases, we only need to get the top level cgroups instead of to get > all cgroups recursively. Add a non-recursive version could help to avoid > unnecessary paths. -- This message was sent by Atlassian JIRA (v6.3.4#6332)