[jira] [Commented] (MESOS-1734) Reduce compile time replacing macro expansions with variadic templates
[ https://issues.apache.org/jira/browse/MESOS-1734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14152234#comment-14152234 ] Cody Maloney commented on MESOS-1734: - Commit: 38d8a6db9e4d86a8f57e3793ae940313ef2ea75e Author: Joris Van Remoortere joris.van.remoort...@gmail.com Authored: Thu Sep 25 12:35:03 2014 -0700 Committer: Niklas Q. Nielsen nik...@mesosphere.io Committed: Thu Sep 25 12:35:45 2014 -0700 Added variadic strings join. There is a second version of the variadic join which takes a reference to a stringstream as a parameter. This is handy when strings::join is just a part of a larger string manipulation. Reduce compile time replacing macro expansions with variadic templates -- Key: MESOS-1734 URL: https://issues.apache.org/jira/browse/MESOS-1734 Project: Mesos Issue Type: Improvement Reporter: Patrick Reilly Assignee: Patrick Reilly Priority: Minor -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-1734) Reduce compile time replacing macro expansions with variadic templates
[ https://issues.apache.org/jira/browse/MESOS-1734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14111381#comment-14111381 ] Patrick Reilly commented on MESOS-1734: --- Up for review: https://reviews.apache.org/r/25079/ Reduce compile time replacing macro expansions with variadic templates -- Key: MESOS-1734 URL: https://issues.apache.org/jira/browse/MESOS-1734 Project: Mesos Issue Type: Improvement Reporter: Patrick Reilly Assignee: Patrick Reilly Priority: Minor -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (MESOS-1734) Reduce compile time replacing macro expansions with variadic templates
[ https://issues.apache.org/jira/browse/MESOS-1734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14111420#comment-14111420 ] Benjamin Mahler commented on MESOS-1734: Hi [~preillyme], we can't yet assume C++11 support: https://issues.apache.org/jira/browse/MESOS-750 [~dhamon] would have a better idea of when we'll move to C++11 as a requirement. Reduce compile time replacing macro expansions with variadic templates -- Key: MESOS-1734 URL: https://issues.apache.org/jira/browse/MESOS-1734 Project: Mesos Issue Type: Improvement Reporter: Patrick Reilly Assignee: Patrick Reilly Priority: Minor -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (MESOS-1734) Reduce compile time replacing macro expansions with variadic templates
[ https://issues.apache.org/jira/browse/MESOS-1734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14111465#comment-14111465 ] Patrick Reilly commented on MESOS-1734: --- [~bmahler] Thanks, I'll talk to [~benjaminhindman] about how to proceed as well as [~dhamon]. Reduce compile time replacing macro expansions with variadic templates -- Key: MESOS-1734 URL: https://issues.apache.org/jira/browse/MESOS-1734 Project: Mesos Issue Type: Improvement Reporter: Patrick Reilly Assignee: Patrick Reilly Priority: Minor -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (MESOS-1734) Reduce compile time replacing macro expansions with variadic templates
[ https://issues.apache.org/jira/browse/MESOS-1734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14111475#comment-14111475 ] Cody Maloney commented on MESOS-1734: - The patch doesn't mandate C++11 as supported by newer compilers, just what is supported by way back to 4.4.6 I believe (Although I haven't compile tested that as I don't have that compiler version installed anywhere), so it should be good even on old GCCs, which is the primary issue pointed out by MESOS-750 w.r.t. ABI compatibility brought up in that, the ABI has been very stable for C++11 for a long time (and GCC actually kept the flag locked at one version for a long time, even though there were newer versions for resolving bugs between compiler vendors). See: https://gcc.gnu.org/onlinedocs/gcc-4.9.1/gcc/C_002b_002b-Dialect-Options.html GCC is very, very strongly against breaking ABI. There is a lot in libstdc++ which would change fairly drastically to become standards compliant if they weren't so set on keeping ABI. Reduce compile time replacing macro expansions with variadic templates -- Key: MESOS-1734 URL: https://issues.apache.org/jira/browse/MESOS-1734 Project: Mesos Issue Type: Improvement Reporter: Patrick Reilly Assignee: Patrick Reilly Priority: Minor -- This message was sent by Atlassian JIRA (v6.2#6252)
