[jira] [Commented] (MESOS-2578) Add '{' on newline for function declarations in style checker

2016-05-18 Thread JIRA 

[ 
https://issues.apache.org/jira/browse/MESOS-2578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15290353#comment-15290353
 ] 

José Guilherme Vanz commented on MESOS-2578:


I'll get a issue in the roadmap

> Add '{' on newline for function declarations in style checker
> -
>
> Key: MESOS-2578
> URL: https://issues.apache.org/jira/browse/MESOS-2578
> Project: Mesos
>  Issue Type: Improvement
>Reporter: Niklas Quarfot Nielsen
>Priority: Trivial
>  Labels: newbie
>
> Similar to MESOS-2577; another common style mistake is to not move curly 
> braces on a newline for function and class declarations:
> {code}
> class Foo {
>   void bar() {
>   ...
>   }
> };
> {code}
> vs
> {code}
> class Foo
> {
>   void bar()
>   {
>   ...
>   }
> };
> {code}
> This should be easy to check with our style checker too.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (MESOS-2578) Add '{' on newline for function declarations in style checker

2015-08-08 Thread JIRA 

[ 
https://issues.apache.org/jira/browse/MESOS-2578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14663262#comment-14663262
 ] 

José Guilherme Vanz commented on MESOS-2578:


https://reviews.apache.org/r/37266/
https://reviews.apache.org/r/37267/
https://reviews.apache.org/r/37268/

 Add '{' on newline for function declarations in style checker
 -

 Key: MESOS-2578
 URL: https://issues.apache.org/jira/browse/MESOS-2578
 Project: Mesos
  Issue Type: Improvement
Reporter: Niklas Quarfot Nielsen
Assignee: José Guilherme Vanz
Priority: Trivial
  Labels: mesosphere, newbie

 Similar to MESOS-2577; another common style mistake is to not move curly 
 braces on a newline for function and class declarations:
 {code}
 class Foo {
   void bar() {
   ...
   }
 };
 {code}
 vs
 {code}
 class Foo
 {
   void bar()
   {
   ...
   }
 };
 {code}
 This should be easy to check with our style checker too.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (MESOS-2578) Add '{' on newline for function declarations in style checker

2015-07-24 Thread JIRA 

[ 
https://issues.apache.org/jira/browse/MESOS-2578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14641099#comment-14641099
 ] 

José Guilherme Vanz commented on MESOS-2578:


oh... It's so sad! =(
Is there some list of allowed contributors ? Because I can mark myself (e.g. 
[~jvanz]) in the comments. 

 Add '{' on newline for function declarations in style checker
 -

 Key: MESOS-2578
 URL: https://issues.apache.org/jira/browse/MESOS-2578
 Project: Mesos
  Issue Type: Improvement
Reporter: Niklas Quarfot Nielsen
Priority: Trivial
  Labels: mesosphere, newbie

 Similar to MESOS-2577; another common style mistake is to not move curly 
 braces on a newline for function and class declarations:
 {code}
 class Foo {
   void bar() {
   ...
   }
 };
 {code}
 vs
 {code}
 class Foo
 {
   void bar()
   {
   ...
   }
 };
 {code}
 This should be easy to check with our style checker too.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (MESOS-2578) Add '{' on newline for function declarations in style checker

2015-07-24 Thread Vinod Kone (JIRA) 

[ 
https://issues.apache.org/jira/browse/MESOS-2578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14640757#comment-14640757
 ] 

Vinod Kone commented on MESOS-2578:
---

Can't seem to find you on JIRA to add. jvanz and José Guilherme Vanz both 
turn up empty results :(

 Add '{' on newline for function declarations in style checker
 -

 Key: MESOS-2578
 URL: https://issues.apache.org/jira/browse/MESOS-2578
 Project: Mesos
  Issue Type: Improvement
Reporter: Niklas Quarfot Nielsen
Priority: Trivial
  Labels: mesosphere, newbie

 Similar to MESOS-2577; another common style mistake is to not move curly 
 braces on a newline for function and class declarations:
 {code}
 class Foo {
   void bar() {
   ...
   }
 };
 {code}
 vs
 {code}
 class Foo
 {
   void bar()
   {
   ...
   }
 };
 {code}
 This should be easy to check with our style checker too.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (MESOS-2578) Add '{' on newline for function declarations in style checker

2015-07-21 Thread JIRA 

[ 
https://issues.apache.org/jira/browse/MESOS-2578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14636175#comment-14636175
 ] 

José Guilherme Vanz commented on MESOS-2578:


Hi!
I would like to start contribute in the project. I was thinking about begin in 
this issue.
What are you think about?

 Add '{' on newline for function declarations in style checker
 -

 Key: MESOS-2578
 URL: https://issues.apache.org/jira/browse/MESOS-2578
 Project: Mesos
  Issue Type: Improvement
Reporter: Niklas Quarfot Nielsen
Priority: Trivial

 Similar to MESOS-2577; another common style mistake is to not move curly 
 braces on a newline for function and class declarations:
 {code}
 class Foo {
   void bar() {
   ...
   }
 };
 {code}
 vs
 {code}
 class Foo
 {
   void bar()
   {
   ...
   }
 };
 {code}
 This should be easy to check with our style checker too.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)