[jira] [Commented] (MESOS-2748) /help generated links point to wrong URLs
[
https://issues.apache.org/jira/browse/MESOS-2748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14558436#comment-14558436
]
haosdent commented on MESOS-2748:
-
Patch: https://reviews.apache.org/r/34655/
/help generated links point to wrong URLs
-
Key: MESOS-2748
URL: https://issues.apache.org/jira/browse/MESOS-2748
Project: Mesos
Issue Type: Bug
Affects Versions: 0.22.1
Reporter: Marco Massenzio
Assignee: haosdent
Priority: Minor
As reported by Michael Lunøe mlu...@mesosphere.io (see also MESOS-329 and
MESOS-913 for background):
{quote}
In {{mesos/3rdparty/libprocess/src/help.cpp}} a markdown file is created,
which is then converted to html through a javascript library
All endpoints point to {{/help/...}}, they need to work dynamically for
reverse proxy to do its thing. {{/mesos/help}} works, and displays the
endpoints, but they each need to go to their respective {{/help/...}}
endpoint.
Note that this needs to work both for master, and for slaves. I think the
route to slaves help is something like this:
{{/mesos/slaves/20150518-210216-1695027628-5050-1366-S0/help}}, but please
double check this.
{quote}
The fix appears to be not too complex (as it would require to simply
manipulate the generated URL) but a quick skim of the code would suggest that
something more substantial may be desirable too.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MESOS-2748) /help generated links point to wrong URLs
[
https://issues.apache.org/jira/browse/MESOS-2748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14550809#comment-14550809
]
Michael Lunøe commented on MESOS-2748:
--
[~haosd...@gmail.com] Yes, the problem is exactly the use of absolute paths.
/mesos/help works (showing a page with urls), but the urls listed are
absolute paths, i.e. /help/metrics or /help/__processes__. If it were to
use relative paths, so they would show correct paths: /mesos/help/metrics and
/mesos/help/__processes__ in stead. Does that answer your question?
/help generated links point to wrong URLs
-
Key: MESOS-2748
URL: https://issues.apache.org/jira/browse/MESOS-2748
Project: Mesos
Issue Type: Bug
Affects Versions: 0.22.1
Reporter: Marco Massenzio
Priority: Minor
As reported by Michael Lunøe mlu...@mesosphere.io (see also MESOS-329 and
MESOS-913 for background):
{quote}
In {{mesos/3rdparty/libprocess/src/help.cpp}} a markdown file is created,
which is then converted to html through a javascript library
All endpoints point to {{/help/...}}, they need to work dynamically for
reverse proxy to do its thing. {{/mesos/help}} works, and displays the
endpoints, but they each need to go to their respective {{/help/...}}
endpoint.
Note that this needs to work both for master, and for slaves. I think the
route to slaves help is something like this:
{{/mesos/slaves/20150518-210216-1695027628-5050-1366-S0/help}}, but please
double check this.
{quote}
The fix appears to be not too complex (as it would require to simply
manipulate the generated URL) but a quick skim of the code would suggest that
something more substantial may be desirable too.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MESOS-2748) /help generated links point to wrong URLs
[
https://issues.apache.org/jira/browse/MESOS-2748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14550642#comment-14550642
]
haosdent commented on MESOS-2748:
-
Hi, [~marco-mesos]. I am sorry for could not got your idea here. Do you mean
/help endpoint is a absolute path and could not work when user want to show
as /mesos/help after reverse proxy? In nginx, could add a rewrite rule to
solve this problem.
/help generated links point to wrong URLs
-
Key: MESOS-2748
URL: https://issues.apache.org/jira/browse/MESOS-2748
Project: Mesos
Issue Type: Bug
Affects Versions: 0.22.1
Reporter: Marco Massenzio
Priority: Minor
As reported by Michael Lunøe mlu...@mesosphere.io (see also MESOS-329 and
MESOS-913 for background):
{quote}
In {{mesos/3rdparty/libprocess/src/help.cpp}} a markdown file is created,
which is then converted to html through a javascript library
All endpoints point to {{/help/...}}, they need to work dynamically for
reverse proxy to do its thing. {{/mesos/help}} works, and displays the
endpoints, but they each need to go to their respective {{/mesos/help/...}}
endpoint.
Note that this needs to work both for master, and for slaves. I think the
route to slaves help is something like this:
{{/mesos/slaves/20150518-210216-1695027628-5050-1366-S0/help}}, but please
double check this.
{quote}
The fix appears to be not too complex (as it would require to simply
manipulate the generated URL) but a quick skim of the code would suggest that
something more substantial may be desirable too.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MESOS-2748) /help generated links point to wrong URLs
[
https://issues.apache.org/jira/browse/MESOS-2748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14550877#comment-14550877
]
haosdent commented on MESOS-2748:
-
Yes, thank you for your explain. Let me try fix it.
/help generated links point to wrong URLs
-
Key: MESOS-2748
URL: https://issues.apache.org/jira/browse/MESOS-2748
Project: Mesos
Issue Type: Bug
Affects Versions: 0.22.1
Reporter: Marco Massenzio
Priority: Minor
As reported by Michael Lunøe mlu...@mesosphere.io (see also MESOS-329 and
MESOS-913 for background):
{quote}
In {{mesos/3rdparty/libprocess/src/help.cpp}} a markdown file is created,
which is then converted to html through a javascript library
All endpoints point to {{/help/...}}, they need to work dynamically for
reverse proxy to do its thing. {{/mesos/help}} works, and displays the
endpoints, but they each need to go to their respective {{/help/...}}
endpoint.
Note that this needs to work both for master, and for slaves. I think the
route to slaves help is something like this:
{{/mesos/slaves/20150518-210216-1695027628-5050-1366-S0/help}}, but please
double check this.
{quote}
The fix appears to be not too complex (as it would require to simply
manipulate the generated URL) but a quick skim of the code would suggest that
something more substantial may be desirable too.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
