[jira] [Commented] (MESOS-2864) Master should not change the state of a terminal task if it receives another terminal update
[ https://issues.apache.org/jira/browse/MESOS-2864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14991929#comment-14991929 ] Bernd Mathiske commented on MESOS-2864: --- Awesome. Thanks! > Master should not change the state of a terminal task if it receives another > terminal update > > > Key: MESOS-2864 > URL: https://issues.apache.org/jira/browse/MESOS-2864 > Project: Mesos > Issue Type: Bug >Affects Versions: 0.26.0 >Reporter: Vinod Kone >Assignee: Yong Qiao Wang > > Currently, when the master receives a terminal update for an already > terminated (but unacknowledged) task it changes the state to the latest > update. This is confusing because the slave doesn't change the state of the > task in such a case. Master should just forward the update without changing > the task state. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-2864) Master should not change the state of a terminal task if it receives another terminal update
[ https://issues.apache.org/jira/browse/MESOS-2864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14991927#comment-14991927 ] Vinod Kone commented on MESOS-2864: --- My review chain to fix this (see below) is almost ready to be committed (need one last ship it). I'll land them today. > Master should not change the state of a terminal task if it receives another > terminal update > > > Key: MESOS-2864 > URL: https://issues.apache.org/jira/browse/MESOS-2864 > Project: Mesos > Issue Type: Bug >Affects Versions: 0.26.0 >Reporter: Vinod Kone >Assignee: Yong Qiao Wang > > Currently, when the master receives a terminal update for an already > terminated (but unacknowledged) task it changes the state to the latest > update. This is confusing because the slave doesn't change the state of the > task in such a case. Master should just forward the update without changing > the task state. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-2864) Master should not change the state of a terminal task if it receives another terminal update
[ https://issues.apache.org/jira/browse/MESOS-2864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14991923#comment-14991923 ] Vinod Kone commented on MESOS-2864: --- Reviews: https://reviews.apache.org/r/39791/ https://reviews.apache.org/r/39792/ https://reviews.apache.org/r/39827/ https://reviews.apache.org/r/39878/ https://reviews.apache.org/r/39873/ > Master should not change the state of a terminal task if it receives another > terminal update > > > Key: MESOS-2864 > URL: https://issues.apache.org/jira/browse/MESOS-2864 > Project: Mesos > Issue Type: Bug >Reporter: Vinod Kone >Assignee: Yong Qiao Wang > Fix For: 0.26.0 > > > Currently, when the master receives a terminal update for an already > terminated (but unacknowledged) task it changes the state to the latest > update. This is confusing because the slave doesn't change the state of the > task in such a case. Master should just forward the update without changing > the task state. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-2864) Master should not change the state of a terminal task if it receives another terminal update
[ https://issues.apache.org/jira/browse/MESOS-2864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14991811#comment-14991811 ] Bernd Mathiske commented on MESOS-2864: --- This RR has been discarded. [~vinodkone] What is the plan now before we release 0.26.0 for which we want to make a cut tomorrow? Revert the first patch (38051) or do you have something we can commit on top of it? Or leave as is? > Master should not change the state of a terminal task if it receives another > terminal update > > > Key: MESOS-2864 > URL: https://issues.apache.org/jira/browse/MESOS-2864 > Project: Mesos > Issue Type: Bug >Reporter: Vinod Kone >Assignee: Yong Qiao Wang > Fix For: 0.26.0 > > > Currently, when the master receives a terminal update for an already > terminated (but unacknowledged) task it changes the state to the latest > update. This is confusing because the slave doesn't change the state of the > task in such a case. Master should just forward the update without changing > the task state. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-2864) Master should not change the state of a terminal task if it receives another terminal update
[ https://issues.apache.org/jira/browse/MESOS-2864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14980342#comment-14980342 ] Yong Qiao Wang commented on MESOS-2864: --- Fix this issue by setting the uuid when the task is already terminated. RR: https://reviews.apache.org/r/39754/ > Master should not change the state of a terminal task if it receives another > terminal update > > > Key: MESOS-2864 > URL: https://issues.apache.org/jira/browse/MESOS-2864 > Project: Mesos > Issue Type: Bug >Reporter: Vinod Kone >Assignee: Yong Qiao Wang > Fix For: 0.26.0 > > > Currently, when the master receives a terminal update for an already > terminated (but unacknowledged) task it changes the state to the latest > update. This is confusing because the slave doesn't change the state of the > task in such a case. Master should just forward the update without changing > the task state. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-2864) Master should not change the state of a terminal task if it receives another terminal update
[ https://issues.apache.org/jira/browse/MESOS-2864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14979631#comment-14979631 ] Vinod Kone commented on MESOS-2864: --- Re-opened this because the submitted code has bug which was exposed by the test in the linked ticket MESOS-3770. Essentially, the master can receive a status update which contains 2 states inside it (update state and latest state). The update state reflects the state the update is sent for, whereas the latest state indicates the latest state of the task according to the slave. See details here: https://github.com/apache/mesos/blob/master/src/messages/messages.proto#L81 This is how the bug manifests --> Master receives an update with TASK_RUNNING update (UUID:R) state (and TASK_FINISHED (UUID:F) latest state). --> Master::updateTask() updates task->state to TASK_FINISHED and sets task->stats_update_uuid to UUID:R --> Master receives ACK for UUID:R which it forwards to slave --> Master receives an update with TASK_FINISHED update (UUID:F) state (and TASK_FINISHED (UUID:F) latest state) --> Master::updateTask() returns immediately because the task is already terminated *without* setting task->update_uuid --> Master receives ACK for UUID:F which it is not waiting for and hence ignores it and doesn't remove the terminated task from its map! --> At this point the slave has removed the task from its map but the master hasn't! The fix is simple. updateTask() should properly set the uuid of the expected ACK. > Master should not change the state of a terminal task if it receives another > terminal update > > > Key: MESOS-2864 > URL: https://issues.apache.org/jira/browse/MESOS-2864 > Project: Mesos > Issue Type: Bug >Reporter: Vinod Kone >Assignee: Yong Qiao Wang > Fix For: 0.26.0 > > > Currently, when the master receives a terminal update for an already > terminated (but unacknowledged) task it changes the state to the latest > update. This is confusing because the slave doesn't change the state of the > task in such a case. Master should just forward the update without changing > the task state. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-2864) Master should not change the state of a terminal task if it receives another terminal update
[ https://issues.apache.org/jira/browse/MESOS-2864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14954910#comment-14954910 ] Yong Qiao Wang commented on MESOS-2864: --- Hi [~vinodkone], I have addressed your comments, any comments for the updated code changes. > Master should not change the state of a terminal task if it receives another > terminal update > > > Key: MESOS-2864 > URL: https://issues.apache.org/jira/browse/MESOS-2864 > Project: Mesos > Issue Type: Bug >Reporter: Vinod Kone >Assignee: Yong Qiao Wang > > Currently, when the master receives a terminal update for an already > terminated (but unacknowledged) task it changes the state to the latest > update. This is confusing because the slave doesn't change the state of the > task in such a case. Master should just forward the update without changing > the task state. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-2864) Master should not change the state of a terminal task if it receives another terminal update
[ https://issues.apache.org/jira/browse/MESOS-2864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14734829#comment-14734829 ] Yong Qiao Wang commented on MESOS-2864: --- Hi [~vinodkone], any comments for the updated code diff? > Master should not change the state of a terminal task if it receives another > terminal update > > > Key: MESOS-2864 > URL: https://issues.apache.org/jira/browse/MESOS-2864 > Project: Mesos > Issue Type: Bug >Reporter: Vinod Kone >Assignee: Yong Qiao Wang > > Currently, when the master receives a terminal update for an already > terminated (but unacknowledged) task it changes the state to the latest > update. This is confusing because the slave doesn't change the state of the > task in such a case. Master should just forward the update without changing > the task state. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-2864) Master should not change the state of a terminal task if it receives another terminal update
[ https://issues.apache.org/jira/browse/MESOS-2864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14730597#comment-14730597 ] Yong Qiao Wang commented on MESOS-2864: --- Hi [~vinodkone], any comments for this fix? > Master should not change the state of a terminal task if it receives another > terminal update > > > Key: MESOS-2864 > URL: https://issues.apache.org/jira/browse/MESOS-2864 > Project: Mesos > Issue Type: Bug >Reporter: Vinod Kone >Assignee: Yong Qiao Wang > > Currently, when the master receives a terminal update for an already > terminated (but unacknowledged) task it changes the state to the latest > update. This is confusing because the slave doesn't change the state of the > task in such a case. Master should just forward the update without changing > the task state. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-2864) Master should not change the state of a terminal task if it receives another terminal update
[ https://issues.apache.org/jira/browse/MESOS-2864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14728637#comment-14728637 ] Yong Qiao Wang commented on MESOS-2864: --- HI [~vi...@twitter.com], could you give me a review for this fix? Welcome your any comments. > Master should not change the state of a terminal task if it receives another > terminal update > > > Key: MESOS-2864 > URL: https://issues.apache.org/jira/browse/MESOS-2864 > Project: Mesos > Issue Type: Bug >Reporter: Vinod Kone >Assignee: Yong Qiao Wang > > Currently, when the master receives a terminal update for an already > terminated (but unacknowledged) task it changes the state to the latest > update. This is confusing because the slave doesn't change the state of the > task in such a case. Master should just forward the update without changing > the task state. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-2864) Master should not change the state of a terminal task if it receives another terminal update
[ https://issues.apache.org/jira/browse/MESOS-2864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14727312#comment-14727312 ] Yong Qiao Wang commented on MESOS-2864: --- The related review request is https://reviews.apache.org/r/38051/ > Master should not change the state of a terminal task if it receives another > terminal update > > > Key: MESOS-2864 > URL: https://issues.apache.org/jira/browse/MESOS-2864 > Project: Mesos > Issue Type: Bug >Reporter: Vinod Kone >Assignee: Yong Qiao Wang > > Currently, when the master receives a terminal update for an already > terminated (but unacknowledged) task it changes the state to the latest > update. This is confusing because the slave doesn't change the state of the > task in such a case. Master should just forward the update without changing > the task state. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-2864) Master should not change the state of a terminal task if it receives another terminal update
[ https://issues.apache.org/jira/browse/MESOS-2864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14727284#comment-14727284 ] Yong Qiao Wang commented on MESOS-2864: --- If no one is working on this, I will have a try. > Master should not change the state of a terminal task if it receives another > terminal update > > > Key: MESOS-2864 > URL: https://issues.apache.org/jira/browse/MESOS-2864 > Project: Mesos > Issue Type: Bug >Reporter: Vinod Kone > > Currently, when the master receives a terminal update for an already > terminated (but unacknowledged) task it changes the state to the latest > update. This is confusing because the slave doesn't change the state of the > task in such a case. Master should just forward the update without changing > the task state. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
