[jira] [Commented] (MESOS-3406) Should not update the framework info when framework->pid != from
[
https://issues.apache.org/jira/browse/MESOS-3406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14738518#comment-14738518
]
Yong Qiao Wang commented on MESOS-3406:
---
Thanks [~gyliu]'s reminder, this bug is duplicated with MESOS-3169
> Should not update the framework info when framework->pid != from
>
>
> Key: MESOS-3406
> URL: https://issues.apache.org/jira/browse/MESOS-3406
> Project: Mesos
> Issue Type: Bug
>Reporter: Yong Qiao Wang
>Assignee: Yong Qiao Wang
>
> The current logic of Master::_subscribe as below:
> {code}
> if (frameworks.registered.contains(frameworkInfo.id())) {
> framework->updateFrameworkInfo(frameworkInfo);
> allocator->updateFramework(framework->id(), framework->info);
> framework->reregisteredTime = Clock::now();
> .
> .
> if (subscribe.force()) {
> ..
> } else if (framework->pid != from) {
> LOG(ERROR) << "Disallowing subscription attempt of"
> << " framework " << *framework
> << " because it is not expected from " << from;
> FrameworkErrorMessage message;
> message.set_message("Framework failed over");
> send(from, message);
> } else {
> ..
> }
> {code}
> In case if this framework has already registered but its pid does not equals
> with from, Master will send a "Framework failed over" message to framework
> to reject this register, but the framework info still be updated, I think
> this should be a bug, and in the failed register case, It should not update
> the framework info.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MESOS-3406) Should not update the framework info when framework->pid != from
[
https://issues.apache.org/jira/browse/MESOS-3406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14738489#comment-14738489
]
Yong Qiao Wang commented on MESOS-3406:
---
[~vinodkone], [~benjaminhindman], [~bmahler] and [~jieyu], any thoughts for
this? Thanks!
> Should not update the framework info when framework->pid != from
>
>
> Key: MESOS-3406
> URL: https://issues.apache.org/jira/browse/MESOS-3406
> Project: Mesos
> Issue Type: Bug
>Reporter: Yong Qiao Wang
>Assignee: Yong Qiao Wang
>
> The current logic of Master::_subscribe as below:
> {code}
> if (frameworks.registered.contains(frameworkInfo.id())) {
> framework->updateFrameworkInfo(frameworkInfo);
> allocator->updateFramework(framework->id(), framework->info);
> framework->reregisteredTime = Clock::now();
> .
> .
> if (subscribe.force()) {
> ..
> } else if (framework->pid != from) {
> LOG(ERROR) << "Disallowing subscription attempt of"
> << " framework " << *framework
> << " because it is not expected from " << from;
> FrameworkErrorMessage message;
> message.set_message("Framework failed over");
> send(from, message);
> } else {
> ..
> }
> {code}
> In case if this framework has already registered but its pid does not equals
> with from, Master will send a "Framework failed over" message to framework
> to reject this register, but the framework info still be updated, I think
> this should be a bug, and in the failed register case, It should not update
> the framework info.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
