[jira] [Commented] (MESOS-3784) Replace Master/Slave Terminology Phase I - Update mesos-cli

2016-05-10 Thread Jay Guo (JIRA) 

[ 
https://issues.apache.org/jira/browse/MESOS-3784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15279416#comment-15279416
 ] 

Jay Guo commented on MESOS-3784:


reviewable at: https://reviews.apache.org/r/47217/

> Replace Master/Slave Terminology Phase I - Update mesos-cli 
> 
>
> Key: MESOS-3784
> URL: https://issues.apache.org/jira/browse/MESOS-3784
> Project: Mesos
>  Issue Type: Task
>  Components: cli
>Reporter: Diana Arroyo
>Assignee: Jay Guo
>Priority: Trivial
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (MESOS-3784) Replace Master/Slave Terminology Phase I - Update mesos-cli

2016-05-10 Thread Vinod Kone (JIRA) 

[ 
https://issues.apache.org/jira/browse/MESOS-3784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15278921#comment-15278921
 ] 

Vinod Kone commented on MESOS-3784:
---

1. Throwing a deprecation warning when using `slave` subcommand sounds good.

2. Sounds good.

3.  I personally would love for mesos to have a standalone CLI. But it's true 
that it is not actively being maintained/tested. Fixing that is out of scope 
for this ticket. Lets just focus on renaming slave to agent in those scripts 
where possible.

> Replace Master/Slave Terminology Phase I - Update mesos-cli 
> 
>
> Key: MESOS-3784
> URL: https://issues.apache.org/jira/browse/MESOS-3784
> Project: Mesos
>  Issue Type: Task
>Reporter: Diana Arroyo
>Assignee: Jay Guo
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (MESOS-3784) Replace Master/Slave Terminology Phase I - Update mesos-cli

2016-04-27 Thread Jay Guo (JIRA) 

[ 
https://issues.apache.org/jira/browse/MESOS-3784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15259728#comment-15259728
 ] 

Jay Guo commented on MESOS-3784:


I took a look at this ticket and here are some findings:
1. root command {{mesos}} collects scripts whose name match {{mesos-*}} in same 
dir as the subcommands. As long as we keep mesos-slave binary and its wrapper 
script, {{slave}} appears in the subcommands, unless we explicitly filter it 
out in {{mesos}} executable. I would suggest to add deprecation warning when 
using mesos-slave.

2. Subcommand's usage info are basically flags descriptions, which are deeply 
coupled with https://issues.apache.org/jira/browse/MESOS-3781 I suggest we 
solve them there.

3. Python utils _mesos-cat_, _mesos-ps_, _mesos-tail_ and _mesos-scp_ do 
contain few hardcoded "slave". Although I wonder whether we still keep these 
utils? In pypi page, it's stated that mesos.cli is deprecated in favor of DCOS 
CLI. https://pypi.python.org/pypi/mesos.cli  For one thing, these utils assume 
a zookeeper setup and resolve master from them, therefore not useful in a 
standalone setup. Secondly, there are some bugs in the util, such as 
referencing variables in {{finally}} which is assigned in {{try}} without a 
default value. Is there someone maintaining these scripts? Should we fix them 
systematically?

[~vinodkone] ideas?

> Replace Master/Slave Terminology Phase I - Update mesos-cli 
> 
>
> Key: MESOS-3784
> URL: https://issues.apache.org/jira/browse/MESOS-3784
> Project: Mesos
>  Issue Type: Task
>Reporter: Diana Arroyo
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)