[jira] [Commented] (MESOS-3826) Add an optional unique identifier for resource reservations
[ https://issues.apache.org/jira/browse/MESOS-3826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16044833#comment-16044833 ] Benjamin Mahler commented on MESOS-3826: Filed a related issue: https://issues.apache.org/jira/browse/MESOS-7651 > Add an optional unique identifier for resource reservations > --- > > Key: MESOS-3826 > URL: https://issues.apache.org/jira/browse/MESOS-3826 > Project: Mesos > Issue Type: Improvement >Reporter: Sargun Dhillon > Labels: mesosphere, reservations > > Thanks to the resource reservation primitives, frameworks can reserve > resources. These reservations are per role, which means multiple frameworks > can share reservations. This can get very hairy, as multiple reservations can > occur on each agent. > It would be nice to be able to optionally, uniquely identify reservations by > ID, much like persistent volumes are today. This could be done by adding a > new protobuf field, such as Resource.ReservationInfo.id, that if set upon > reservation time, would come back when the reservation is advertised. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (MESOS-3826) Add an optional unique identifier for resource reservations
[ https://issues.apache.org/jira/browse/MESOS-3826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15099231#comment-15099231 ] Guangya Liu commented on MESOS-3826: [~neilc] Thanks for the help ;-) > Add an optional unique identifier for resource reservations > --- > > Key: MESOS-3826 > URL: https://issues.apache.org/jira/browse/MESOS-3826 > Project: Mesos > Issue Type: Improvement > Components: general >Reporter: Sargun Dhillon >Assignee: Neil Conway > Labels: mesosphere, reservations > > Thanks to the resource reservation primitives, frameworks can reserve > resources. These reservations are per role, which means multiple frameworks > can share reservations. This can get very hairy, as multiple reservations can > occur on each agent. > It would be nice to be able to optionally, uniquely identify reservations by > ID, much like persistent volumes are today. This could be done by adding a > new protobuf field, such as Resource.ReservationInfo.id, that if set upon > reservation time, would come back when the reservation is advertised. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-3826) Add an optional unique identifier for resource reservations
[ https://issues.apache.org/jira/browse/MESOS-3826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15098645#comment-15098645 ] Neil Conway commented on MESOS-3826: [~gyliu] -- Hi Guangya. I was thinking of looking at implementing this. Let me know if you're actively working on it. Thanks! > Add an optional unique identifier for resource reservations > --- > > Key: MESOS-3826 > URL: https://issues.apache.org/jira/browse/MESOS-3826 > Project: Mesos > Issue Type: Improvement > Components: general >Reporter: Sargun Dhillon >Assignee: Guangya Liu > Labels: mesosphere, reservations > > Thanks to the resource reservation primitives, frameworks can reserve > resources. These reservations are per role, which means multiple frameworks > can share reservations. This can get very hairy, as multiple reservations can > occur on each agent. > It would be nice to be able to optionally, uniquely identify reservations by > ID, much like persistent volumes are today. This could be done by adding a > new protobuf field, such as Resource.ReservationInfo.id, that if set upon > reservation time, would come back when the reservation is advertised. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-3826) Add an optional unique identifier for resource reservations
[ https://issues.apache.org/jira/browse/MESOS-3826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15021979#comment-15021979 ] Neil Conway commented on MESOS-3826: You don't _need_ an ID: the status quo is that your framework needs to compare the resources it is offered with the resources it has tried to reserve, and then it should either make additional reservations or unreserve duplicate reservations as necessary. Adding reservation request IDs (likely along with some notion of "reconciliation" for those IDs) might make this simpler, though. > Add an optional unique identifier for resource reservations > --- > > Key: MESOS-3826 > URL: https://issues.apache.org/jira/browse/MESOS-3826 > Project: Mesos > Issue Type: Improvement > Components: general >Reporter: Sargun Dhillon >Assignee: Guangya Liu >Priority: Minor > Labels: mesosphere, reservations > > Thanks to the resource reservation primitives, frameworks can reserve > resources. These reservations are per role, which means multiple frameworks > can share reservations. This can get very hairy, as multiple reservations can > occur on each agent. > It would be nice to be able to optionally, uniquely identify reservations by > ID, much like persistent volumes are today. This could be done by adding a > new protobuf field, such as Resource.ReservationInfo.id, that if set upon > reservation time, would come back when the reservation is advertised. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-3826) Add an optional unique identifier for resource reservations
[ https://issues.apache.org/jira/browse/MESOS-3826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14999881#comment-14999881 ] Klaus Ma commented on MESOS-3826: - [~sargun], is that addressed your concern? > Add an optional unique identifier for resource reservations > --- > > Key: MESOS-3826 > URL: https://issues.apache.org/jira/browse/MESOS-3826 > Project: Mesos > Issue Type: Improvement > Components: general >Reporter: Sargun Dhillon >Assignee: Guangya Liu >Priority: Minor > Labels: mesosphere > > Thanks to the resource reservation primitives, frameworks can reserve > resources. These reservations are per role, which means multiple frameworks > can share reservations. This can get very hairy, as multiple reservations can > occur on each agent. > It would be nice to be able to optionally, uniquely identify reservations by > ID, much like persistent volumes are today. This could be done by adding a > new protobuf field, such as Resource.ReservationInfo.id, that if set upon > reservation time, would come back when the reservation is advertised. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-3826) Add an optional unique identifier for resource reservations
[
https://issues.apache.org/jira/browse/MESOS-3826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14995652#comment-14995652
]
Klaus Ma commented on MESOS-3826:
-
[~sargun], after thinking twice about this requirement, I think the
{{reservationInfo}} will help on this: although different framework in the same
role will reserve resources, the {{reservationInfo}} in framework will
different with each other because of {{principle}} in {{reservation}}. So
{{reserved_resources.contains()}} will identify which resources are reserved by
this framework; within the framework, developer need to maintenance reserved
resource by itself.
[~mcypark]/[~alexr]/[~neilc], if any misunderstanding, please correct me :).
> Add an optional unique identifier for resource reservations
> ---
>
> Key: MESOS-3826
> URL: https://issues.apache.org/jira/browse/MESOS-3826
> Project: Mesos
> Issue Type: Improvement
> Components: general
>Reporter: Sargun Dhillon
>Assignee: Guangya Liu
>Priority: Minor
> Labels: mesosphere
>
> Thanks to the resource reservation primitives, frameworks can reserve
> resources. These reservations are per role, which means multiple frameworks
> can share reservations. This can get very hairy, as multiple reservations can
> occur on each agent.
> It would be nice to be able to optionally, uniquely identify reservations by
> ID, much like persistent volumes are today. This could be done by adding a
> new protobuf field, such as Resource.ReservationInfo.id, that if set upon
> reservation time, would come back when the reservation is advertised.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MESOS-3826) Add an optional unique identifier for resource reservations
[
https://issues.apache.org/jira/browse/MESOS-3826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14995632#comment-14995632
]
Klaus Ma commented on MESOS-3826:
-
I have similar question on reservation when working on MESOS-3063 (example of
dynamic reservation): if we sent RESERVE request to master, how can we confirm
the resources are indeed reserved? Framework can not just check the by
{{reserved_resources.contains()}}, because those resources maybe reserved by
other framework for high priority task.
> Add an optional unique identifier for resource reservations
> ---
>
> Key: MESOS-3826
> URL: https://issues.apache.org/jira/browse/MESOS-3826
> Project: Mesos
> Issue Type: Improvement
> Components: general
>Reporter: Sargun Dhillon
>Assignee: Guangya Liu
>Priority: Minor
> Labels: mesosphere
>
> Thanks to the resource reservation primitives, frameworks can reserve
> resources. These reservations are per role, which means multiple frameworks
> can share reservations. This can get very hairy, as multiple reservations can
> occur on each agent.
> It would be nice to be able to optionally, uniquely identify reservations by
> ID, much like persistent volumes are today. This could be done by adding a
> new protobuf field, such as Resource.ReservationInfo.id, that if set upon
> reservation time, would come back when the reservation is advertised.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MESOS-3826) Add an optional unique identifier for resource reservations
[ https://issues.apache.org/jira/browse/MESOS-3826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14995809#comment-14995809 ] Sargun Dhillon commented on MESOS-3826: --- Questions: 1. Will Mesos only give resourceOffers to a framework for the given principal that it is registered under, or is this further filtering that the framework author must do? 2. Can a given framework only reserve resources with its principal or can it use the principals of others? If a given framework can only operate on one principal at a time, what's the point of `ReservationInfo` at all? Can't Mesos implicitly apply the principal to all reservations, and task launches? > Add an optional unique identifier for resource reservations > --- > > Key: MESOS-3826 > URL: https://issues.apache.org/jira/browse/MESOS-3826 > Project: Mesos > Issue Type: Improvement > Components: general >Reporter: Sargun Dhillon >Assignee: Guangya Liu >Priority: Minor > Labels: mesosphere > > Thanks to the resource reservation primitives, frameworks can reserve > resources. These reservations are per role, which means multiple frameworks > can share reservations. This can get very hairy, as multiple reservations can > occur on each agent. > It would be nice to be able to optionally, uniquely identify reservations by > ID, much like persistent volumes are today. This could be done by adding a > new protobuf field, such as Resource.ReservationInfo.id, that if set upon > reservation time, would come back when the reservation is advertised. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-3826) Add an optional unique identifier for resource reservations
[ https://issues.apache.org/jira/browse/MESOS-3826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14995888#comment-14995888 ] Sargun Dhillon commented on MESOS-3826: --- The other problem here is idempotence. If I as framework A create a reservation, and for whatever reason that resource gets offered to framework B, which holds it, I am going to time out, thinking my reservation failed. I need to have an ID, that's forced to be unique, in order to get some level of idempotence, given the current asynchronous nature of reservations. > Add an optional unique identifier for resource reservations > --- > > Key: MESOS-3826 > URL: https://issues.apache.org/jira/browse/MESOS-3826 > Project: Mesos > Issue Type: Improvement > Components: general >Reporter: Sargun Dhillon >Assignee: Guangya Liu >Priority: Minor > Labels: mesosphere > > Thanks to the resource reservation primitives, frameworks can reserve > resources. These reservations are per role, which means multiple frameworks > can share reservations. This can get very hairy, as multiple reservations can > occur on each agent. > It would be nice to be able to optionally, uniquely identify reservations by > ID, much like persistent volumes are today. This could be done by adding a > new protobuf field, such as Resource.ReservationInfo.id, that if set upon > reservation time, would come back when the reservation is advertised. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-3826) Add an optional unique identifier for resource reservations
[
https://issues.apache.org/jira/browse/MESOS-3826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14996046#comment-14996046
]
Klaus Ma commented on MESOS-3826:
-
re #1. resourceOffers will included {{unreserved resources}} and {{reserved
resources for this role}}; the {{unreserved resources}} can be used by any
framework
re #2. {{ReservationInfo}} is required by dynamic reservation, I do suggest to
use framework's principal to reserve resources; why do you want to use other
framework's principal?
> Add an optional unique identifier for resource reservations
> ---
>
> Key: MESOS-3826
> URL: https://issues.apache.org/jira/browse/MESOS-3826
> Project: Mesos
> Issue Type: Improvement
> Components: general
>Reporter: Sargun Dhillon
>Assignee: Guangya Liu
>Priority: Minor
> Labels: mesosphere
>
> Thanks to the resource reservation primitives, frameworks can reserve
> resources. These reservations are per role, which means multiple frameworks
> can share reservations. This can get very hairy, as multiple reservations can
> occur on each agent.
> It would be nice to be able to optionally, uniquely identify reservations by
> ID, much like persistent volumes are today. This could be done by adding a
> new protobuf field, such as Resource.ReservationInfo.id, that if set upon
> reservation time, would come back when the reservation is advertised.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MESOS-3826) Add an optional unique identifier for resource reservations
[
https://issues.apache.org/jira/browse/MESOS-3826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14993409#comment-14993409
]
Alexander Rukletsov commented on MESOS-3826:
I will also try to read between the lines : ). Even if there is a single
instance of a single framework in the role, that framework may want to
distinguish between reservation it creates according to requests of its
clients. For example, Marathon can create two reservations for {{app1}} and
three for {{app3}} and would like to distinguish between them when it gets
offers from the master. Without ids, Marathon has to do rather complex
bookkeeping in order to match offered reserved resources to its clients.
Instead of introducing ids, how about adding optional labels for reservations?
In this case, no mesos code should be changed (except protobufs), while
meta-frameworks get the ability to track their reservations if the want to.
> Add an optional unique identifier for resource reservations
> ---
>
> Key: MESOS-3826
> URL: https://issues.apache.org/jira/browse/MESOS-3826
> Project: Mesos
> Issue Type: Improvement
> Components: general
>Reporter: Sargun Dhillon
>Assignee: Guangya Liu
>Priority: Minor
> Labels: mesosphere
>
> Thanks to the resource reservation primitives, frameworks can reserve
> resources. These reservations are per role, which means multiple frameworks
> can share reservations. This can get very hairy, as multiple reservations can
> occur on each agent.
> It would be nice to be able to optionally, uniquely identify reservations by
> ID, much like persistent volumes are today. This could be done by adding a
> new protobuf field, such as Resource.ReservationInfo.id, that if set upon
> reservation time, would come back when the reservation is advertised.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MESOS-3826) Add an optional unique identifier for resource reservations
[ https://issues.apache.org/jira/browse/MESOS-3826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14993431#comment-14993431 ] Guangya Liu commented on MESOS-3826: [~alexr] I think that using either id or label can work and labels might be better as it does not require too much code change. But the current problem is that there are not distinct reservations for a single role, do you have any ideas/comments to distinguish those reservations in one role? ;-) > Add an optional unique identifier for resource reservations > --- > > Key: MESOS-3826 > URL: https://issues.apache.org/jira/browse/MESOS-3826 > Project: Mesos > Issue Type: Improvement > Components: general >Reporter: Sargun Dhillon >Assignee: Guangya Liu >Priority: Minor > Labels: mesosphere > > Thanks to the resource reservation primitives, frameworks can reserve > resources. These reservations are per role, which means multiple frameworks > can share reservations. This can get very hairy, as multiple reservations can > occur on each agent. > It would be nice to be able to optionally, uniquely identify reservations by > ID, much like persistent volumes are today. This could be done by adding a > new protobuf field, such as Resource.ReservationInfo.id, that if set upon > reservation time, would come back when the reservation is advertised. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-3826) Add an optional unique identifier for resource reservations
[ https://issues.apache.org/jira/browse/MESOS-3826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14993681#comment-14993681 ] Alexander Rukletsov commented on MESOS-3826: Having reservations per role instead of per framework was intentional AFAIK. I would suggest you to have a look at [this thread|https://mail-archives.apache.org/mod_mbox/mesos-dev/201508.mbox/%3cof678bc63d.7eb914a6-on48257eb1.00830d62-48257eb2.0001f...@cn.ibm.com%3E] and [the design doc|https://docs.google.com/a/mesosphere.io/document/d/1e3j69pfBgtc8xM00DhcuiMl6ImkEB5na0TzOMyzrg8A/edit#heading=h.gohshgapnm3h] for reasoning. I also think labels can mitigate this issue, though it will still require frameworks to collaborate. > Add an optional unique identifier for resource reservations > --- > > Key: MESOS-3826 > URL: https://issues.apache.org/jira/browse/MESOS-3826 > Project: Mesos > Issue Type: Improvement > Components: general >Reporter: Sargun Dhillon >Assignee: Guangya Liu >Priority: Minor > Labels: mesosphere > > Thanks to the resource reservation primitives, frameworks can reserve > resources. These reservations are per role, which means multiple frameworks > can share reservations. This can get very hairy, as multiple reservations can > occur on each agent. > It would be nice to be able to optionally, uniquely identify reservations by > ID, much like persistent volumes are today. This could be done by adding a > new protobuf field, such as Resource.ReservationInfo.id, that if set upon > reservation time, would come back when the reservation is advertised. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-3826) Add an optional unique identifier for resource reservations
[ https://issues.apache.org/jira/browse/MESOS-3826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14992632#comment-14992632 ] Sargun Dhillon commented on MESOS-3826: --- Yeah. I think that's how roles are supposed to work. That a role would align to a department, rather than every framework having their own role. We can change that, if we want. > Add an optional unique identifier for resource reservations > --- > > Key: MESOS-3826 > URL: https://issues.apache.org/jira/browse/MESOS-3826 > Project: Mesos > Issue Type: Improvement > Components: general >Reporter: Sargun Dhillon >Assignee: Guangya Liu >Priority: Minor > Labels: mesosphere > > Thanks to the resource reservation primitives, frameworks can reserve > resources. These reservations are per role, which means multiple frameworks > can share reservations. This can get very hairy, as multiple reservations can > occur on each agent. > It would be nice to be able to optionally, uniquely identify reservations by > ID, much like persistent volumes are today. This could be done by adding a > new protobuf field, such as Resource.ReservationInfo.id, that if set upon > reservation time, would come back when the reservation is advertised. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-3826) Add an optional unique identifier for resource reservations
[ https://issues.apache.org/jira/browse/MESOS-3826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14992629#comment-14992629 ] Neil Conway commented on MESOS-3826: Reading between the lines, this is because you might have more than one framework (or multiple instances of the same framework) that share the same role? > Add an optional unique identifier for resource reservations > --- > > Key: MESOS-3826 > URL: https://issues.apache.org/jira/browse/MESOS-3826 > Project: Mesos > Issue Type: Improvement > Components: general >Reporter: Sargun Dhillon >Assignee: Guangya Liu >Priority: Minor > Labels: mesosphere > > Thanks to the resource reservation primitives, frameworks can reserve > resources. These reservations are per role, which means multiple frameworks > can share reservations. This can get very hairy, as multiple reservations can > occur on each agent. > It would be nice to be able to optionally, uniquely identify reservations by > ID, much like persistent volumes are today. This could be done by adding a > new protobuf field, such as Resource.ReservationInfo.id, that if set upon > reservation time, would come back when the reservation is advertised. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-3826) Add an optional unique identifier for resource reservations
[ https://issues.apache.org/jira/browse/MESOS-3826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14990952#comment-14990952 ] Guangya Liu commented on MESOS-3826: Thanks [~neilc] That's also what I noticed, seems it is difficult to add an ID to a dynamic reservation as the dynamic reservation might be merged. [~mcypark] any comments? Thanks. > Add an optional unique identifier for resource reservations > --- > > Key: MESOS-3826 > URL: https://issues.apache.org/jira/browse/MESOS-3826 > Project: Mesos > Issue Type: Improvement > Components: general >Reporter: Sargun Dhillon >Assignee: Guangya Liu >Priority: Minor > Labels: mesosphere > > Thanks to the resource reservation primitives, frameworks can reserve > resources. These reservations are per role, which means multiple frameworks > can share reservations. This can get very hairy, as multiple reservations can > occur on each agent. > It would be nice to be able to optionally, uniquely identify reservations by > ID, much like persistent volumes are today. This could be done by adding a > new protobuf field, such as Resource.ReservationInfo.id, that if set upon > reservation time, would come back when the reservation is advertised. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-3826) Add an optional unique identifier for resource reservations
[ https://issues.apache.org/jira/browse/MESOS-3826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14990783#comment-14990783 ] Neil Conway commented on MESOS-3826: There are some subtle issues here. Right now, reservations do not have identity. For example, suppose a slave has 8 CPUs and 8192 MB of RAM, and a framework makes two dynamic reservations for 2 CPUs and 2048 MB of RAM for role 'foo'. The result is that 4 CPUs and 4096MB of RAM on that slave are reserved for 'foo': there are *not* two distinct reservations that might themselves be assigned an ID. Offhand, my initial impression is that this ticket would not be a reasonable thing to implement (unless we redefine how reservations work). > Add an optional unique identifier for resource reservations > --- > > Key: MESOS-3826 > URL: https://issues.apache.org/jira/browse/MESOS-3826 > Project: Mesos > Issue Type: Improvement > Components: general >Reporter: Sargun Dhillon >Assignee: Guangya Liu >Priority: Minor > Labels: mesosphere > > Thanks to the resource reservation primitives, frameworks can reserve > resources. These reservations are per role, which means multiple frameworks > can share reservations. This can get very hairy, as multiple reservations can > occur on each agent. > It would be nice to be able to optionally, uniquely identify reservations by > ID, much like persistent volumes are today. This could be done by adding a > new protobuf field, such as Resource.ReservationInfo.id, that if set upon > reservation time, would come back when the reservation is advertised. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
