[jira] [Commented] (MESOS-3827) Improve compilation speed of GMock tests
[
https://issues.apache.org/jira/browse/MESOS-3827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14996507#comment-14996507
]
Joris Van Remoortere commented on MESOS-3827:
-
{code}
commit 2a9a5c12b9a6621975b766c45b78740d9d3fbba8
Author: Neil Conway
Date: Mon Nov 9 09:36:50 2015 +0100
Refactored mock allocator into a separate header file.
Review: https://reviews.apache.org/r/39947
{code}
> Improve compilation speed of GMock tests
>
>
> Key: MESOS-3827
> URL: https://issues.apache.org/jira/browse/MESOS-3827
> Project: Mesos
> Issue Type: Improvement
>Reporter: Neil Conway
>Assignee: Neil Conway
>Priority: Minor
> Labels: mesosphere, tech-debt, testing
>
> The GMock docs suggest that moving the definition of mock classes'
> constructors and destructors to a separate compilation unit can improve
> compile performance:
> https://code.google.com/p/googlemock/wiki/V1_7_CookBook#Making_the_Compilation_Faster
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MESOS-3827) Improve compilation speed of GMock tests
[ https://issues.apache.org/jira/browse/MESOS-3827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14995690#comment-14995690 ] haosdent commented on MESOS-3827: - Sounds great! > Improve compilation speed of GMock tests > > > Key: MESOS-3827 > URL: https://issues.apache.org/jira/browse/MESOS-3827 > Project: Mesos > Issue Type: Improvement >Reporter: Neil Conway >Assignee: Neil Conway >Priority: Minor > Labels: mesosphere, tech-debt, testing > > The GMock docs suggest that moving the definition of mock classes' > constructors and destructors to a separate compilation unit can improve > compile performance: > https://code.google.com/p/googlemock/wiki/V1_7_CookBook#Making_the_Compilation_Faster -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-3827) Improve compilation speed of GMock tests
[ https://issues.apache.org/jira/browse/MESOS-3827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14990064#comment-14990064 ] James Peach commented on MESOS-3827: Did you measure this? I tried it and it didn't make much difference for me :-/ > Improve compilation speed of GMock tests > > > Key: MESOS-3827 > URL: https://issues.apache.org/jira/browse/MESOS-3827 > Project: Mesos > Issue Type: Improvement >Reporter: Neil Conway >Assignee: Neil Conway >Priority: Minor > Labels: mesosphere, tech-debt, testing > > The GMock docs suggest that moving the definition of mock classes' > constructors and destructors to a separate compilation unit can improve > compile performance: > https://code.google.com/p/googlemock/wiki/V1_7_CookBook#Making_the_Compilation_Faster -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-3827) Improve compilation speed of GMock tests
[ https://issues.apache.org/jira/browse/MESOS-3827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14990099#comment-14990099 ] James Peach commented on MESOS-3827: Yup. I'd agree it is worth it even if it made no difference :) > Improve compilation speed of GMock tests > > > Key: MESOS-3827 > URL: https://issues.apache.org/jira/browse/MESOS-3827 > Project: Mesos > Issue Type: Improvement >Reporter: Neil Conway >Assignee: Neil Conway >Priority: Minor > Labels: mesosphere, tech-debt, testing > > The GMock docs suggest that moving the definition of mock classes' > constructors and destructors to a separate compilation unit can improve > compile performance: > https://code.google.com/p/googlemock/wiki/V1_7_CookBook#Making_the_Compilation_Faster -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-3827) Improve compilation speed of GMock tests
[ https://issues.apache.org/jira/browse/MESOS-3827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14990130#comment-14990130 ] Neil Conway commented on MESOS-3827: One irritant is that we can't use this technique with TestAllocator (because it is templatized, so def'n needs to be in a header), which is a fairly expensive thing to compile: just compiling the things that use it takes ~175 seconds of CPU time (versus ~1300 for the whole test suite). Not sure if there's any easy fix for this, though. > Improve compilation speed of GMock tests > > > Key: MESOS-3827 > URL: https://issues.apache.org/jira/browse/MESOS-3827 > Project: Mesos > Issue Type: Improvement >Reporter: Neil Conway >Assignee: Neil Conway >Priority: Minor > Labels: mesosphere, tech-debt, testing > > The GMock docs suggest that moving the definition of mock classes' > constructors and destructors to a separate compilation unit can improve > compile performance: > https://code.google.com/p/googlemock/wiki/V1_7_CookBook#Making_the_Compilation_Faster -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-3827) Improve compilation speed of GMock tests
[ https://issues.apache.org/jira/browse/MESOS-3827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14990136#comment-14990136 ] Neil Conway commented on MESOS-3827: https://reviews.apache.org/r/39946/ https://reviews.apache.org/r/39947/ > Improve compilation speed of GMock tests > > > Key: MESOS-3827 > URL: https://issues.apache.org/jira/browse/MESOS-3827 > Project: Mesos > Issue Type: Improvement >Reporter: Neil Conway >Assignee: Neil Conway >Priority: Minor > Labels: mesosphere, tech-debt, testing > > The GMock docs suggest that moving the definition of mock classes' > constructors and destructors to a separate compilation unit can improve > compile performance: > https://code.google.com/p/googlemock/wiki/V1_7_CookBook#Making_the_Compilation_Faster -- This message was sent by Atlassian JIRA (v6.3.4#6332)
