[jira] [Commented] (MESOS-3833) /help endpoints do not work for nested paths
[
https://issues.apache.org/jira/browse/MESOS-3833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15140768#comment-15140768
]
Guangya Liu commented on MESOS-3833:
Thanks [~bmahler] and [~vinodkone] , the patch was updated, can you please help
take a look again? Thanks ;-)
> /help endpoints do not work for nested paths
>
>
> Key: MESOS-3833
> URL: https://issues.apache.org/jira/browse/MESOS-3833
> Project: Mesos
> Issue Type: Bug
> Components: HTTP API
>Reporter: Anand Mazumdar
>Assignee: Guangya Liu
>Priority: Minor
> Labels: mesosphere, newbie
>
> Mesos displays the list of all supported endpoints starting at a given path
> prefix using the {{/help}} suffix, e.g. {{master:5050/help}}.
> It seems that the {{help}} functionality is broken for URL's having nested
> paths e.g. {{master:5050/help/master/machine/down}}. The response returned is:
> {quote}
> Malformed URL, expecting '/help/id/name/'
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MESOS-3833) /help endpoints do not work for nested paths
[
https://issues.apache.org/jira/browse/MESOS-3833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15140592#comment-15140592
]
Benjamin Mahler commented on MESOS-3833:
Yes sorry for the delay, [~gyliu] please email me at bmah...@apache.org when
you need reviews :)
Just gave you a review, let me know when you've updated!
> /help endpoints do not work for nested paths
>
>
> Key: MESOS-3833
> URL: https://issues.apache.org/jira/browse/MESOS-3833
> Project: Mesos
> Issue Type: Bug
> Components: HTTP API
>Reporter: Anand Mazumdar
>Assignee: Guangya Liu
>Priority: Minor
> Labels: mesosphere, newbie
>
> Mesos displays the list of all supported endpoints starting at a given path
> prefix using the {{/help}} suffix, e.g. {{master:5050/help}}.
> It seems that the {{help}} functionality is broken for URL's having nested
> paths e.g. {{master:5050/help/master/machine/down}}. The response returned is:
> {quote}
> Malformed URL, expecting '/help/id/name/'
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MESOS-3833) /help endpoints do not work for nested paths
[
https://issues.apache.org/jira/browse/MESOS-3833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15139604#comment-15139604
]
Vinod Kone commented on MESOS-3833:
---
[~bmahler] Are you still shepherding this? Or do you want me to take over?
[~gyliu] I'm assuming you are still interested in getting your review committed?
> /help endpoints do not work for nested paths
>
>
> Key: MESOS-3833
> URL: https://issues.apache.org/jira/browse/MESOS-3833
> Project: Mesos
> Issue Type: Bug
> Components: HTTP API
>Reporter: Anand Mazumdar
>Assignee: Guangya Liu
>Priority: Minor
> Labels: mesosphere, newbie
>
> Mesos displays the list of all supported endpoints starting at a given path
> prefix using the {{/help}} suffix, e.g. {{master:5050/help}}.
> It seems that the {{help}} functionality is broken for URL's having nested
> paths e.g. {{master:5050/help/master/machine/down}}. The response returned is:
> {quote}
> Malformed URL, expecting '/help/id/name/'
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MESOS-3833) /help endpoints do not work for nested paths
[
https://issues.apache.org/jira/browse/MESOS-3833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15140329#comment-15140329
]
Guangya Liu commented on MESOS-3833:
Yes, I will rebase the patch later cause this patch has been there for a long
time.
> /help endpoints do not work for nested paths
>
>
> Key: MESOS-3833
> URL: https://issues.apache.org/jira/browse/MESOS-3833
> Project: Mesos
> Issue Type: Bug
> Components: HTTP API
>Reporter: Anand Mazumdar
>Assignee: Guangya Liu
>Priority: Minor
> Labels: mesosphere, newbie
>
> Mesos displays the list of all supported endpoints starting at a given path
> prefix using the {{/help}} suffix, e.g. {{master:5050/help}}.
> It seems that the {{help}} functionality is broken for URL's having nested
> paths e.g. {{master:5050/help/master/machine/down}}. The response returned is:
> {quote}
> Malformed URL, expecting '/help/id/name/'
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MESOS-3833) /help endpoints do not work for nested paths
[
https://issues.apache.org/jira/browse/MESOS-3833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14991229#comment-14991229
]
Guangya Liu commented on MESOS-3833:
[~bmahler] The /help/master works well and it will list all master related
endpoints:
{code}
/master/api/v1/scheduler
/master/flags
/master/frameworks
/master/health
/master/machine/down
/master/machine/up
/master/maintenance/schedule
/master/maintenance/status
/master/observe
/master/redirect
/master/reserve
/master/roles
/master/roles.json
/master/slaves
/master/state
/master/state-summary
/master/state.json
/master/tasks
/master/tasks.json
/master/teardown
/master/unreserve
{code}
But when click the links for master which has more than two strings, the mesos
will report error.
The reason is that the current
https://github.com/apache/mesos/blob/master/3rdparty/libprocess/src/help.cpp#L120-L127
logic can only handle three strings (/help/master/) in an endpoint, but
for four or bigger string endpoint (/help/master/xxx/xxx), the mesos will
report error. Comments?
> /help endpoints do not work for nested paths
>
>
> Key: MESOS-3833
> URL: https://issues.apache.org/jira/browse/MESOS-3833
> Project: Mesos
> Issue Type: Bug
> Components: HTTP API
>Reporter: Anand Mazumdar
>Assignee: Guangya Liu
>Priority: Minor
> Labels: mesosphere, newbie
>
> Mesos displays the list of all supported endpoints starting at a given path
> prefix using the {{/help}} suffix, e.g. {{master:5050/help}}.
> It seems that the {{help}} functionality is broken for URL's having nested
> paths e.g. {{master:5050/help/master/machine/down}}. The response returned is:
> {quote}
> Malformed URL, expecting '/help/id/name/'
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MESOS-3833) /help endpoints do not work for nested paths
[
https://issues.apache.org/jira/browse/MESOS-3833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14991240#comment-14991240
]
Benjamin Mahler commented on MESOS-3833:
Let's fix Help::help to handle these.
> /help endpoints do not work for nested paths
>
>
> Key: MESOS-3833
> URL: https://issues.apache.org/jira/browse/MESOS-3833
> Project: Mesos
> Issue Type: Bug
> Components: HTTP API
>Reporter: Anand Mazumdar
>Assignee: Guangya Liu
>Priority: Minor
> Labels: mesosphere, newbie
>
> Mesos displays the list of all supported endpoints starting at a given path
> prefix using the {{/help}} suffix, e.g. {{master:5050/help}}.
> It seems that the {{help}} functionality is broken for URL's having nested
> paths e.g. {{master:5050/help/master/machine/down}}. The response returned is:
> {quote}
> Malformed URL, expecting '/help/id/name/'
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MESOS-3833) /help endpoints do not work for nested paths
[
https://issues.apache.org/jira/browse/MESOS-3833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14991037#comment-14991037
]
Guangya Liu commented on MESOS-3833:
There are two solutions for this, the first is do not use nested paths and
update all nested paths to single string, the second is update
https://github.com/apache/mesos/blob/master/3rdparty/libprocess/src/help.cpp#L120-L127
to support nested path, but it is difficult to handle this as the current
nested paths including two words and not sure if we have more words nested
paths in future.
[~bmahler] any comments? Thanks.
> /help endpoints do not work for nested paths
>
>
> Key: MESOS-3833
> URL: https://issues.apache.org/jira/browse/MESOS-3833
> Project: Mesos
> Issue Type: Bug
> Components: HTTP API
>Reporter: Anand Mazumdar
>Priority: Minor
> Labels: mesosphere, newbie
>
> Mesos displays the list of all supported endpoints starting at a given path
> prefix using the {{/help}} suffix, e.g. {{master:5050/help}}.
> It seems that the {{help}} functionality is broken for URL's having nested
> paths e.g. {{master:5050/help/master/machine/down}}. The response returned is:
> {quote}
> Malformed URL, expecting '/help/id/name/'
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MESOS-3833) /help endpoints do not work for nested paths
[
https://issues.apache.org/jira/browse/MESOS-3833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14991218#comment-14991218
]
Benjamin Mahler commented on MESOS-3833:
[~gyliu] it doesn't look that difficult to update the help code in your link to
support an arbitrary amount of tokens. However, I'm a bit surprised that the
code behaves this way. What is listed when you hit /help/master? Taking a quick
glance at the code, it looks like the help code handles multi-token paths
during the call to
[Help::add|https://github.com/apache/mesos/blob/0.25.0/3rdparty/libprocess/src/help.cpp#L81],
so seems that
[Help::help|https://github.com/apache/mesos/blob/0.25.0/3rdparty/libprocess/src/help.cpp#L109]
should handle these as well.
> /help endpoints do not work for nested paths
>
>
> Key: MESOS-3833
> URL: https://issues.apache.org/jira/browse/MESOS-3833
> Project: Mesos
> Issue Type: Bug
> Components: HTTP API
>Reporter: Anand Mazumdar
>Assignee: Guangya Liu
>Priority: Minor
> Labels: mesosphere, newbie
>
> Mesos displays the list of all supported endpoints starting at a given path
> prefix using the {{/help}} suffix, e.g. {{master:5050/help}}.
> It seems that the {{help}} functionality is broken for URL's having nested
> paths e.g. {{master:5050/help/master/machine/down}}. The response returned is:
> {quote}
> Malformed URL, expecting '/help/id/name/'
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
