[jira] [Commented] (MESOS-3932) Silence Boost compiler warnings with CMake
[
https://issues.apache.org/jira/browse/MESOS-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16594023#comment-16594023
]
ASF GitHub Bot commented on MESOS-3932:
---
andschwa closed pull request #104: MESOS-3932 Suppressed boost auto_ptr compile
warnings.
URL: https://github.com/apache/mesos/pull/104
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
index e0c538d9e6..cfb05475e6 100644
--- a/src/CMakeLists.txt
+++ b/src/CMakeLists.txt
@@ -388,7 +388,7 @@ add_definitions(-DUSE_STATIC_LIB -DBUILD_DATE=0
-DBUILD_TIME=0 -DBUILD_USER="fra
# INCLUDE DIRECTIVES FOR MESOS LIBRARY (generates, e.g., -I/path/to/thing
# on Linux).
#
-include_directories(${AGENT_INCLUDE_DIRS})
+include_directories(SYSTEM ${AGENT_INCLUDE_DIRS})
# LINKING LIBRARIES BY DIRECTORY (might generate, e.g., -L/path/to/thing on
# Linux).
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Silence Boost compiler warnings with CMake
> --
>
> Key: MESOS-3932
> URL: https://issues.apache.org/jira/browse/MESOS-3932
> Project: Mesos
> Issue Type: Bug
>Reporter: Neil Conway
>Assignee: Alex Clemmer
>Priority: Minor
> Labels: cmake, mesosphere, microsoft
> Fix For: 1.2.0
>
>
> Per MESOS-3799, we should silence at least two kinds of compiler warning
> fixes when including the Boost headers:
> * Add -Wno-unused-local-typedefs to CXXFLAGS
> * Use -isystem when including Boost to avoid deprecation warnings for use of
> auto_ptr
> I believe we technically need both, IIRC because some other depedencies pull
> in Boost using their own -I flag.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MESOS-3932) Silence Boost compiler warnings with CMake
[ https://issues.apache.org/jira/browse/MESOS-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16594022#comment-16594022 ] ASF GitHub Bot commented on MESOS-3932: --- andschwa commented on issue #104: MESOS-3932 Suppressed boost auto_ptr compile warnings. URL: https://github.com/apache/mesos/pull/104#issuecomment-416309788 Thanks @frankscholten! I am closing this as the whole CMake build has been pretty much rewritten since this was opened. Sorry we didn't get to it in time! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Silence Boost compiler warnings with CMake > -- > > Key: MESOS-3932 > URL: https://issues.apache.org/jira/browse/MESOS-3932 > Project: Mesos > Issue Type: Bug >Reporter: Neil Conway >Assignee: Alex Clemmer >Priority: Minor > Labels: cmake, mesosphere, microsoft > Fix For: 1.2.0 > > > Per MESOS-3799, we should silence at least two kinds of compiler warning > fixes when including the Boost headers: > * Add -Wno-unused-local-typedefs to CXXFLAGS > * Use -isystem when including Boost to avoid deprecation warnings for use of > auto_ptr > I believe we technically need both, IIRC because some other depedencies pull > in Boost using their own -I flag. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MESOS-3932) Silence Boost compiler warnings with CMake
[ https://issues.apache.org/jira/browse/MESOS-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15290768#comment-15290768 ] ASF GitHub Bot commented on MESOS-3932: --- Github user rukletsov commented on the pull request: https://github.com/apache/mesos/pull/104#issuecomment-220271622 CC @hausdorff > Silence Boost compiler warnings with CMake > -- > > Key: MESOS-3932 > URL: https://issues.apache.org/jira/browse/MESOS-3932 > Project: Mesos > Issue Type: Bug >Reporter: Neil Conway >Priority: Minor > Labels: cmake, mesosphere > > Per MESOS-3799, we should silence at least two kinds of compiler warning > fixes when including the Boost headers: > * Add -Wno-unused-local-typedefs to CXXFLAGS > * Use -isystem when including Boost to avoid deprecation warnings for use of > auto_ptr > I believe we technically need both, IIRC because some other depedencies pull > in Boost using their own -I flag. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-3932) Silence Boost compiler warnings with CMake
[ https://issues.apache.org/jira/browse/MESOS-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15290048#comment-15290048 ] ASF GitHub Bot commented on MESOS-3932: --- Github user joerg84 commented on the pull request: https://github.com/apache/mesos/pull/104#issuecomment-220184401 Thanks for contributing to Mesos! Just some information about the review/contribute process at Mesos. We use ReviewBoard for reviews. Details can be found here: http://mesos.apache.org/documentation/latest/committing/ Looking forward to see your contributions there! > Silence Boost compiler warnings with CMake > -- > > Key: MESOS-3932 > URL: https://issues.apache.org/jira/browse/MESOS-3932 > Project: Mesos > Issue Type: Bug >Reporter: Neil Conway >Priority: Minor > Labels: cmake, mesosphere > > Per MESOS-3799, we should silence at least two kinds of compiler warning > fixes when including the Boost headers: > * Add -Wno-unused-local-typedefs to CXXFLAGS > * Use -isystem when including Boost to avoid deprecation warnings for use of > auto_ptr > I believe we technically need both, IIRC because some other depedencies pull > in Boost using their own -I flag. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-3932) Silence Boost compiler warnings with CMake
[ https://issues.apache.org/jira/browse/MESOS-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15288873#comment-15288873 ] ASF GitHub Bot commented on MESOS-3932: --- GitHub user frankscholten opened a pull request: https://github.com/apache/mesos/pull/104 MESOS-3932 Suppressed boost auto_ptr compile warnings. You can merge this pull request into a Git repository by running: $ git pull https://github.com/frankscholten/mesos MESOS-3932 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/mesos/pull/104.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #104 commit 4fbe309be6b17f65cb2ad7c0dde0967ed3643b72 Author: Frank Scholten Date: 2016-05-18T12:21:49Z Suppressed boost auto_ptr compile warnings. > Silence Boost compiler warnings with CMake > -- > > Key: MESOS-3932 > URL: https://issues.apache.org/jira/browse/MESOS-3932 > Project: Mesos > Issue Type: Bug >Reporter: Neil Conway >Priority: Minor > Labels: cmake, mesosphere > > Per MESOS-3799, we should silence at least two kinds of compiler warning > fixes when including the Boost headers: > * Add -Wno-unused-local-typedefs to CXXFLAGS > * Use -isystem when including Boost to avoid deprecation warnings for use of > auto_ptr > I believe we technically need both, IIRC because some other depedencies pull > in Boost using their own -I flag. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
