[jira] [Commented] (MESOS-3944) Move RoleInfo message out of allocator.proto
[
https://issues.apache.org/jira/browse/MESOS-3944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15046403#comment-15046403
]
Neil Conway commented on MESOS-3944:
FWIW, https://reviews.apache.org/r/41075/ removes RoleInfo (after some
discussion with [~alexr]), for the reasons suggested above.
In my opinion, {{RoleInfo}} in its current form is not useful -- but we
can/should revisit how to group together role-related information in a more
coherent way.
> Move RoleInfo message out of allocator.proto
> -
>
> Key: MESOS-3944
> URL: https://issues.apache.org/jira/browse/MESOS-3944
> Project: Mesos
> Issue Type: Task
>Reporter: Yong Qiao Wang
>Assignee: Yong Qiao Wang
>
> Currently role protobuf is defined in allocator.proto, we will move it out
> and define role protobuf in a separated package, and this protobuf message
> will as internal representation for role related information (e.g. for
> persisting role).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MESOS-3944) Move RoleInfo message out of allocator.proto
[ https://issues.apache.org/jira/browse/MESOS-3944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15046150#comment-15046150 ] Yong Qiao Wang commented on MESOS-3944: --- Good points! I have the same concern before designing the DR(Dynamic Roles), but currently, in DR, we need to persist RoleInfo, so it is needed now. For ACLs, role is just one of objects of ACLs, and ACLs can also be configured for user and framework_principle, so I think it does not make sence to include it into RoleInfo. For Quota, Can you have a talk with Alexander(Owner of quota support)? I think like quota and resource reservation, they are heavy configuration for role, they can be managed by a separated project, but like weight and grace period, they are light configuration for role, it is no need to add a separated endpoints for their management, we can add them into RoleInfo, and manage them with /roles endpoint. > Move RoleInfo message out of allocator.proto > - > > Key: MESOS-3944 > URL: https://issues.apache.org/jira/browse/MESOS-3944 > Project: Mesos > Issue Type: Task >Reporter: Yong Qiao Wang >Assignee: Yong Qiao Wang > > Currently role protobuf is defined in allocator.proto, we will move it out > and define role protobuf in a separated package, and this protobuf message > will as internal representation for role related information (e.g. for > persisting role). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-3944) Move RoleInfo message out of allocator.proto
[ https://issues.apache.org/jira/browse/MESOS-3944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15045399#comment-15045399 ] Neil Conway commented on MESOS-3944: I don't think there is a lot of value in keeping RoleInfo, at least in its current form. There is no good reason to define it as a protobuf, for one thing. For another, RoleInfo actually doesn't include all the info about a role: ACLs and quota are not included. > Move RoleInfo message out of allocator.proto > - > > Key: MESOS-3944 > URL: https://issues.apache.org/jira/browse/MESOS-3944 > Project: Mesos > Issue Type: Task >Reporter: Yong Qiao Wang >Assignee: Yong Qiao Wang > > Currently role protobuf is defined in allocator.proto, we will move it out > and define role protobuf in a separated package, and this protobuf message > will as internal representation for role related information (e.g. for > persisting role). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-3944) Move RoleInfo message out of allocator.proto
[ https://issues.apache.org/jira/browse/MESOS-3944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15010456#comment-15010456 ] Yong Qiao Wang commented on MESOS-3944: --- Append the RR: https://reviews.apache.org/r/40431/ > Move RoleInfo message out of allocator.proto > - > > Key: MESOS-3944 > URL: https://issues.apache.org/jira/browse/MESOS-3944 > Project: Mesos > Issue Type: Task >Reporter: Yong Qiao Wang >Assignee: Yong Qiao Wang > > Currently role protobuf is defined in allocator.proto, we will move it out > and define role protobuf in a separated package, and this protobuf message > will as internal representation for role related information (e.g. for > persisting role). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
