[jira] [Commented] (MESOS-4033) Add a commit hook for non-ascii charachters
[ https://issues.apache.org/jira/browse/MESOS-4033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15224363#comment-15224363 ] Yong Tang commented on MESOS-4033: -- As Mesos has restrictions on not making changes in both mesos and lib process, this issue is splitter into 3 review request: https://reviews.apache.org/r/45033/ https://reviews.apache.org/r/45660/ https://reviews.apache.org/r/45659/ > Add a commit hook for non-ascii charachters > --- > > Key: MESOS-4033 > URL: https://issues.apache.org/jira/browse/MESOS-4033 > Project: Mesos > Issue Type: Task >Reporter: Alexander Rukletsov >Assignee: Yong Tang >Priority: Minor > Labels: mesosphere > > Non-ascii characters invisible in some editors may sneak into the codebase > (see e.g. https://reviews.apache.org/r/40799/). To avoid this, a pre-commit > hook can be added. > Quick searching suggested a simple perl script: > https://superuser.com/questions/417305/how-can-i-identify-non-ascii-characters-from-the-shell -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-4033) Add a commit hook for non-ascii charachters
[ https://issues.apache.org/jira/browse/MESOS-4033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15207485#comment-15207485 ] Deshi Xiao commented on MESOS-4033: --- same here question on ignore all no-ascii characters. > Add a commit hook for non-ascii charachters > --- > > Key: MESOS-4033 > URL: https://issues.apache.org/jira/browse/MESOS-4033 > Project: Mesos > Issue Type: Task >Reporter: Alexander Rukletsov >Assignee: Yong Tang >Priority: Minor > Labels: mesosphere > > Non-ascii characters invisible in some editors may sneak into the codebase > (see e.g. https://reviews.apache.org/r/40799/). To avoid this, a pre-commit > hook can be added. > Quick searching suggested a simple perl script: > https://superuser.com/questions/417305/how-can-i-identify-non-ascii-characters-from-the-shell -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-4033) Add a commit hook for non-ascii charachters
[ https://issues.apache.org/jira/browse/MESOS-4033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15201573#comment-15201573 ] Yong Tang commented on MESOS-4033: -- Hi [~alexr] [~bernd-mesos], I added a review request to address this issue: https://reviews.apache.org/r/45033/ Would appreciate for any feedbacks or comments. > Add a commit hook for non-ascii charachters > --- > > Key: MESOS-4033 > URL: https://issues.apache.org/jira/browse/MESOS-4033 > Project: Mesos > Issue Type: Task >Reporter: Alexander Rukletsov >Assignee: Yong Tang >Priority: Minor > Labels: mesosphere > > Non-ascii characters invisible in some editors may sneak into the codebase > (see e.g. https://reviews.apache.org/r/40799/). To avoid this, a pre-commit > hook can be added. > Quick searching suggested a simple perl script: > https://superuser.com/questions/417305/how-can-i-identify-non-ascii-characters-from-the-shell -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-4033) Add a commit hook for non-ascii charachters
[ https://issues.apache.org/jira/browse/MESOS-4033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15201985#comment-15201985 ] haosdent commented on MESOS-4033: - I have a question about this ticket, should we avoid those zero-space characters only or avoid all no-ascii characters? If disable no-ascii characters, we could not use emoji and some languages which contains no-ascii characters. For the powered-by-mesos.md and user-groups.html.md, this hard limit seems inconvenient. > Add a commit hook for non-ascii charachters > --- > > Key: MESOS-4033 > URL: https://issues.apache.org/jira/browse/MESOS-4033 > Project: Mesos > Issue Type: Task >Reporter: Alexander Rukletsov >Assignee: Yong Tang >Priority: Minor > Labels: mesosphere > > Non-ascii characters invisible in some editors may sneak into the codebase > (see e.g. https://reviews.apache.org/r/40799/). To avoid this, a pre-commit > hook can be added. > Quick searching suggested a simple perl script: > https://superuser.com/questions/417305/how-can-i-identify-non-ascii-characters-from-the-shell -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-4033) Add a commit hook for non-ascii charachters
[ https://issues.apache.org/jira/browse/MESOS-4033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15059775#comment-15059775 ] Bernd Mathiske commented on MESOS-4033: --- Let's make sure this includes markdown files. We recently found non-ASCII characters in those and this may impede the web site build. > Add a commit hook for non-ascii charachters > --- > > Key: MESOS-4033 > URL: https://issues.apache.org/jira/browse/MESOS-4033 > Project: Mesos > Issue Type: Task >Reporter: Alexander Rukletsov >Priority: Minor > Labels: mesosphere > > Non-ascii characters invisible in some editors may sneak into the codebase > (see e.g. https://reviews.apache.org/r/40799/). To avoid this, a pre-commit > hook can be added. > Quick searching suggested a simple perl script: > https://superuser.com/questions/417305/how-can-i-identify-non-ascii-characters-from-the-shell -- This message was sent by Atlassian JIRA (v6.3.4#6332)
