[jira] [Commented] (MESOS-5030) Expose TaskInfo's metadata to ResourceUsage struct
[
https://issues.apache.org/jira/browse/MESOS-5030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228929#comment-15228929
]
Zhitao Li commented on MESOS-5030:
--
[~bmahler], I noticed that there is already a {{message Task}} defined in
src/messages/messages.proto, although it has been in mesos::internal namespace
and not exposed.
My understanding is that I should not try to reuse this message for the purpose
of this task, but rather define new message and afford several lines of
{{CopyFrom}} code. Please let me know if I'm not getting it right.
Thanks.
> Expose TaskInfo's metadata to ResourceUsage struct
> --
>
> Key: MESOS-5030
> URL: https://issues.apache.org/jira/browse/MESOS-5030
> Project: Mesos
> Issue Type: Improvement
> Components: oversubscription
>Reporter: Zhitao Li
>Assignee: Zhitao Li
> Labels: qos, uber
>
> So QosController could use metadata information from TaskInfo.
> Based on conversations from Mesos work group, we would at least include:
> - task id;
> - name;
> - labels;
> ( I think resources, kill_policy should probably also included).
> Alternative would be just purge fields like `data`.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MESOS-5030) Expose TaskInfo's metadata to ResourceUsage struct
[ https://issues.apache.org/jira/browse/MESOS-5030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15214739#comment-15214739 ] Zhitao Li commented on MESOS-5030: -- Sounds good. Will start a draft patch this week. > Expose TaskInfo's metadata to ResourceUsage struct > -- > > Key: MESOS-5030 > URL: https://issues.apache.org/jira/browse/MESOS-5030 > Project: Mesos > Issue Type: Improvement > Components: oversubscription >Reporter: Zhitao Li >Assignee: Zhitao Li > Labels: qos, uber > > So QosController could use metadata information from TaskInfo. > Based on conversations from Mesos work group, we would at least include: > - task id; > - name; > - labels; > ( I think resources, kill_policy should probably also included). > Alternative would be just purge fields like `data`. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-5030) Expose TaskInfo's metadata to ResourceUsage struct
[
https://issues.apache.org/jira/browse/MESOS-5030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15214725#comment-15214725
]
Benjamin Mahler commented on MESOS-5030:
I'd suggest we define a stripped {{Task}} message within {{ResourceUsage}} and
only expose minimal metadata (e.g. id, name, labels).
> Expose TaskInfo's metadata to ResourceUsage struct
> --
>
> Key: MESOS-5030
> URL: https://issues.apache.org/jira/browse/MESOS-5030
> Project: Mesos
> Issue Type: Improvement
> Components: oversubscription
>Reporter: Zhitao Li
>Assignee: Zhitao Li
> Labels: qos, uber
>
> So QosController could use metadata information from TaskInfo.
> Based on conversations from Mesos work group, we would at least include:
> - task id;
> - name;
> - labels;
> ( I think resources, kill_policy should probably also included).
> Alternative would be just purge fields like `data`.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MESOS-5030) Expose TaskInfo's metadata to ResourceUsage struct
[ https://issues.apache.org/jira/browse/MESOS-5030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15212162#comment-15212162 ] Zhitao Li commented on MESOS-5030: -- [~bmahler], my current plan for this task: 1. Add a `repeated TaskInfo task_infos` field to `ResourceUsage.Executor` protobuf message; 2. In implementation, task_infos will be a copy of all tasks associated with the same executor, with the following fields purged: - data; - executor_info (because it's already included once in the the enclosing protobuf). 3. In test, verify that ResourceUsage.Executor includes non-empty task_infos for a ResourceEstimator and QosController. Please let me know whether the above plan sounds good. > Expose TaskInfo's metadata to ResourceUsage struct > -- > > Key: MESOS-5030 > URL: https://issues.apache.org/jira/browse/MESOS-5030 > Project: Mesos > Issue Type: Improvement > Components: oversubscription >Reporter: Zhitao Li >Assignee: Zhitao Li > Labels: qos > > So QosController could use metadata information from TaskInfo. > Based on conversations from Mesos work group, we would at least include: > - task id; > - name; > - labels; > ( I think resources, kill_policy should probably also included). > Alternative would be just purge fields like `data`. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
