[jira] [Commented] (MESOS-5103) Enhance mesos-health-check to send v1:: TaskHealthStatus message
[ https://issues.apache.org/jira/browse/MESOS-5103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15600142#comment-15600142 ] haosdent commented on MESOS-5103: - This should be invalid because {{TaskHealthStatus}} only be used internally. And we are going to make the notification way become callback which don't use {{send}} anymore. Refer to https://reviews.apache.org/r/52872/ > Enhance mesos-health-check to send v1:: TaskHealthStatus message > > > Key: MESOS-5103 > URL: https://issues.apache.org/jira/browse/MESOS-5103 > Project: Mesos > Issue Type: Bug >Reporter: Qian Zhang > > The existing {{mesos-health-check}} > (https://github.com/apache/mesos/blob/master/src/health-check/main.cpp) can > only send the unversioned {{TaskHealthStatus}} message. However, with the new > Executor HTTP Library, there will be executor which is based on v1 HTTP > executor API and all the protobuf messages used by it should be v1 as well > (e.g., {{v1::TaskHealthStatus}}). > So we may either modify the existing {{mesos-health-check}} binary to send > {{v1::TaskHealthStatus}} messages in addition to the unversioned ones or > create a new binary for versioned health checks. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-5103) Enhance mesos-health-check to send v1:: TaskHealthStatus message
[ https://issues.apache.org/jira/browse/MESOS-5103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15600151#comment-15600151 ] haosdent commented on MESOS-5103: - +1 For remove this from v1. > Enhance mesos-health-check to send v1:: TaskHealthStatus message > > > Key: MESOS-5103 > URL: https://issues.apache.org/jira/browse/MESOS-5103 > Project: Mesos > Issue Type: Bug >Reporter: Qian Zhang > > The existing {{mesos-health-check}} > (https://github.com/apache/mesos/blob/master/src/health-check/main.cpp) can > only send the unversioned {{TaskHealthStatus}} message. However, with the new > Executor HTTP Library, there will be executor which is based on v1 HTTP > executor API and all the protobuf messages used by it should be v1 as well > (e.g., {{v1::TaskHealthStatus}}). > So we may either modify the existing {{mesos-health-check}} binary to send > {{v1::TaskHealthStatus}} messages in addition to the unversioned ones or > create a new binary for versioned health checks. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-5103) Enhance mesos-health-check to send v1:: TaskHealthStatus message
[ https://issues.apache.org/jira/browse/MESOS-5103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15600157#comment-15600157 ] haosdent commented on MESOS-5103: - [~xujyan] Does move the {{TaskHealthStatus}} (unversioned one) message from {{src/messages/messages.proto}} to {{include/mesos/mesos.proto}} would casue any problems in your custom executors? > Enhance mesos-health-check to send v1:: TaskHealthStatus message > > > Key: MESOS-5103 > URL: https://issues.apache.org/jira/browse/MESOS-5103 > Project: Mesos > Issue Type: Bug >Reporter: Qian Zhang >Assignee: haosdent > > The existing {{mesos-health-check}} > (https://github.com/apache/mesos/blob/master/src/health-check/main.cpp) can > only send the unversioned {{TaskHealthStatus}} message. However, with the new > Executor HTTP Library, there will be executor which is based on v1 HTTP > executor API and all the protobuf messages used by it should be v1 as well > (e.g., {{v1::TaskHealthStatus}}). > So we may either modify the existing {{mesos-health-check}} binary to send > {{v1::TaskHealthStatus}} messages in addition to the unversioned ones or > create a new binary for versioned health checks. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-5103) Enhance mesos-health-check to send v1:: TaskHealthStatus message
[ https://issues.apache.org/jira/browse/MESOS-5103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15600160#comment-15600160 ] haosdent commented on MESOS-5103: - After check the code, I think it would be better to keep it in messages.proto because it only be used internally. > Enhance mesos-health-check to send v1:: TaskHealthStatus message > > > Key: MESOS-5103 > URL: https://issues.apache.org/jira/browse/MESOS-5103 > Project: Mesos > Issue Type: Bug >Reporter: Qian Zhang >Assignee: haosdent > > The existing {{mesos-health-check}} > (https://github.com/apache/mesos/blob/master/src/health-check/main.cpp) can > only send the unversioned {{TaskHealthStatus}} message. However, with the new > Executor HTTP Library, there will be executor which is based on v1 HTTP > executor API and all the protobuf messages used by it should be v1 as well > (e.g., {{v1::TaskHealthStatus}}). > So we may either modify the existing {{mesos-health-check}} binary to send > {{v1::TaskHealthStatus}} messages in addition to the unversioned ones or > create a new binary for versioned health checks. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-5103) Enhance mesos-health-check to send v1:: TaskHealthStatus message
[ https://issues.apache.org/jira/browse/MESOS-5103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15602306#comment-15602306 ] Anand Mazumdar commented on MESOS-5103: --- Looks like we missed closing this issue when we made the command executor unversioned. For more context see: https://github.com/apache/mesos/commit/00709d0dbb71d61242b902d3d324fa2dd5f12adc > Enhance mesos-health-check to send v1:: TaskHealthStatus message > > > Key: MESOS-5103 > URL: https://issues.apache.org/jira/browse/MESOS-5103 > Project: Mesos > Issue Type: Bug >Reporter: Qian Zhang >Assignee: haosdent > > The existing {{mesos-health-check}} > (https://github.com/apache/mesos/blob/master/src/health-check/main.cpp) can > only send the unversioned {{TaskHealthStatus}} message. However, with the new > Executor HTTP Library, there will be executor which is based on v1 HTTP > executor API and all the protobuf messages used by it should be v1 as well > (e.g., {{v1::TaskHealthStatus}}). > So we may either modify the existing {{mesos-health-check}} binary to send > {{v1::TaskHealthStatus}} messages in addition to the unversioned ones or > create a new binary for versioned health checks. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-5103) Enhance mesos-health-check to send v1:: TaskHealthStatus message
[ https://issues.apache.org/jira/browse/MESOS-5103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15228629#comment-15228629 ] Anand Mazumdar commented on MESOS-5103: --- {{TaskHealthStatus}} message is only being used internally by the command executor code. Another possible solution would be to just move the message from {{src/messages/messages.proto}} to {{include/mesos/mesos.proto}} (unversioned internal protobuf) and not add the message to the {{v1}} namespace at all since there are no external consumers of this message. > Enhance mesos-health-check to send v1:: TaskHealthStatus message > > > Key: MESOS-5103 > URL: https://issues.apache.org/jira/browse/MESOS-5103 > Project: Mesos > Issue Type: Bug >Reporter: Qian Zhang > > The existing {{mesos-health-check}} > (https://github.com/apache/mesos/blob/master/src/health-check/main.cpp) can > only send the unversioned {{TaskHealthStatus}} message. However, with the new > Executor HTTP Library, there will be executor which is based on v1 HTTP > executor API and all the protobuf messages used by it should be v1 as well > (e.g., {{v1::TaskHealthStatus}}). > So we may either modify the existing {{mesos-health-check}} binary to send > {{v1::TaskHealthStatus}} messages in addition to the unversioned ones or > create a new binary for versioned health checks. -- This message was sent by Atlassian JIRA (v6.3.4#6332)