[jira] [Commented] (MESOS-5565) Add logging when Offer::Operation::Launch message has no tasks.

2016-06-22 Thread Klaus Ma (JIRA) 

[ 
https://issues.apache.org/jira/browse/MESOS-5565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15345514#comment-15345514
 ] 

Klaus Ma commented on MESOS-5565:
-

sure, please help on this :). Thanks very much :).

> Add logging when Offer::Operation::Launch message has no tasks.
> ---
>
> Key: MESOS-5565
> URL: https://issues.apache.org/jira/browse/MESOS-5565
> Project: Mesos
>  Issue Type: Improvement
>Reporter: Anand Mazumdar
>Priority: Minor
>  Labels: newbie
>
> Currently, when a {{Offer::Accept::Launch}} message has no tasks specified, 
> Mesos would treat such requests as implicitly declining all offers. This can 
> be very counter-intuitive for framework developers since we do not have any 
> logging on the Master around this behavior. It would be good to add some 
> logging on the master to apprise the framework developers that all the offers 
> have been implicitly declined.
> {code}
> if (operation.type() == Offer::Operation::LAUNCH) {
>   if (operation.launch().task_infos().size() > 0) {
> ++metrics->messages_launch_tasks;
>   } else {
> ++metrics->messages_decline_offers;
>   }
> }
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (MESOS-5565) Add logging when Offer::Operation::Launch message has no tasks.

2016-06-22 Thread JIRA 

[ 
https://issues.apache.org/jira/browse/MESOS-5565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344681#comment-15344681
 ] 

José Guilherme Vanz commented on MESOS-5565:


[~klaus1982] news? If you're working on it I'll find anything else to work. ;)

> Add logging when Offer::Operation::Launch message has no tasks.
> ---
>
> Key: MESOS-5565
> URL: https://issues.apache.org/jira/browse/MESOS-5565
> Project: Mesos
>  Issue Type: Improvement
>Reporter: Anand Mazumdar
>Assignee: Klaus Ma
>Priority: Minor
>  Labels: newbie
>
> Currently, when a {{Offer::Accept::Launch}} message has no tasks specified, 
> Mesos would treat such requests as implicitly declining all offers. This can 
> be very counter-intuitive for framework developers since we do not have any 
> logging on the Master around this behavior. It would be good to add some 
> logging on the master to apprise the framework developers that all the offers 
> have been implicitly declined.
> {code}
> if (operation.type() == Offer::Operation::LAUNCH) {
>   if (operation.launch().task_infos().size() > 0) {
> ++metrics->messages_launch_tasks;
>   } else {
> ++metrics->messages_decline_offers;
>   }
> }
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)