[jira] [Commented] (MESOS-5966) Add libprocess HTTP tests with SSL support
[ https://issues.apache.org/jira/browse/MESOS-5966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15690969#comment-15690969 ] Greg Mann commented on MESOS-5966: -- Updated list of reviews: https://reviews.apache.org/r/53802/ https://reviews.apache.org/r/50736/ https://reviews.apache.org/r/51065/ https://reviews.apache.org/r/52938/ https://reviews.apache.org/r/50737/ https://reviews.apache.org/r/53990/ https://reviews.apache.org/r/53804/ https://reviews.apache.org/r/53803/ > Add libprocess HTTP tests with SSL support > -- > > Key: MESOS-5966 > URL: https://issues.apache.org/jira/browse/MESOS-5966 > Project: Mesos > Issue Type: Task >Reporter: Greg Mann >Assignee: Greg Mann > Labels: mesosphere > > Libprocess contains SSL unit tests which test our SSL support using simple > sockets. We should add tests which also make use of libprocess's various HTTP > classes and helpers in a variety of SSL configurations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-5966) Add libprocess HTTP tests with SSL support
[
https://issues.apache.org/jira/browse/MESOS-5966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15688426#comment-15688426
]
Joseph Wu commented on MESOS-5966:
--
Some independently committed cleanup:
{code}
commit e1c90722fa3c206a42000ced602dfdf4e7932141
Author: Greg Mann
Date: Tue Nov 22 13:44:59 2016 -0800
Added missing cleanup to libprocess 'finalize()'.
The `finalize()` function in libprocess previously did
not delete the thread-local `Executor` which is used to
defer execution to an unspecified context. This object
must be deleted during finalization so that the
`__executor__` macro creates a new process if libprocess
is subsequently reinitialized (and to not leak the pointer).
Review: https://reviews.apache.org/r/53817/
{code}
{code}
commit 5efc83f4937d6b03e66995fa15be01f63fd24fb1
Author: Greg Mann
Date: Tue Nov 22 13:46:06 2016 -0800
Moved server socket deletion in 'process::finalize()'.
We need to destroy the server socket and discard its
future before we finalize the process manager
because the socket's `onDiscard` callback may need to
run in the event loop (such as for libevent sockets), but
process manager finalization stops the event loop.
Review: https://reviews.apache.org/r/53975/
{code}
> Add libprocess HTTP tests with SSL support
> --
>
> Key: MESOS-5966
> URL: https://issues.apache.org/jira/browse/MESOS-5966
> Project: Mesos
> Issue Type: Task
>Reporter: Greg Mann
>Assignee: Greg Mann
> Labels: mesosphere
>
> Libprocess contains SSL unit tests which test our SSL support using simple
> sockets. We should add tests which also make use of libprocess's various HTTP
> classes and helpers in a variety of SSL configurations.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MESOS-5966) Add libprocess HTTP tests with SSL support
[ https://issues.apache.org/jira/browse/MESOS-5966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406287#comment-15406287 ] Greg Mann commented on MESOS-5966: -- Since we have comprehensive tests in libprocess which verify SSL functionality in a wide variety of configurations using raw sockets, the patches below simply verify that libprocess HTTP functionality works as expected with two configurations: SSL enabled or disabled. Reviews: https://reviews.apache.org/r/50736/ https://reviews.apache.org/r/50737/ > Add libprocess HTTP tests with SSL support > -- > > Key: MESOS-5966 > URL: https://issues.apache.org/jira/browse/MESOS-5966 > Project: Mesos > Issue Type: Task >Reporter: Greg Mann >Assignee: Greg Mann > Labels: mesosphere > > Libprocess contains SSL unit tests which test our SSL support using simple > sockets. We should add tests which also make use of libprocess's various HTTP > classes and helpers in a variety of SSL configurations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
