[jira] [Commented] (MESOS-6035) Add non-recursive version of cgroups::get
[ https://issues.apache.org/jira/browse/MESOS-6035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15830939#comment-15830939 ] Adam B commented on MESOS-6035: --- Dropping from the 1.2 target version, unless you think you'll actually land it within the next week > Add non-recursive version of cgroups::get > - > > Key: MESOS-6035 > URL: https://issues.apache.org/jira/browse/MESOS-6035 > Project: Mesos > Issue Type: Improvement > Components: cgroups >Reporter: haosdent >Assignee: haosdent >Priority: Minor > > In some cases, we only need to get the top level cgroups instead of to get > all cgroups recursively. Add a non-recursive version could help to avoid > unnecessary paths. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-6035) Add non-recursive version of cgroups::get
[ https://issues.apache.org/jira/browse/MESOS-6035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15825685#comment-15825685 ] haosdent huang commented on MESOS-6035: --- hi, [~vinodkone] yan reverted patches above because it failed the nested container test cases. We have future discussions about how to refactor the cgroups test part. Because this issue is not resolved after the patch revert, I reopen it before. > Add non-recursive version of cgroups::get > - > > Key: MESOS-6035 > URL: https://issues.apache.org/jira/browse/MESOS-6035 > Project: Mesos > Issue Type: Improvement > Components: cgroups >Reporter: haosdent >Assignee: haosdent >Priority: Minor > Fix For: 1.2.0 > > > In some cases, we only need to get the top level cgroups instead of to get > all cgroups recursively. Add a non-recursive version could help to avoid > unnecessary paths. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-6035) Add non-recursive version of cgroups::get
[ https://issues.apache.org/jira/browse/MESOS-6035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15825635#comment-15825635 ] Vinod Kone commented on MESOS-6035: --- [~haosd...@gmail.com] Looks like you reopened the ticket after it was marked as resolved? If it is by mistake, can you resolve it? > Add non-recursive version of cgroups::get > - > > Key: MESOS-6035 > URL: https://issues.apache.org/jira/browse/MESOS-6035 > Project: Mesos > Issue Type: Improvement > Components: cgroups >Reporter: haosdent >Assignee: haosdent >Priority: Minor > Fix For: 1.2.0 > > > In some cases, we only need to get the top level cgroups instead of to get > all cgroups recursively. Add a non-recursive version could help to avoid > unnecessary paths. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-6035) Add non-recursive version of cgroups::get
[ https://issues.apache.org/jira/browse/MESOS-6035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15575167#comment-15575167 ] Alexander Rukletsov commented on MESOS-6035: {noformat} Commit: fcd5106b5dfa14bc83eae68415bd4782c16f79a4 [fcd5106] Parents: 9fc2901d23 Author: Alexander Rukletsov Date: 14 October 2016 at 14:10:23 GMT+2 Commit Date: 14 October 2016 at 14:15:02 GMT+2 Labels: HEAD -> master Revert "Removed the expired TODO about non-recursive version... `cgroups::get`." This reverts commit e042aa071a77ef1922d9b1a93f6e8adf221979b3. RR https://reviews.apache.org/r/51185/ should have been committed together with https://reviews.apache.org/r/51031/. However, the latter is not going to make it into the 1.1.0 release, hence the former is reverted now to avoid confusion. {noformat} > Add non-recursive version of cgroups::get > - > > Key: MESOS-6035 > URL: https://issues.apache.org/jira/browse/MESOS-6035 > Project: Mesos > Issue Type: Improvement >Reporter: haosdent >Assignee: haosdent >Priority: Minor > > In some cases, we only need to get the top level cgroups instead of to get > all cgroups recursively. Add a non-recursive version could help to avoid > unnecessary paths. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-6035) Add non-recursive version of cgroups::get
[ https://issues.apache.org/jira/browse/MESOS-6035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15533412#comment-15533412 ] Alexander Rukletsov commented on MESOS-6035: {noformat} Commit: e042aa071a77ef1922d9b1a93f6e8adf221979b3 [e042aa0] Author: haosdent huang haosd...@gmail.com Date: 29 September 2016 at 19:24:51 GMT+2 Committer: Alexander Rukletsov al...@apache.org Removed the expired TODO about non-recursive version cgroups::get. Review: https://reviews.apache.org/r/51185/ {noformat} > Add non-recursive version of cgroups::get > - > > Key: MESOS-6035 > URL: https://issues.apache.org/jira/browse/MESOS-6035 > Project: Mesos > Issue Type: Improvement >Reporter: haosdent >Assignee: haosdent >Priority: Minor > > In some cases, we only need to get the top level cgroups instead of to get > all cgroups recursively. Add a non-recursive version could help to avoid > unnecessary paths. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-6035) Add non-recursive version of cgroups::get
[ https://issues.apache.org/jira/browse/MESOS-6035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15431254#comment-15431254 ] haosdent commented on MESOS-6035: - +1 for {{recursive=false}} default. > Add non-recursive version of cgroups::get > - > > Key: MESOS-6035 > URL: https://issues.apache.org/jira/browse/MESOS-6035 > Project: Mesos > Issue Type: Improvement >Reporter: haosdent >Assignee: haosdent >Priority: Minor > > In some cases, we only need to get the top level cgroups instead of to get > all cgroups recursively. Add a non-recursive version could help to avoid > unnecessary paths. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-6035) Add non-recursive version of cgroups::get
[ https://issues.apache.org/jira/browse/MESOS-6035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15425251#comment-15425251 ] Yan Xu commented on MESOS-6035: --- I commented on the review. This is relevant to MESOS-5879 as well. [~swsnider] brought up a point if we default to *not* recursively descend into nested cgroups, a lot of problems including MESOS-5879 go aways. I can't think of a reason that we should traverse the cgroups recursively today. Of course if we do have cases in the future they can set {{recursive=true}} explicitly. [~jieyu] [~idownes] what are your thoughts on this? > Add non-recursive version of cgroups::get > - > > Key: MESOS-6035 > URL: https://issues.apache.org/jira/browse/MESOS-6035 > Project: Mesos > Issue Type: Improvement >Reporter: haosdent >Assignee: haosdent >Priority: Minor > > In some cases, we only need to get the top level cgroups instead of to get > all cgroups recursively. Add a non-recursive version could help to avoid > unnecessary paths. -- This message was sent by Atlassian JIRA (v6.3.4#6332)