[jira] [Commented] (MESOS-6063) Track recovered and prepared subsystems for a container
[ https://issues.apache.org/jira/browse/MESOS-6063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15558741#comment-15558741 ] Jie Yu commented on MESOS-6063: --- commit e7703d1c88936d2b684b43c4a902333b33c808ff Author: Jie YuDate: Sat Oct 8 14:20:47 2016 -0700 Made some adjustments to the cgroups isolator tests. This patch makes sure that the cgroups will be cleaned up for each test by using the ContainerizerTest fixture. commit 9118eded36b3e61a0727fa328540e7da1b9402f0 Author: haosdent huang Date: Sat Oct 8 10:45:18 2016 -0700 Added test case `CgroupsIsolatorTest.ROOT_CGROUPS_MemoryBackward`. Review: https://reviews.apache.org/r/52244/ commit 96c866d36e49dd76a5819154a023c5a23d8ae074 Author: haosdent huang Date: Sat Oct 8 10:45:07 2016 -0700 Added test case `CgroupsIsolatorTest.ROOT_CGROUPS_MemoryForward`. Review: https://reviews.apache.org/r/52243/ > Track recovered and prepared subsystems for a container > --- > > Key: MESOS-6063 > URL: https://issues.apache.org/jira/browse/MESOS-6063 > Project: Mesos > Issue Type: Improvement > Components: cgroups >Reporter: haosdent >Assignee: haosdent > Labels: cgroups > Fix For: 1.1.0 > > > Currently, when we restart Mesos Agent with different cgroups subsystems, the > exist containers would recover failed on newly added subsystems. In this > case, we ignore them and continue to perform {{usage}}, {{status}} and > {{cleanup}} on them. It would be better that we track recovered and prepared > subsystems for a container. Then ignore perform {{update}}, {{wait}}, > {{usage}}, {{status}} on them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-6063) Track recovered and prepared subsystems for a container
[ https://issues.apache.org/jira/browse/MESOS-6063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15519577#comment-15519577 ] haosdent commented on MESOS-6063: - | Refactored the test case `ROOT_CGROUPS_PERF_RollForward`. | https://reviews.apache.org/r/52242/ | | Added test case `CgroupsIsolatorTest.ROOT_CGROUPS_MemoryForward`. | https://reviews.apache.org/r/52243/ | | Added test case `CgroupsIsolatorTest.ROOT_CGROUPS_MemoryBackward`. | https://reviews.apache.org/r/52244/ | > Track recovered and prepared subsystems for a container > --- > > Key: MESOS-6063 > URL: https://issues.apache.org/jira/browse/MESOS-6063 > Project: Mesos > Issue Type: Improvement > Components: cgroups >Reporter: haosdent >Assignee: haosdent > Labels: cgroups > > Currently, when we restart Mesos Agent with different cgroups subsystems, the > exist containers would recover failed on newly added subsystems. In this > case, we ignore them and continue to perform {{usage}}, {{status}} and > {{cleanup}} on them. It would be better that we track recovered and prepared > subsystems for a container. Then ignore perform {{update}}, {{wait}}, > {{usage}}, {{status}} on them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-6063) Track recovered and prepared subsystems for a container
[ https://issues.apache.org/jira/browse/MESOS-6063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15507118#comment-15507118 ] Jie Yu commented on MESOS-6063: --- commit 27a2fb864f7967142f346c2f594bbba494209f57 Author: haosdent huangDate: Tue Sep 20 09:56:04 2016 -0700 Tracked recovered and prepared cgroups subsystems for containers. Recover newly added cgroups subsystems on existing containers would fail, and continue to perform the `update` and other operations of the newly added subsystems on them don't make sense. This patch add the tracking for the recovered or prepared cgroups subsystems of a container and skip performing unnecessary subsystem operations on the container if the subsystem is never recovered or prepared. Review: https://reviews.apache.org/r/51631/ > Track recovered and prepared subsystems for a container > --- > > Key: MESOS-6063 > URL: https://issues.apache.org/jira/browse/MESOS-6063 > Project: Mesos > Issue Type: Improvement > Components: cgroups >Reporter: haosdent >Assignee: haosdent > Labels: cgroups > > Currently, when we restart Mesos Agent with different cgroups subsystems, the > exist containers would recover failed on newly added subsystems. In this > case, we ignore them and continue to perform `usage`, `status` and `cleanup` > on them. It would be better that we track recovered and prepared subsystems > for a container. Then ignore perform `update`, `wait`, `usage`, `status` on > them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)