[jira] [Commented] (MESOS-6902) Add support for agent capabilities

2017-02-21 Thread Benjamin Mahler (JIRA)

[ 
https://issues.apache.org/jira/browse/MESOS-6902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15876714#comment-15876714
 ] 

Benjamin Mahler commented on MESOS-6902:


{noformat}
commit 5ad643fd7b83cf87a820c82e3c980e2ad21899f4
Author: Jay Guo 
Date:   Tue Feb 21 13:03:07 2017 -0800

Added agent capabilities to `/state`(v0) endpoint of agent.

Review: https://reviews.apache.org/r/56645/
{noformat}

> Add support for agent capabilities
> --
>
> Key: MESOS-6902
> URL: https://issues.apache.org/jira/browse/MESOS-6902
> Project: Mesos
>  Issue Type: Improvement
>  Components: agent
>Reporter: Neil Conway
>Assignee: Jay Guo
>  Labels: mesosphere
>
> Similarly to how we might add support for master capabilities (MESOS-5675), 
> agent capabilities would also make sense: in a mixed cluster, the master 
> might have support for features that are not present on certain agents, and 
> vice versa.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (MESOS-6902) Add support for agent capabilities

2017-02-13 Thread Jay Guo (JIRA)

[ 
https://issues.apache.org/jira/browse/MESOS-6902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15865250#comment-15865250
 ] 

Jay Guo commented on MESOS-6902:


RR:
https://reviews.apache.org/r/56644/ - Add a member variable {{capabilities}} to 
slave
https://reviews.apache.org/r/56645/ - Add capabilities to {{/state}} endpoint 
of slave

> Add support for agent capabilities
> --
>
> Key: MESOS-6902
> URL: https://issues.apache.org/jira/browse/MESOS-6902
> Project: Mesos
>  Issue Type: Improvement
>  Components: agent
>Reporter: Neil Conway
>Assignee: Jay Guo
>  Labels: mesosphere
>
> Similarly to how we might add support for master capabilities (MESOS-5675), 
> agent capabilities would also make sense: in a mixed cluster, the master 
> might have support for features that are not present on certain agents, and 
> vice versa.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (MESOS-6902) Add support for agent capabilities

2017-02-13 Thread Jay Guo (JIRA)

[ 
https://issues.apache.org/jira/browse/MESOS-6902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15865099#comment-15865099
 ] 

Jay Guo commented on MESOS-6902:


[~bmahler] Will do. Should we expose {{Capabilities}} along with other sections 
in {{GetState}} of agent? Currently {{GetTasks}}, {{GetExecutors}} and 
{{GetFrameworks}} in {{GetState}} are all guarded by their own approver. If we 
put {{Capabilities}} in parallel with them, should we create a {{capability 
approver}} for viewing agent capabilities?

> Add support for agent capabilities
> --
>
> Key: MESOS-6902
> URL: https://issues.apache.org/jira/browse/MESOS-6902
> Project: Mesos
>  Issue Type: Improvement
>  Components: agent
>Reporter: Neil Conway
>Assignee: Jay Guo
>  Labels: mesosphere
>
> Similarly to how we might add support for master capabilities (MESOS-5675), 
> agent capabilities would also make sense: in a mixed cluster, the master 
> might have support for features that are not present on certain agents, and 
> vice versa.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (MESOS-6902) Add support for agent capabilities

2017-02-13 Thread Benjamin Mahler (JIRA)

[ 
https://issues.apache.org/jira/browse/MESOS-6902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864757#comment-15864757
 ] 

Benjamin Mahler commented on MESOS-6902:


{noformat}
commit b3929ac541977320af6155d6123172e6163b7d3b
Author: Jay Guo 
Date:   Mon Feb 13 16:24:36 2017 -0800

Added agent capabilities to /state endpoint of master.

Master should be able to reflect agent capabilities via  `/state`(v0)
and `getState`(v1) endpoints.

Review: https://reviews.apache.org/r/55710/
{noformat}

[~guoger] are you planning to add the capabilities on the agent's endpoints as 
well?

> Add support for agent capabilities
> --
>
> Key: MESOS-6902
> URL: https://issues.apache.org/jira/browse/MESOS-6902
> Project: Mesos
>  Issue Type: Improvement
>  Components: agent
>Reporter: Neil Conway
>Assignee: Jay Guo
>  Labels: mesosphere
>
> Similarly to how we might add support for master capabilities (MESOS-5675), 
> agent capabilities would also make sense: in a mixed cluster, the master 
> might have support for features that are not present on certain agents, and 
> vice versa.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (MESOS-6902) Add support for agent capabilities

2017-01-19 Thread Jay Guo (JIRA)

[ 
https://issues.apache.org/jira/browse/MESOS-6902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15831216#comment-15831216
 ] 

Jay Guo commented on MESOS-6902:


https://reviews.apache.org/r/55710/ Add agent capabilities to v0 master API 
/state

> Add support for agent capabilities
> --
>
> Key: MESOS-6902
> URL: https://issues.apache.org/jira/browse/MESOS-6902
> Project: Mesos
>  Issue Type: Improvement
>  Components: agent
>Reporter: Neil Conway
>Assignee: Jay Guo
>  Labels: mesosphere
>
> Similarly to how we might add support for master capabilities (MESOS-5675), 
> agent capabilities would also make sense: in a mixed cluster, the master 
> might have support for features that are not present on certain agents, and 
> vice versa.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (MESOS-6902) Add support for agent capabilities

2017-01-17 Thread Jay Guo (JIRA)

[ 
https://issues.apache.org/jira/browse/MESOS-6902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15827419#comment-15827419
 ] 

Jay Guo commented on MESOS-6902:


[~bmahler] Sure, working on it.

> Add support for agent capabilities
> --
>
> Key: MESOS-6902
> URL: https://issues.apache.org/jira/browse/MESOS-6902
> Project: Mesos
>  Issue Type: Improvement
>  Components: agent
>Reporter: Neil Conway
>Assignee: Jay Guo
>  Labels: mesosphere
>
> Similarly to how we might add support for master capabilities (MESOS-5675), 
> agent capabilities would also make sense: in a mixed cluster, the master 
> might have support for features that are not present on certain agents, and 
> vice versa.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (MESOS-6902) Add support for agent capabilities

2017-01-17 Thread Benjamin Mahler (JIRA)

[ 
https://issues.apache.org/jira/browse/MESOS-6902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15826871#comment-15826871
 ] 

Benjamin Mahler commented on MESOS-6902:


[~neilc] sounds good, it will be picked up automatically in the v1 
protobuf-based endpoints, but we should add it to the old-style http endpoints. 
[~guoger] can you take that on as well?

> Add support for agent capabilities
> --
>
> Key: MESOS-6902
> URL: https://issues.apache.org/jira/browse/MESOS-6902
> Project: Mesos
>  Issue Type: Improvement
>  Components: agent
>Reporter: Neil Conway
>Assignee: Jay Guo
>  Labels: mesosphere
>
> Similarly to how we might add support for master capabilities (MESOS-5675), 
> agent capabilities would also make sense: in a mixed cluster, the master 
> might have support for features that are not present on certain agents, and 
> vice versa.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (MESOS-6902) Add support for agent capabilities

2017-01-17 Thread Neil Conway (JIRA)

[ 
https://issues.apache.org/jira/browse/MESOS-6902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15826849#comment-15826849
 ] 

Neil Conway commented on MESOS-6902:


Should agent capabilities be exposed via one or more of the HTTP endpoints?

> Add support for agent capabilities
> --
>
> Key: MESOS-6902
> URL: https://issues.apache.org/jira/browse/MESOS-6902
> Project: Mesos
>  Issue Type: Improvement
>  Components: agent
>Reporter: Neil Conway
>Assignee: Jay Guo
>  Labels: mesosphere
>
> Similarly to how we might add support for master capabilities (MESOS-5675), 
> agent capabilities would also make sense: in a mixed cluster, the master 
> might have support for features that are not present on certain agents, and 
> vice versa.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (MESOS-6902) Add support for agent capabilities

2017-01-17 Thread Benjamin Mahler (JIRA)

[ 
https://issues.apache.org/jira/browse/MESOS-6902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15826840#comment-15826840
 ] 

Benjamin Mahler commented on MESOS-6902:


The following introduce capabilities in AgentInfo, which gets exposed to the 
master. Executors also have AgentInfo available, but schedulers do not.

{noformat}

commit ec1a326397641af74b7349182159c07d360a4d73
Author: Jay Guo 
Date:   Tue Jan 17 13:14:36 2017 -0800

Added Capabilities to SlaveInfo protobuf message.

Frameworks can advertise their capabilities via the protobuf field
in FrameworkInfo and master can behave differently according them.
Similarly, agents should be able to advertise their capabilities in
a mixed cluster, so that master could make better decisions based
on them. For example, multi-role frameworks could only launch tasks
on agents with multi-role capabilities.

This allows us to handle upgrades in a more explicit manner, without
having to rely on version strings.

Review: https://reviews.apache.org/r/55562/
{noformat}

{noformat}
commit 4099daa87b9751d2917656e56dad2e416acc8a02
Author: Jay Guo 
Date:   Tue Jan 17 13:15:47 2017 -0800

Added capabilities to the master's Slave struct.

Review: https://reviews.apache.org/r/55563/
{noformat}

Right now there is no distinction between "internal" / "private" and "external" 
/ "public" capabilities either, which may be necessary in the future if we want 
to hide implementation details from the public API.

> Add support for agent capabilities
> --
>
> Key: MESOS-6902
> URL: https://issues.apache.org/jira/browse/MESOS-6902
> Project: Mesos
>  Issue Type: Improvement
>  Components: agent
>Reporter: Neil Conway
>Assignee: Jay Guo
>  Labels: mesosphere
>
> Similarly to how we might add support for master capabilities (MESOS-5675), 
> agent capabilities would also make sense: in a mixed cluster, the master 
> might have support for features that are not present on certain agents, and 
> vice versa.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (MESOS-6902) Add support for agent capabilities

2017-01-16 Thread Jay Guo (JIRA)

[ 
https://issues.apache.org/jira/browse/MESOS-6902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15823689#comment-15823689
 ] 

Jay Guo commented on MESOS-6902:


Some initial patches on protobuf messages:
https://reviews.apache.org/r/55562/
https://reviews.apache.org/r/55563/

> Add support for agent capabilities
> --
>
> Key: MESOS-6902
> URL: https://issues.apache.org/jira/browse/MESOS-6902
> Project: Mesos
>  Issue Type: Improvement
>  Components: agent
>Reporter: Neil Conway
>Assignee: Jay Guo
>  Labels: mesosphere
>
> Similarly to how we might add support for master capabilities (MESOS-5675), 
> agent capabilities would also make sense: in a mixed cluster, the master 
> might have support for features that are not present on certain agents, and 
> vice versa.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)