[jira] [Commented] (MESOS-7074) port_mapping isolator: do not depend on /sys/class/net//speed

2017-02-09 Thread Anand Mazumdar (JIRA)

[ 
https://issues.apache.org/jira/browse/MESOS-7074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15859781#comment-15859781
 ] 

Anand Mazumdar commented on MESOS-7074:
---

[~jieyu] I took the liberty of adding you as the shepherd here as the review 
was addressed to you.

> port_mapping isolator: do not depend on /sys/class/net//speed
> -
>
> Key: MESOS-7074
> URL: https://issues.apache.org/jira/browse/MESOS-7074
> Project: Mesos
>  Issue Type: Improvement
>  Components: isolation
>Reporter: Pierre Cheynier
>Assignee: Pierre Cheynier
>Priority: Minor
>
> I tried to use network/port_mapping isolator and faced this issue:  
> {{/sys/class/net//speed}} is unreadable because it is not set by the 
> underlying network driver.
> * on virtualized environment (KVM, virtualbox, AMIs, etc.)
> * on CentOS 7 with teaming driver enabled, it doesn't report the speed.
> {noformat}
> # cat /sys/class/net/team0/speed 
> cat: /sys/class/net/team0/speed: Invalid argument
> {noformat}
> Here is a pointer to the code blocks that perform those tests: 
> https://git-wip-us.apache.org/repos/asf?p=mesos.git;a=blob;f=src/slave/containerizer/mesos/isolators/network/port_mapping.cpp;h=f6f2bfe1d5d3c113036ad44a480f97bbb462a269;hb=HEAD#l1588
> In my opinion, to solve most of these use-cases, we could make those tests 
> non-blocking, i.e. replace errors by log/warnings.
> It could result in an inconsistency between the interface speed and the 
> bw_limit set, but I guess there are more benefits in making it usable in more 
> environments.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (MESOS-7074) port_mapping isolator: do not depend on /sys/class/net//speed

2017-02-09 Thread Pierre Cheynier (JIRA)

[ 
https://issues.apache.org/jira/browse/MESOS-7074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15859455#comment-15859455
 ] 

Pierre Cheynier commented on MESOS-7074:


https://reviews.apache.org/r/56493/

> port_mapping isolator: do not depend on /sys/class/net//speed
> -
>
> Key: MESOS-7074
> URL: https://issues.apache.org/jira/browse/MESOS-7074
> Project: Mesos
>  Issue Type: Improvement
>Reporter: Pierre Cheynier
>Priority: Minor
>
> I tried to use network/port_mapping isolator and faced this issue:  
> {{/sys/class/net//speed}} is unreadable because it is not set by the 
> underlying network driver.
> * on virtualized environment (KVM, virtualbox, AMIs, etc.)
> * on CentOS 7 with teaming driver enabled, it doesn't report the speed.
> {noformat}
> # cat /sys/class/net/team0/speed 
> cat: /sys/class/net/team0/speed: Invalid argument
> {noformat}
> Here is a pointer to the code blocks that perform those tests: 
> https://git-wip-us.apache.org/repos/asf?p=mesos.git;a=blob;f=src/slave/containerizer/mesos/isolators/network/port_mapping.cpp;h=f6f2bfe1d5d3c113036ad44a480f97bbb462a269;hb=HEAD#l1588
> In my opinion, to solve most of these use-cases, we could make those tests 
> non-blocking, i.e. replace errors by log/warnings.
> It could result in an inconsistency between the interface speed and the 
> bw_limit set, but I guess there are more benefits in making it usable in more 
> environments.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)