[jira] [Commented] (MESOS-7340) Log HTTP accesses to the /files endpoint
[
https://issues.apache.org/jira/browse/MESOS-7340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15989437#comment-15989437
]
Zhitao Li commented on MESOS-7340:
--
[~jamespeach], thanks for the response. Who do you think can help for
shepherding the HTTP logging module?
> Log HTTP accesses to the /files endpoint
>
>
> Key: MESOS-7340
> URL: https://issues.apache.org/jira/browse/MESOS-7340
> Project: Mesos
> Issue Type: Bug
> Components: HTTP API
>Reporter: James Peach
>Assignee: James Peach
>Priority: Minor
> Fix For: 1.3.0
>
>
> The Mesos master and agent log HTTP accesses, but the {{Files}} process does
> not. We should log accessed to the {{/files}} endpoint in the same way.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (MESOS-7340) Log HTTP accesses to the /files endpoint
[
https://issues.apache.org/jira/browse/MESOS-7340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15988971#comment-15988971
]
James Peach commented on MESOS-7340:
I did look into what would be needed for a more complete HTTP logging
subsystem. IIRC there are some wrinkles in {{libprocess}} that make it hard to
accurately identify the end of a HTTP transaction. I think the right approach
would be to add support a HTTP logging module, since you likely want HTTP
access logs to go to a different destination than Mesos debug logs. A module
also avoids the need to create a log configuration language.
> Log HTTP accesses to the /files endpoint
>
>
> Key: MESOS-7340
> URL: https://issues.apache.org/jira/browse/MESOS-7340
> Project: Mesos
> Issue Type: Bug
> Components: HTTP API
>Reporter: James Peach
>Assignee: James Peach
>Priority: Minor
> Fix For: 1.3.0
>
>
> The Mesos master and agent log HTTP accesses, but the {{Files}} process does
> not. We should log accessed to the {{/files}} endpoint in the same way.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (MESOS-7340) Log HTTP accesses to the /files endpoint
[
https://issues.apache.org/jira/browse/MESOS-7340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15987974#comment-15987974
]
Zhitao Li commented on MESOS-7340:
--
Just spotted this story: totally +1 for making this configurable, maybe also
include processing time of the entire HTTP request?
> Log HTTP accesses to the /files endpoint
>
>
> Key: MESOS-7340
> URL: https://issues.apache.org/jira/browse/MESOS-7340
> Project: Mesos
> Issue Type: Bug
> Components: HTTP API
>Reporter: James Peach
>Assignee: James Peach
>Priority: Minor
>
> The Mesos master and agent log HTTP accesses, but the {{Files}} process does
> not. We should log accessed to the {{/files}} endpoint in the same way.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (MESOS-7340) Log HTTP accesses to the /files endpoint
[
https://issues.apache.org/jira/browse/MESOS-7340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15959665#comment-15959665
]
Anand Mazumdar commented on MESOS-7340:
---
{noformat}
commit eeafd0425fb46c524b81a4c277e551b5e41af105
Author: James Peach
Date: Thu Apr 6 13:12:30 2017 -0700
Added HTTP request logging to the /files endpoint.
Review: https://reviews.apache.org/r/58223/
commit 8aad935c8edff78cffcd194b616a30be7be53dc9
Author: James Peach
Date: Thu Apr 6 13:11:50 2017 -0700
Added missing HTTP logging to agent endpoints.
A couple of agent endpoints (statistics and containers) were missing
HTTP logging.
Review: https://reviews.apache.org/r/58239/
commit 7963c53fa8f89e57dcda71b456b5123645eb0a9d
Author: James Peach
Date: Thu Apr 6 13:11:23 2017 -0700
Added a common HTTP request log helper function.
Consolidated the master and agent HTTP request log helper
functions into common code.
Review: https://reviews.apache.org/r/58185/
{noformat}
> Log HTTP accesses to the /files endpoint
>
>
> Key: MESOS-7340
> URL: https://issues.apache.org/jira/browse/MESOS-7340
> Project: Mesos
> Issue Type: Bug
> Components: HTTP API
>Reporter: James Peach
>Assignee: James Peach
>Priority: Minor
>
> The Mesos master and agent log HTTP accesses, but the {{Files}} process does
> not. We should log accessed to the {{/files}} endpoint in the same way.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (MESOS-7340) Log HTTP accesses to the /files endpoint
[
https://issues.apache.org/jira/browse/MESOS-7340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15959590#comment-15959590
]
James Peach commented on MESOS-7340:
Typically HTTP access logging is richly configurable. In the Mesos context,
this might be a candidate for a module, but I didn't want to make such a large
change at this time. I'm fine if you want to drop the last patch.
> Log HTTP accesses to the /files endpoint
>
>
> Key: MESOS-7340
> URL: https://issues.apache.org/jira/browse/MESOS-7340
> Project: Mesos
> Issue Type: Bug
> Components: HTTP API
>Reporter: James Peach
>Assignee: James Peach
>Priority: Minor
>
> The Mesos master and agent log HTTP accesses, but the {{Files}} process does
> not. We should log accessed to the {{/files}} endpoint in the same way.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (MESOS-7340) Log HTTP accesses to the /files endpoint
[
https://issues.apache.org/jira/browse/MESOS-7340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15959584#comment-15959584
]
Anand Mazumdar commented on MESOS-7340:
---
I have found the user agent logging to be useful in the past on at least 2
occasions in identifying the rogue script making calls to the {{/state}}
endpoint. That being said, it can be ambiguous if there is more than one
script(s) using the same underlying client library (same user agent). I can
also think of some more use cases around analyzing log files(?).
I would go ahead and commit the rest of the chain for now (minus the user agent
review). Let's wait for more inputs from [~bmahler] once he is back.
> Log HTTP accesses to the /files endpoint
>
>
> Key: MESOS-7340
> URL: https://issues.apache.org/jira/browse/MESOS-7340
> Project: Mesos
> Issue Type: Bug
> Components: HTTP API
>Reporter: James Peach
>Assignee: James Peach
>Priority: Minor
>
> The Mesos master and agent log HTTP accesses, but the {{Files}} process does
> not. We should log accessed to the {{/files}} endpoint in the same way.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (MESOS-7340) Log HTTP accesses to the /files endpoint
[
https://issues.apache.org/jira/browse/MESOS-7340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15956990#comment-15956990
]
James Peach commented on MESOS-7340:
{quote}
I'm inclined to think we should remove the user agent from HTTP request logging
in general, but that is a broader topic I guess.
{quote}
Right, hence the separate patch for that :)
> Log HTTP accesses to the /files endpoint
>
>
> Key: MESOS-7340
> URL: https://issues.apache.org/jira/browse/MESOS-7340
> Project: Mesos
> Issue Type: Bug
> Components: HTTP API
>Reporter: James Peach
>Assignee: James Peach
>Priority: Minor
>
> The Mesos master and agent log HTTP accesses, but the {{Files}} process does
> not. We should log accessed to the {{/files}} endpoint in the same way.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (MESOS-7340) Log HTTP accesses to the /files endpoint
[
https://issues.apache.org/jira/browse/MESOS-7340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15955926#comment-15955926
]
Neil Conway commented on MESOS-7340:
I'm inclined to think we should remove the user agent from HTTP request logging
in general, but that is a broader topic I guess.
> Log HTTP accesses to the /files endpoint
>
>
> Key: MESOS-7340
> URL: https://issues.apache.org/jira/browse/MESOS-7340
> Project: Mesos
> Issue Type: Bug
> Components: HTTP API
>Reporter: James Peach
>Assignee: James Peach
>Priority: Minor
>
> The Mesos master and agent log HTTP accesses, but the {{Files}} process does
> not. We should log accessed to the {{/files}} endpoint in the same way.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
