[jira] [Commented] (MESOS-7497) Remove CMake anti-pattern of `set(x "${x} ..")`.
[
https://issues.apache.org/jira/browse/MESOS-7497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16010992#comment-16010992
]
Joseph Wu commented on MESOS-7497:
--
Yup, need to partially revert until we decide to up the minimum CMake version:
{code}
commit 47562d925a715eb174ad9738d6d188dd6bfe
Author: Joseph Wu
Date: Mon May 15 10:50:43 2017 -0700
CMake: Reverts usage of `string(APPEND ...)`.
This partially reverts commit 4ce689c8e2be386d0086acce63ce5b8bbab6c34b.
`string(APPEND ...)` was added in CMake 3.4, but the earliest required
version of CMake is 2.8.12. `list(APPEND ...)` exists in 2.8.12,
so that pattern will not be reverted.
{code}
> Remove CMake anti-pattern of `set(x "${x} ..")`.
>
>
> Key: MESOS-7497
> URL: https://issues.apache.org/jira/browse/MESOS-7497
> Project: Mesos
> Issue Type: Improvement
>Reporter: Andrew Schwartzmeyer
>Assignee: Andrew Schwartzmeyer
>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (MESOS-7497) Remove CMake anti-pattern of `set(x "${x} ..")`.
[
https://issues.apache.org/jira/browse/MESOS-7497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16010981#comment-16010981
]
Andrew Schwartzmeyer commented on MESOS-7497:
-
The pattern `string(APPEND)` was added in CMake 3.4.
> Remove CMake anti-pattern of `set(x "${x} ..")`.
>
>
> Key: MESOS-7497
> URL: https://issues.apache.org/jira/browse/MESOS-7497
> Project: Mesos
> Issue Type: Improvement
>Reporter: Andrew Schwartzmeyer
>Assignee: Andrew Schwartzmeyer
>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (MESOS-7497) Remove CMake anti-pattern of `set(x "${x} ..")`.
[
https://issues.apache.org/jira/browse/MESOS-7497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16010958#comment-16010958
]
Joseph Wu commented on MESOS-7497:
--
{code}commit 4ce689c8e2be386d0086acce63ce5b8bbab6c34b
Author: Andrew Schwartzmeyer
Date: Wed May 10 14:08:06 2017 -0700
CMake: Use `list(APPEND x ...)` over `set(x ${x} ...)`.
This removes a CMake anti-pattern where `set` was used to append to a
variable, instead of the more explicit `list(APPEND)` or
`string(APPEND)` alternatives.
Review: https://reviews.apache.org/r/59156/
{code}
> Remove CMake anti-pattern of `set(x "${x} ..")`.
>
>
> Key: MESOS-7497
> URL: https://issues.apache.org/jira/browse/MESOS-7497
> Project: Mesos
> Issue Type: Improvement
>Reporter: Andrew Schwartzmeyer
>Assignee: Andrew Schwartzmeyer
>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
