[jira] [Commented] (MESOS-7753) `log.LearnedMessage` could be rejected due to being sent from '@0.0.0.0:0'
[
https://issues.apache.org/jira/browse/MESOS-7753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16090238#comment-16090238
]
Yan Xu commented on MESOS-7753:
---
Eventually decided to address this ticket separately from MESOS-7786. Will just
use the pid of the {{NetworkProcess}} as the sender.
> `log.LearnedMessage` could be rejected due to being sent from '@0.0.0.0:0'
> --
>
> Key: MESOS-7753
> URL: https://issues.apache.org/jira/browse/MESOS-7753
> Project: Mesos
> Issue Type: Bug
> Components: replicated log
>Reporter: Yan Xu
>Assignee: Yan Xu
>
> This is due to the use of
> https://github.com/apache/mesos/blob/ced7d69767142c912db0c2e01b95c0f5de791bd9/src/log/network.hpp#L247
> which sets the message's {{from}} field to an empty UPID.
> The rationale for using this form is that there's no intended response for
> this message. However with MESOS-7401, this message could be rejected.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (MESOS-7753) `log.LearnedMessage` could be rejected due to being sent from '@0.0.0.0:0'
[
https://issues.apache.org/jira/browse/MESOS-7753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16077282#comment-16077282
]
Yan Xu commented on MESOS-7753:
---
The libprocess change is still separate though as I feel that in production
logs for replicated log, a "real" process with a identifiable name as least
looks better?
> `log.LearnedMessage` could be rejected due to being sent from '@0.0.0.0:0'
> --
>
> Key: MESOS-7753
> URL: https://issues.apache.org/jira/browse/MESOS-7753
> Project: Mesos
> Issue Type: Bug
> Components: replicated log
>Reporter: Yan Xu
>
> This is due to the use of
> https://github.com/apache/mesos/blob/ced7d69767142c912db0c2e01b95c0f5de791bd9/src/log/network.hpp#L247
> which sets the message's {{from}} field to an empty UPID.
> The rationale for using this form is that there's no intended response for
> this message. However with MESOS-7401, this message could be rejected.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (MESOS-7753) `log.LearnedMessage` could be rejected due to being sent from '@0.0.0.0:0'
[
https://issues.apache.org/jira/browse/MESOS-7753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16077276#comment-16077276
]
Yan Xu commented on MESOS-7753:
---
This version of
[post|https://github.com/apache/mesos/blob/1b75c37cff41f1d6955e1b202f73193b57ea636f/3rdparty/libprocess/include/process/protobuf.hpp#L36]
is used mostly by tests but pretty convenient. I guess we can also have an
untyped `ProcessBase` as a sender that's implicitly created?
> `log.LearnedMessage` could be rejected due to being sent from '@0.0.0.0:0'
> --
>
> Key: MESOS-7753
> URL: https://issues.apache.org/jira/browse/MESOS-7753
> Project: Mesos
> Issue Type: Bug
> Components: replicated log
>Reporter: Yan Xu
>
> This is due to the use of
> https://github.com/apache/mesos/blob/ced7d69767142c912db0c2e01b95c0f5de791bd9/src/log/network.hpp#L247
> which sets the message's {{from}} field to an empty UPID.
> The rationale for using this form is that there's no intended response for
> this message. However with MESOS-7401, this message could be rejected.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (MESOS-7753) `log.LearnedMessage` could be rejected due to being sent from '@0.0.0.0:0'
[
https://issues.apache.org/jira/browse/MESOS-7753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16073159#comment-16073159
]
James Peach commented on MESOS-7753:
I agree that every message actually does have a sender. Even a broadcast is
sent from a specific {{Process}}. In this case, there is something that is a
member of the {{Network}} that is performing the broadcast, so it seems really
wonky to not have a source {{UPID}} (since membership in the network is defined
by a {{UPID}}). In the case it looks like the broadcast is sent by the
{{NetworkProcess}} so it should use the to/from version of {{process::post}}
(maybe we we should deprecate the to-only version?).
> `log.LearnedMessage` could be rejected due to being sent from '@0.0.0.0:0'
> --
>
> Key: MESOS-7753
> URL: https://issues.apache.org/jira/browse/MESOS-7753
> Project: Mesos
> Issue Type: Bug
> Components: replicated log
>Reporter: Yan Xu
>
> This is due to the use of
> https://github.com/apache/mesos/blob/ced7d69767142c912db0c2e01b95c0f5de791bd9/src/log/network.hpp#L247
> which sets the message's {{from}} field to an empty UPID.
> The rationale for using this form is that there's no intended response for
> this message. However with MESOS-7401, this message could be rejected.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (MESOS-7753) `log.LearnedMessage` could be rejected due to being sent from '@0.0.0.0:0'
[
https://issues.apache.org/jira/browse/MESOS-7753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16072972#comment-16072972
]
Yan Xu commented on MESOS-7753:
---
A few things in consideration:
- We cannot simply whitelist {{@0.0.0.0:0}} in MESOS-7401 otherwise the
protection mechanism is rendered useless.
- Even though some messages are not supposed to have a "return address", it
makes sense to always require a non-empty {{from}} address for actor to actor
communication.
- For non-testing libprocess communication in Mesos it makes sense to assume
all messages are sent by libprocess actors.
So for this the easiest fix is probably just give the {{LearnedMessage}} a
sender: define a simple {{RequestProcess}}, in contrast with {{ReqResProcess}},
which is used for other replicated log messages.
Of course no attempt has been made in the replicated log to really verify that
the learned message is sent by a coordinator so this is simply to make the
replicated log compliant with MESOS-7401.
/cc [~jpe...@apache.org] [~jieyu]
> `log.LearnedMessage` could be rejected due to being sent from '@0.0.0.0:0'
> --
>
> Key: MESOS-7753
> URL: https://issues.apache.org/jira/browse/MESOS-7753
> Project: Mesos
> Issue Type: Bug
> Components: replicated log
>Reporter: Yan Xu
>
> This is due to the use of
> https://github.com/apache/mesos/blob/ced7d69767142c912db0c2e01b95c0f5de791bd9/src/log/network.hpp#L247
> which sets the message's {{from}} field to an empty UPID.
> The rationale for using this form is that there's no intended response for
> this message. However with MESOS-7401, this message could be rejected.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
