[jira] [Commented] (MESOS-8221) Use protobuf reflection to simplify downgrading of resources.
[
https://issues.apache.org/jira/browse/MESOS-8221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308867#comment-16308867
]
Michael Park commented on MESOS-8221:
-
[~jieyu]: The protobuf reflection based approach caught cases that I had missed
in the containerizer code.
Specifically, {{ContainerTermination}} and {{ContainerConfig}} which contain
{{Resource}}. I believe
these resources also need to be downgraded in order for the agent to remain
downgradable.
After some digging, I found that the {{Resource}} in {{ContainerTermination}}
were added in
[98d96ca|https://github.com/apache/mesos/commit/98d96ca96570eb4d0d1604ba738c24ecc7e71f7f#diff-4d34722b5ad4f490a95639a6d441106dR256],
which is after 1.4.x, and the {{Resource}} in {{ContainerConfig}} were added
earlier but the {{ContainerConfig}}
message itself was not checkpointed until
[03a2a4d|https://github.com/apache/mesos/commit/03a2a4dfa47b1d47c5eb23e81f5ef8213e46d545#diff-c8ca6e064a8bf7b1b3c70e6525eabeceR1354]
which is also after 1.4.x. So we're fine on both counts, and
we should get this in for 1.5.0 to make sure these are downgraded, and to
future-proof.
> Use protobuf reflection to simplify downgrading of resources.
> -
>
> Key: MESOS-8221
> URL: https://issues.apache.org/jira/browse/MESOS-8221
> Project: Mesos
> Issue Type: Improvement
> Components: agent
>Reporter: Michael Park
>Assignee: Michael Park
>Priority: Blocker
>
> We currently have a {{downgradeResources}} function which is called on every
> {{repeated Resource}} field in every message that we checkpoint. We should
> leverage
> protobuf reflection to automatically downgrade any instances of {{Resource}}
> within any
> protobuf message.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (MESOS-8221) Use protobuf reflection to simplify downgrading of resources.
[
https://issues.apache.org/jira/browse/MESOS-8221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302048#comment-16302048
]
Jie Yu commented on MESOS-8221:
---
[~bmahler], [~mcypark], is this a blocker for 1.5.0?
> Use protobuf reflection to simplify downgrading of resources.
> -
>
> Key: MESOS-8221
> URL: https://issues.apache.org/jira/browse/MESOS-8221
> Project: Mesos
> Issue Type: Improvement
> Components: agent
>Reporter: Michael Park
>Assignee: Michael Park
>
> We currently have a {{downgradeResources}} function which is called on every
> {{repeated Resource}} field in every message that we checkpoint. We should
> leverage
> protobuf reflection to automatically downgrade any instances of {{Resource}}
> within any
> protobuf message.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (MESOS-8221) Use protobuf reflection to simplify downgrading of resources.
[
https://issues.apache.org/jira/browse/MESOS-8221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16260297#comment-16260297
]
Michael Park commented on MESOS-8221:
-
https://reviews.apache.org/r/63976/
https://reviews.apache.org/r/63977/
> Use protobuf reflection to simplify downgrading of resources.
> -
>
> Key: MESOS-8221
> URL: https://issues.apache.org/jira/browse/MESOS-8221
> Project: Mesos
> Issue Type: Improvement
> Components: agent
>Reporter: Michael Park
>Assignee: Michael Park
>
> We currently have a {{downgradeResources}} function which is called on every
> {{repeated Resource}} field in every message that we checkpoint. We should
> leverage
> protobuf reflection to automatically downgrade any instances of {{Resource}}
> within any
> protobuf message.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
