[jira] [Commented] (MESOS-8241) Add metrics for offer operation feedback
[
https://issues.apache.org/jira/browse/MESOS-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804560#comment-16804560
]
Benno Evers commented on MESOS-8241:
{noformat}
commit ede2a94ebaf9710516816bae7d012d926c533a59
Author: Benno Evers
Date: Thu Feb 28 18:02:56 2019 +0100
Added unit tests for offer operation feedback metrics.
This adds a set of checks to verify the metrics introduced
in the previous commit are working as intended.
Review: https://reviews.apache.org/r/70117
commit 18c401563c33022240fede63fbe3ec9b7bf4c385
Author: Benno Evers
Date: Thu Feb 28 18:03:27 2019 +0100
Added metrics for offer operation feedback.
This commit adds additional metrics counting the
number of operations in each state.
Unit tests are added in the subsequent commit.
Review: https://reviews.apache.org/r/70116
commit af2c47a5e680b5c3140fd7d4639750f476f1627c
Author: Benno Evers
Date: Thu Mar 7 17:51:22 2019 +0100
Added helper to test for metrics values.
This patch adds a new helper function to check
whether a given metric has some specified value.
Review: https://reviews.apache.org/r/70156
commit 5e4aa14a2b6c5c753248e642289c04a267aca074
Author: Benno Evers
Date: Thu Feb 28 18:01:47 2019 +0100
Updated comment about operations.
Review: https://reviews.apache.org/r/70115
{noformat}
> Add metrics for offer operation feedback
>
>
> Key: MESOS-8241
> URL: https://issues.apache.org/jira/browse/MESOS-8241
> Project: Mesos
> Issue Type: Task
>Reporter: Greg Mann
>Assignee: Benno Evers
>Priority: Blocker
> Labels: foundations, mesosphere, operation-feedback
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MESOS-8241) Add metrics for offer operation feedback
[ https://issues.apache.org/jira/browse/MESOS-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16783566#comment-16783566 ] Benno Evers commented on MESOS-8241: I've opened a review for the scope that is outline in the comment above at: https://reviews.apache.org/r/70116/ Some ideas I've had for further metrics that might become interesting: Master-wide versions of the per-framework metrics we currently collect about operations types: - master/operations/create_disk/finished - master/operations/create_disk/dropped - [...] A counter to see how many user-provided operations failed validation: - master/invalid_operations A per-framework counter for the number of unacknowledged operations. A counter for the total number of operation update retries. > Add metrics for offer operation feedback > > > Key: MESOS-8241 > URL: https://issues.apache.org/jira/browse/MESOS-8241 > Project: Mesos > Issue Type: Task >Reporter: Greg Mann >Assignee: Benno Evers >Priority: Major > Labels: foundations, mesosphere, operation-feedback > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MESOS-8241) Add metrics for offer operation feedback
[ https://issues.apache.org/jira/browse/MESOS-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16765518#comment-16765518 ] Greg Mann commented on MESOS-8241: -- This should include metrics for dropped operations. > Add metrics for offer operation feedback > > > Key: MESOS-8241 > URL: https://issues.apache.org/jira/browse/MESOS-8241 > Project: Mesos > Issue Type: Task >Reporter: Greg Mann >Priority: Major > Labels: foundations, mesosphere, operation-feedback > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
