[jira] [Commented] (MESOS-9688) Quota is not enforced properly when subroles have reservations.
[
https://issues.apache.org/jira/browse/MESOS-9688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16810208#comment-16810208
]
Benjamin Mahler commented on MESOS-9688:
Additional fix: https://reviews.apache.org/r/70393/
> Quota is not enforced properly when subroles have reservations.
> ---
>
> Key: MESOS-9688
> URL: https://issues.apache.org/jira/browse/MESOS-9688
> Project: Mesos
> Issue Type: Bug
> Components: allocation
>Reporter: Meng Zhu
>Assignee: Benjamin Mahler
>Priority: Critical
> Labels: resource-management
> Fix For: 1.8.0
>
>
> Note: the discussion here concerns quota enforcement for top-level role,
> setting quota on sublevel role is not supported.
> If a subrole directly makes a reservation, the accounting of
> `roleConsumedQuota` will be off:
> https://github.com/apache/mesos/blob/master/src/master/allocator/mesos/hierarchical.cpp#L1703-L1705
> Specifically, in this formula:
> `Consumed Quota = reservations + allocation - allocated reservations`
> The `reservations` part does not account subrole's reservation to its
> ancestors. If a reservation is made directly for role "a/b", its reservation
> is accounted only for "a/b" but not for "a". Similarly, if a top role ( "a")
> reservation is refined to a subrole ("a/b"), the current code first subtracts
> the reservation from "a" and then track that under "a/b".
> We should make it hierarchical-aware.
> The "allocation" and "allocated reservations" are both tracked in the sorter
> where the hierarchical relationship is considered -- allocations are added
> hierarchically.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MESOS-9688) Quota is not enforced properly when subroles have reservations.
[
https://issues.apache.org/jira/browse/MESOS-9688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16809876#comment-16809876
]
Benjamin Mahler commented on MESOS-9688:
Re-opening as there is an issue with the fix.
> Quota is not enforced properly when subroles have reservations.
> ---
>
> Key: MESOS-9688
> URL: https://issues.apache.org/jira/browse/MESOS-9688
> Project: Mesos
> Issue Type: Bug
> Components: allocation
>Reporter: Meng Zhu
>Assignee: Benjamin Mahler
>Priority: Critical
> Labels: resource-management
> Fix For: 1.8.0
>
>
> Note: the discussion here concerns quota enforcement for top-level role,
> setting quota on sublevel role is not supported.
> If a subrole directly makes a reservation, the accounting of
> `roleConsumedQuota` will be off:
> https://github.com/apache/mesos/blob/master/src/master/allocator/mesos/hierarchical.cpp#L1703-L1705
> Specifically, in this formula:
> `Consumed Quota = reservations + allocation - allocated reservations`
> The `reservations` part does not account subrole's reservation to its
> ancestors. If a reservation is made directly for role "a/b", its reservation
> is accounted only for "a/b" but not for "a". Similarly, if a top role ( "a")
> reservation is refined to a subrole ("a/b"), the current code first subtracts
> the reservation from "a" and then track that under "a/b".
> We should make it hierarchical-aware.
> The "allocation" and "allocated reservations" are both tracked in the sorter
> where the hierarchical relationship is considered -- allocations are added
> hierarchically.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
