[jira] [Commented] (METRON-1347) Indexing Topology should fail tuples without a source.type

2018-04-12 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/METRON-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16436489#comment-16436489
 ] 

ASF GitHub Bot commented on METRON-1347:


Github user ottobackwards commented on the issue:

https://github.com/apache/metron/pull/863
  
I think this is a mess that we will need to sort out, but I won't hold this 
up for that.
I'm +0 I guess.  


> Indexing Topology should fail tuples without a source.type
> --
>
> Key: METRON-1347
> URL: https://issues.apache.org/jira/browse/METRON-1347
> Project: Metron
>  Issue Type: Bug
>Reporter: Casey Stella
>Priority: Major
>
> If you are sending data into metron indexing without a source.type, which 
> would only happen if you're bypassing our previous topologies, we cannot 
> configure how we write to the indices, so the message should be explicitly 
> failed and reported.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] metron issue #863: METRON-1347: Indexing Topology should fail tuples without...

2018-04-12 Thread ottobackwards
Github user ottobackwards commented on the issue:

https://github.com/apache/metron/pull/863
  
I think this is a mess that we will need to sort out, but I won't hold this 
up for that.
I'm +0 I guess.  


---


[GitHub] metron issue #863: METRON-1347: Indexing Topology should fail tuples without...

2018-04-12 Thread mmiklavc
Github user mmiklavc commented on the issue:

https://github.com/apache/metron/pull/863
  
It seems this PR is meant to address the global case, since the writer is 
general purpose. Per @cestella's comments, I don't know that we can include 
original_string. I do think there's value in minimally ensuring the timestamp 
and source.type fields are validated in the near term. It seems that addressing 
a broader validation strategy might be in order, but maybe we could handle that 
separately as a compromise? Thoughts @ottobackwards?


---


[jira] [Commented] (METRON-1347) Indexing Topology should fail tuples without a source.type

2018-04-12 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/METRON-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16436417#comment-16436417
 ] 

ASF GitHub Bot commented on METRON-1347:


Github user mmiklavc commented on the issue:

https://github.com/apache/metron/pull/863
  
It seems this PR is meant to address the global case, since the writer is 
general purpose. Per @cestella's comments, I don't know that we can include 
original_string. I do think there's value in minimally ensuring the timestamp 
and source.type fields are validated in the near term. It seems that addressing 
a broader validation strategy might be in order, but maybe we could handle that 
separately as a compromise? Thoughts @ottobackwards?


> Indexing Topology should fail tuples without a source.type
> --
>
> Key: METRON-1347
> URL: https://issues.apache.org/jira/browse/METRON-1347
> Project: Metron
>  Issue Type: Bug
>Reporter: Casey Stella
>Priority: Major
>
> If you are sending data into metron indexing without a source.type, which 
> would only happen if you're bypassing our previous topologies, we cannot 
> configure how we write to the indices, so the message should be explicitly 
> failed and reported.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] metron pull request #990: METRON-1520: Add caching for stellar field transfo...

2018-04-12 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request:

https://github.com/apache/metron/pull/990#discussion_r181188219
  
--- Diff: metron-platform/Performance-tuning-guide.md ---
@@ -43,6 +43,16 @@ parallelism will leave you with idle consumers since 
Kafka limits the max number
 important because Kafka has certain ordering guarantees for message 
delivery per partition that would not be possible if more than
 one consumer in a given consumer group were able to read from that 
partition.
 
+## Parser Tuning Suggestions
+
+If you are using stellar field transformations in your parsers, by 
default, stellar expressions
+are not cached.  Turning on caching via setting the `cacheConfig` 
[property](metron-parsers#parser_configuration)
+in your parser configuration can have performance impact if your stellar 
expressions are
+complex (e.g. `ENRICHMENT_GET` calls or other high latency calls).  The 
tradeoff, though, is
+that non-deterministic stellar expressions will yield cached results which 
may be wrong,
+for the period of time in which the data exists in the cache (the max time 
in the cache is
+configurable).
+
--- End diff --

I think something like this is more straightforward:

"Sensors that use stellar field transformations by see a performance boost 
by turning on caching via setting the `cacheConfig` 
[property](metron-parsers#parser_configuration).
This is beneficial if your transformations:
- Are complex (e.g. `ENRICHEMENT_GET` calls or other high latency calls)
- All Yield the same results for the same inputs ( caching is either off or 
applied to *all* transformations)

If *any* of your transformations are non-deterministic, caching should not 
be used as it will result in the likelihood of incorrect results being 
returned."


---


[jira] [Commented] (METRON-1520) Add caching for stellar field transformations

2018-04-12 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/METRON-1520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16436150#comment-16436150
 ] 

ASF GitHub Bot commented on METRON-1520:


Github user ottobackwards commented on a diff in the pull request:

https://github.com/apache/metron/pull/990#discussion_r181185837
  
--- Diff: metron-platform/Performance-tuning-guide.md ---
@@ -43,6 +43,16 @@ parallelism will leave you with idle consumers since 
Kafka limits the max number
 important because Kafka has certain ordering guarantees for message 
delivery per partition that would not be possible if more than
 one consumer in a given consumer group were able to read from that 
partition.
 
--- End diff --

s/Parser/Sensor/ 
?


> Add caching for stellar field transformations
> -
>
> Key: METRON-1520
> URL: https://issues.apache.org/jira/browse/METRON-1520
> Project: Metron
>  Issue Type: Improvement
>Reporter: Casey Stella
>Priority: Major
>
> Given how important caching is in the enrichment topology, we should have 
> caching for stellar field transformations in the parsers as well.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (METRON-1520) Add caching for stellar field transformations

2018-04-12 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/METRON-1520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16436149#comment-16436149
 ] 

ASF GitHub Bot commented on METRON-1520:


Github user ottobackwards commented on a diff in the pull request:

https://github.com/apache/metron/pull/990#discussion_r181188219
  
--- Diff: metron-platform/Performance-tuning-guide.md ---
@@ -43,6 +43,16 @@ parallelism will leave you with idle consumers since 
Kafka limits the max number
 important because Kafka has certain ordering guarantees for message 
delivery per partition that would not be possible if more than
 one consumer in a given consumer group were able to read from that 
partition.
 
+## Parser Tuning Suggestions
+
+If you are using stellar field transformations in your parsers, by 
default, stellar expressions
+are not cached.  Turning on caching via setting the `cacheConfig` 
[property](metron-parsers#parser_configuration)
+in your parser configuration can have performance impact if your stellar 
expressions are
+complex (e.g. `ENRICHMENT_GET` calls or other high latency calls).  The 
tradeoff, though, is
+that non-deterministic stellar expressions will yield cached results which 
may be wrong,
+for the period of time in which the data exists in the cache (the max time 
in the cache is
+configurable).
+
--- End diff --

I think something like this is more straightforward:

"Sensors that use stellar field transformations by see a performance boost 
by turning on caching via setting the `cacheConfig` 
[property](metron-parsers#parser_configuration).
This is beneficial if your transformations:
- Are complex (e.g. `ENRICHEMENT_GET` calls or other high latency calls)
- All Yield the same results for the same inputs ( caching is either off or 
applied to *all* transformations)

If *any* of your transformations are non-deterministic, caching should not 
be used as it will result in the likelihood of incorrect results being 
returned."


> Add caching for stellar field transformations
> -
>
> Key: METRON-1520
> URL: https://issues.apache.org/jira/browse/METRON-1520
> Project: Metron
>  Issue Type: Improvement
>Reporter: Casey Stella
>Priority: Major
>
> Given how important caching is in the enrichment topology, we should have 
> caching for stellar field transformations in the parsers as well.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] metron pull request #990: METRON-1520: Add caching for stellar field transfo...

2018-04-12 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request:

https://github.com/apache/metron/pull/990#discussion_r181185837
  
--- Diff: metron-platform/Performance-tuning-guide.md ---
@@ -43,6 +43,16 @@ parallelism will leave you with idle consumers since 
Kafka limits the max number
 important because Kafka has certain ordering guarantees for message 
delivery per partition that would not be possible if more than
 one consumer in a given consumer group were able to read from that 
partition.
 
--- End diff --

s/Parser/Sensor/ 
?


---


[jira] [Commented] (METRON-1421) Create a SolrMetaAlertDao

2018-04-12 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/METRON-1421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16436144#comment-16436144
 ] 

ASF GitHub Bot commented on METRON-1421:


Github user justinleet commented on a diff in the pull request:

https://github.com/apache/metron/pull/970#discussion_r181186669
  
--- Diff: 
metron-platform/metron-solr/src/main/java/org/apache/metron/solr/dao/SolrSearchDao.java
 ---
@@ -238,19 +204,19 @@ protected SearchResponse buildSearchResponse(
 return searchResponse;
   }
 
-  protected SearchResult getSearchResult(SolrDocument solrDocument, 
Optional> fields) {
-SearchResult searchResult = new SearchResult();
-searchResult.setId((String) 
solrDocument.getFieldValue(Constants.GUID));
-Map source;
-if (fields.isPresent()) {
-  source = new HashMap<>();
-  fields.get().forEach(field -> source.put(field, 
solrDocument.getFieldValue(field)));
-} else {
-  source = solrDocument.getFieldValueMap();
-}
-searchResult.setSource(source);
-return searchResult;
-  }
+//  protected SearchResult getSearchResult(SolrDocument solrDocument, 
Optional> fields) {
--- End diff --

My bad.  The merge from the feature branch was messy and I didn't clean up 
after myself.


> Create a SolrMetaAlertDao
> -
>
> Key: METRON-1421
> URL: https://issues.apache.org/jira/browse/METRON-1421
> Project: Metron
>  Issue Type: Sub-task
>Reporter: Justin Leet
>Assignee: Justin Leet
>Priority: Major
>
> Create an implementation of the MetaAlertDao for Solr. This will involve 
> implementing the various MetaAlertDao methods using the SolrJ library and 
> also providing a SolrMetaAlertIntegrationTest (similar to 
> ElasticsearchMetaAlertIntegrationTest).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] metron pull request #970: METRON-1421: Create a SolrMetaAlertDao

2018-04-12 Thread justinleet
Github user justinleet commented on a diff in the pull request:

https://github.com/apache/metron/pull/970#discussion_r181186669
  
--- Diff: 
metron-platform/metron-solr/src/main/java/org/apache/metron/solr/dao/SolrSearchDao.java
 ---
@@ -238,19 +204,19 @@ protected SearchResponse buildSearchResponse(
 return searchResponse;
   }
 
-  protected SearchResult getSearchResult(SolrDocument solrDocument, 
Optional> fields) {
-SearchResult searchResult = new SearchResult();
-searchResult.setId((String) 
solrDocument.getFieldValue(Constants.GUID));
-Map source;
-if (fields.isPresent()) {
-  source = new HashMap<>();
-  fields.get().forEach(field -> source.put(field, 
solrDocument.getFieldValue(field)));
-} else {
-  source = solrDocument.getFieldValueMap();
-}
-searchResult.setSource(source);
-return searchResult;
-  }
+//  protected SearchResult getSearchResult(SolrDocument solrDocument, 
Optional> fields) {
--- End diff --

My bad.  The merge from the feature branch was messy and I didn't clean up 
after myself.


---


[jira] [Commented] (METRON-1421) Create a SolrMetaAlertDao

2018-04-12 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/METRON-1421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16436141#comment-16436141
 ] 

ASF GitHub Bot commented on METRON-1421:


Github user mmiklavc commented on a diff in the pull request:

https://github.com/apache/metron/pull/970#discussion_r181186288
  
--- Diff: 
metron-platform/metron-solr/src/main/java/org/apache/metron/solr/dao/SolrSearchDao.java
 ---
@@ -238,19 +204,19 @@ protected SearchResponse buildSearchResponse(
 return searchResponse;
   }
 
-  protected SearchResult getSearchResult(SolrDocument solrDocument, 
Optional> fields) {
-SearchResult searchResult = new SearchResult();
-searchResult.setId((String) 
solrDocument.getFieldValue(Constants.GUID));
-Map source;
-if (fields.isPresent()) {
-  source = new HashMap<>();
-  fields.get().forEach(field -> source.put(field, 
solrDocument.getFieldValue(field)));
-} else {
-  source = solrDocument.getFieldValueMap();
-}
-searchResult.setSource(source);
-return searchResult;
-  }
+//  protected SearchResult getSearchResult(SolrDocument solrDocument, 
Optional> fields) {
--- End diff --

Deleted 1 commented line, added 13 more? Haha.


> Create a SolrMetaAlertDao
> -
>
> Key: METRON-1421
> URL: https://issues.apache.org/jira/browse/METRON-1421
> Project: Metron
>  Issue Type: Sub-task
>Reporter: Justin Leet
>Assignee: Justin Leet
>Priority: Major
>
> Create an implementation of the MetaAlertDao for Solr. This will involve 
> implementing the various MetaAlertDao methods using the SolrJ library and 
> also providing a SolrMetaAlertIntegrationTest (similar to 
> ElasticsearchMetaAlertIntegrationTest).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] metron pull request #970: METRON-1421: Create a SolrMetaAlertDao

2018-04-12 Thread mmiklavc
Github user mmiklavc commented on a diff in the pull request:

https://github.com/apache/metron/pull/970#discussion_r181186288
  
--- Diff: 
metron-platform/metron-solr/src/main/java/org/apache/metron/solr/dao/SolrSearchDao.java
 ---
@@ -238,19 +204,19 @@ protected SearchResponse buildSearchResponse(
 return searchResponse;
   }
 
-  protected SearchResult getSearchResult(SolrDocument solrDocument, 
Optional> fields) {
-SearchResult searchResult = new SearchResult();
-searchResult.setId((String) 
solrDocument.getFieldValue(Constants.GUID));
-Map source;
-if (fields.isPresent()) {
-  source = new HashMap<>();
-  fields.get().forEach(field -> source.put(field, 
solrDocument.getFieldValue(field)));
-} else {
-  source = solrDocument.getFieldValueMap();
-}
-searchResult.setSource(source);
-return searchResult;
-  }
+//  protected SearchResult getSearchResult(SolrDocument solrDocument, 
Optional> fields) {
--- End diff --

Deleted 1 commented line, added 13 more? Haha.


---


[GitHub] metron pull request #:

2018-04-12 Thread justinleet
Github user justinleet commented on the pull request:


https://github.com/apache/metron/commit/a61b3a206c35674283af950e9e474bc5761e7c40#commitcomment-28553497
  
In 
metron-platform/metron-solr/src/main/java/org/apache/metron/solr/dao/SolrMetaAlertRetrieveLatestDao.java:
In 
metron-platform/metron-solr/src/main/java/org/apache/metron/solr/dao/SolrMetaAlertRetrieveLatestDao.java
 on line 62:
Should be gone in latest commit.


---


[jira] [Commented] (METRON-1507) Add support for Vagrant Cachier plugin if present

2018-04-12 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/METRON-1507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16436105#comment-16436105
 ] 

ASF GitHub Bot commented on METRON-1507:


Github user nickwallen commented on the issue:

https://github.com/apache/metron/pull/993
  
+1 Works great, thanks!


> Add support for Vagrant Cachier plugin if present
> -
>
> Key: METRON-1507
> URL: https://issues.apache.org/jira/browse/METRON-1507
> Project: Metron
>  Issue Type: Improvement
>Reporter: Simon Elliston Ball
>Priority: Trivial
>
> Add configuration in development vagrant files to support vagrant cachier 
> ([http://fgrehm.viewdocs.io/vagrant-cachier/)] to reduce development machine 
> install times. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] metron issue #993: METRON-1507 Add configuration in development vagrant file...

2018-04-12 Thread nickwallen
Github user nickwallen commented on the issue:

https://github.com/apache/metron/pull/993
  
+1 Works great, thanks!


---


[GitHub] metron pull request #:

2018-04-12 Thread mmiklavc
Github user mmiklavc commented on the pull request:


https://github.com/apache/metron/commit/a61b3a206c35674283af950e9e474bc5761e7c40#commitcomment-28550479
  
In 
metron-platform/metron-solr/src/main/java/org/apache/metron/solr/dao/SolrMetaAlertRetrieveLatestDao.java:
In 
metron-platform/metron-solr/src/main/java/org/apache/metron/solr/dao/SolrMetaAlertRetrieveLatestDao.java
 on line 62:
Probably delete this line


---


[jira] [Commented] (METRON-1520) Add caching for stellar field transformations

2018-04-12 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/METRON-1520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435783#comment-16435783
 ] 

ASF GitHub Bot commented on METRON-1520:


Github user cestella commented on the issue:

https://github.com/apache/metron/pull/990
  
Ok, turned off by default and added some more detail to the performance 
tuning guide.


> Add caching for stellar field transformations
> -
>
> Key: METRON-1520
> URL: https://issues.apache.org/jira/browse/METRON-1520
> Project: Metron
>  Issue Type: Improvement
>Reporter: Casey Stella
>Priority: Major
>
> Given how important caching is in the enrichment topology, we should have 
> caching for stellar field transformations in the parsers as well.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] metron issue #990: METRON-1520: Add caching for stellar field transformation...

2018-04-12 Thread cestella
Github user cestella commented on the issue:

https://github.com/apache/metron/pull/990
  
Ok, turned off by default and added some more detail to the performance 
tuning guide.


---


[jira] [Commented] (METRON-1503) Alerts are not getting populated in alerts UI when search engine is Solr

2018-04-12 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/METRON-1503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435708#comment-16435708
 ] 

ASF GitHub Bot commented on METRON-1503:


Github user merrimanr closed the pull request at:

https://github.com/apache/metron/pull/975


> Alerts are not getting populated in alerts UI when search engine is Solr
> 
>
> Key: METRON-1503
> URL: https://issues.apache.org/jira/browse/METRON-1503
> Project: Metron
>  Issue Type: Bug
>Reporter: Ryan Merriman
>Assignee: Ryan Merriman
>Priority: Major
>
> When navigating to the Alerts UI no alerts are displayed.  REST is returning 
> this error on a search call:
> {{Mar 27, 2018 6:51:50 AM org.apache.catalina.core.StandardWrapperValve 
> invoke SEVERE: Servlet.service() for servlet [dispatcherServlet] in context 
> with path [] threw exception [Request processing failed; nested exception is 
> org.apache.solr.common.SolrException: Collection not found: websphere] with 
> root cause org.apache.solr.common.SolrException: Collection not found: 
> websphere at 
> org.apache.solr.client.solrj.impl.CloudSolrClient.getCollectionNames(CloudSolrClient.java:1401)
>  at 
> org.apache.solr.client.solrj.impl.CloudSolrClient.requestWithRetryOnStaleState(CloudSolrClient.java:1094)
>  at 
> org.apache.solr.client.solrj.impl.CloudSolrClient.request(CloudSolrClient.java:1073)
>  at org.apache.solr.client.solrj.SolrRequest.process(SolrRequest.java:160) at 
> org.apache.solr.client.solrj.SolrClient.query(SolrClient.java:942) at 
> org.apache.solr.client.solrj.SolrClient.query(SolrClient.java:957) at 
> org.apache.metron.solr.dao.SolrSearchDao.search(SolrSearchDao.java:89) at 
> org.apache.metron.solr.dao.SolrDao.search(SolrDao.java:90) at 
> org.apache.metron.solr.dao.SolrMetaAlertDao.search(SolrMetaAlertDao.java:89) 
> at 
> org.apache.metron.rest.service.impl.SearchServiceImpl.search(SearchServiceImpl.java:73)
>  at 
> org.apache.metron.rest.controller.SearchController.search(SearchController.java:54)
>  at sun.reflect.GeneratedMethodAccessor199.invoke(Unknown Source) at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  at java.lang.reflect.Method.invoke(Method.java:498) at 
> org.springframework.web.method.support.InvocableHandlerMethod.doInvoke(InvocableHandlerMethod.java:221)
>  at 
> org.springframework.web.method.support.InvocableHandlerMethod.invokeForRequest(InvocableHandlerMethod.java:136)
>  at 
> org.springframework.web.servlet.mvc.method.annotation.ServletInvocableHandlerMethod.invokeAndHandle(ServletInvocableHandlerMethod.java:114)
>  at 
> org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.invokeHandlerMethod(RequestMappingHandlerAdapter.java:827)
>  at 
> org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.handleInternal(RequestMappingHandlerAdapter.java:738)
>  at 
> org.springframework.web.servlet.mvc.method.AbstractHandlerMethodAdapter.handle(AbstractHandlerMethodAdapter.java:85)
>  at 
> org.springframework.web.servlet.DispatcherServlet.doDispatch(DispatcherServlet.java:963)
>  at 
> org.springframework.web.servlet.DispatcherServlet.doService(DispatcherServlet.java:897)
>  at 
> org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:970)
>  at 
> org.springframework.web.servlet.FrameworkServlet.doPost(FrameworkServlet.java:872)
>  at javax.servlet.http.HttpServlet.service(HttpServlet.java:648) at 
> org.springframework.web.servlet.FrameworkServlet.service(FrameworkServlet.java:846)
>  at javax.servlet.http.HttpServlet.service(HttpServlet.java:729) at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:230)
>  at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:165)
>  at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52) at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:192)
>  at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:165)
>  at 
> org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:317)}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] metron pull request #975: METRON-1503: Alerts are not getting populated in a...

2018-04-12 Thread merrimanr
Github user merrimanr closed the pull request at:

https://github.com/apache/metron/pull/975


---


[jira] [Commented] (METRON-1507) Add support for Vagrant Cachier plugin if present

2018-04-12 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/METRON-1507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435651#comment-16435651
 ] 

ASF GitHub Bot commented on METRON-1507:


Github user nickwallen commented on the issue:

https://github.com/apache/metron/pull/993
  
We're just missing the README changes that you had in the previous PR that 
you opened.


> Add support for Vagrant Cachier plugin if present
> -
>
> Key: METRON-1507
> URL: https://issues.apache.org/jira/browse/METRON-1507
> Project: Metron
>  Issue Type: Improvement
>Reporter: Simon Elliston Ball
>Priority: Trivial
>
> Add configuration in development vagrant files to support vagrant cachier 
> ([http://fgrehm.viewdocs.io/vagrant-cachier/)] to reduce development machine 
> install times. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] metron issue #993: METRON-1507 Add configuration in development vagrant file...

2018-04-12 Thread nickwallen
Github user nickwallen commented on the issue:

https://github.com/apache/metron/pull/993
  
We're just missing the README changes that you had in the previous PR that 
you opened.


---


[jira] [Commented] (METRON-1521) JSONMapParser is no longer serializable

2018-04-12 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/METRON-1521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435552#comment-16435552
 ] 

ASF GitHub Bot commented on METRON-1521:


Github user asfgit closed the pull request at:

https://github.com/apache/metron/pull/991


> JSONMapParser is no longer serializable
> ---
>
> Key: METRON-1521
> URL: https://issues.apache.org/jira/browse/METRON-1521
> Project: Metron
>  Issue Type: Bug
>Reporter: Casey Stella
>Priority: Major
>
> Currently the JSONMapParser does not function because an anonymous inner 
> class (TypeRef) is not serializable.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] metron pull request #991: METRON-1521: JSONMapParser is no longer serializab...

2018-04-12 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/metron/pull/991


---


[jira] [Commented] (METRON-1523) Add issues list links to metron.apache.org community page

2018-04-12 Thread Simon Elliston Ball (JIRA)

[ 
https://issues.apache.org/jira/browse/METRON-1523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435525#comment-16435525
 ] 

Simon Elliston Ball commented on METRON-1523:
-

Looks like this has been done in METRON-1510, but not published.

> Add issues list links to metron.apache.org community page
> -
>
> Key: METRON-1523
> URL: https://issues.apache.org/jira/browse/METRON-1523
> Project: Metron
>  Issue Type: Task
>Reporter: Simon Elliston Ball
>Assignee: Simon Elliston Ball
>Priority: Trivial
>
> Now we've split out issues the links should be added to our website.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (METRON-1523) Add issues list links to metron.apache.org community page

2018-04-12 Thread Simon Elliston Ball (JIRA)
Simon Elliston Ball created METRON-1523:
---

 Summary: Add issues list links to metron.apache.org community page
 Key: METRON-1523
 URL: https://issues.apache.org/jira/browse/METRON-1523
 Project: Metron
  Issue Type: Task
Reporter: Simon Elliston Ball
Assignee: Simon Elliston Ball


Now we've split out issues the links should be added to our website.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (METRON-1507) Add support for Vagrant Cachier plugin if present

2018-04-12 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/METRON-1507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435503#comment-16435503
 ] 

ASF GitHub Bot commented on METRON-1507:


GitHub user simonellistonball opened a pull request:

https://github.com/apache/metron/pull/993

METRON-1507 Add configuration in development vagrant files to support 
vagrant cac…

## Contributor Comments
This is a Vagrant config change to enable the use of vagrant-cachier to 
reduce build times for the full dev platform. Time saving is heavily network 
dependent, but anecdotally I've found it saves me around 10 mins per provision 
of vagrant development environment. YMMV.

To test:

1. Install vagrant-cachier, and spin up centos and ubuntu vagrant 
development platforms.
2. Verify that packages are populated into your local (the client running 
vagrant) ~/.vagrant/cache directories.
3. vagrant destroy your development environments
4. spin up vagrant environments again, packages should be pulled from the 
cache instead of the network at this point.
5. spin up a vagrant environment on a machine that does not have cachier 
installed and ensure that the dev platform still builds

Note that the vagrant-cachier plugin is not required, nor shipped, bundled 
or in any way distributed by this change. It does have a compatible license 
(MIT) but it is outside of the Metron project scope to install this, so there 
is no need to update license or dependency documentation.

## Pull Request Checklist

Thank you for submitting a contribution to Apache Metron.  
Please refer to our [Development 
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
 for the complete guide to follow for contributions.  
Please refer also to our [Build Verification 
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
 for complete smoke testing guides.  


In order to streamline the review of the contribution we ask you follow 
these guidelines and ask you to double check the following:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to 
be created at [Metron 
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
- [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?


### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is 
being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified 
and tested manually?
- [ ] Have you ensured that the full suite of tests and checks have been 
executed in the root metron folder via:
  ```
  mvn -q clean integration-test install && 
dev-utilities/build-utils/verify_licenses.sh 
  ```

- [ ] Have you written or updated unit tests and or integration tests to 
verify your changes?
- [x] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] Have you verified the basic functionality of the build by building 
and running locally with Vagrant full-dev environment or the equivalent?

### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in 
which it is rendered by building and verifying the site-book? If not then run 
the following commands and the verify changes via 
`site-book/target/site/index.html`:

  ```
  cd site-book
  mvn site
  ```

 Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up 
for your personal repository such that your branches are built there before 
submitting a pull request.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/simonellistonball/metron METRON-1507

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/metron/pull/993.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #993


commit 2c97d3aad9e5312e010139a403c946cbff9bed6f
Author: Simon Elliston Ball 
Date:   2018-04-12T12:53:04Z

Add configuration in development vagrant files to support vagrant cachier 
([http://fgrehm.viewdocs.io/vagrant-c

[GitHub] metron pull request #993: METRON-1507 Add configuration in development vagra...

2018-04-12 Thread simonellistonball
GitHub user simonellistonball opened a pull request:

https://github.com/apache/metron/pull/993

METRON-1507 Add configuration in development vagrant files to support 
vagrant cac…

## Contributor Comments
This is a Vagrant config change to enable the use of vagrant-cachier to 
reduce build times for the full dev platform. Time saving is heavily network 
dependent, but anecdotally I've found it saves me around 10 mins per provision 
of vagrant development environment. YMMV.

To test:

1. Install vagrant-cachier, and spin up centos and ubuntu vagrant 
development platforms.
2. Verify that packages are populated into your local (the client running 
vagrant) ~/.vagrant/cache directories.
3. vagrant destroy your development environments
4. spin up vagrant environments again, packages should be pulled from the 
cache instead of the network at this point.
5. spin up a vagrant environment on a machine that does not have cachier 
installed and ensure that the dev platform still builds

Note that the vagrant-cachier plugin is not required, nor shipped, bundled 
or in any way distributed by this change. It does have a compatible license 
(MIT) but it is outside of the Metron project scope to install this, so there 
is no need to update license or dependency documentation.

## Pull Request Checklist

Thank you for submitting a contribution to Apache Metron.  
Please refer to our [Development 
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
 for the complete guide to follow for contributions.  
Please refer also to our [Build Verification 
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
 for complete smoke testing guides.  


In order to streamline the review of the contribution we ask you follow 
these guidelines and ask you to double check the following:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to 
be created at [Metron 
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
- [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?


### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is 
being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified 
and tested manually?
- [ ] Have you ensured that the full suite of tests and checks have been 
executed in the root metron folder via:
  ```
  mvn -q clean integration-test install && 
dev-utilities/build-utils/verify_licenses.sh 
  ```

- [ ] Have you written or updated unit tests and or integration tests to 
verify your changes?
- [x] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] Have you verified the basic functionality of the build by building 
and running locally with Vagrant full-dev environment or the equivalent?

### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in 
which it is rendered by building and verifying the site-book? If not then run 
the following commands and the verify changes via 
`site-book/target/site/index.html`:

  ```
  cd site-book
  mvn site
  ```

 Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up 
for your personal repository such that your branches are built there before 
submitting a pull request.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/simonellistonball/metron METRON-1507

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/metron/pull/993.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #993


commit 2c97d3aad9e5312e010139a403c946cbff9bed6f
Author: Simon Elliston Ball 
Date:   2018-04-12T12:53:04Z

Add configuration in development vagrant files to support vagrant cachier 
([http://fgrehm.viewdocs.io/vagrant-cachier/)] to reduce development machine 
install times.




---


[jira] [Commented] (METRON-1507) Add support for Vagrant Cachier plugin if present

2018-04-12 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/METRON-1507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435489#comment-16435489
 ] 

ASF GitHub Bot commented on METRON-1507:


Github user simonellistonball closed the pull request at:

https://github.com/apache/metron/pull/979


> Add support for Vagrant Cachier plugin if present
> -
>
> Key: METRON-1507
> URL: https://issues.apache.org/jira/browse/METRON-1507
> Project: Metron
>  Issue Type: Improvement
>Reporter: Simon Elliston Ball
>Priority: Trivial
>
> Add configuration in development vagrant files to support vagrant cachier 
> ([http://fgrehm.viewdocs.io/vagrant-cachier/)] to reduce development machine 
> install times. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] metron pull request #979: METRON-1507 Added support for vagrant cachier

2018-04-12 Thread simonellistonball
Github user simonellistonball closed the pull request at:

https://github.com/apache/metron/pull/979


---


[jira] [Commented] (METRON-1522) Fix the typo errors at profile debugger readme

2018-04-12 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/METRON-1522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435437#comment-16435437
 ] 

ASF GitHub Bot commented on METRON-1522:


Github user nickwallen commented on the issue:

https://github.com/apache/metron/pull/992
  
+1 Thanks @MohanDV 


> Fix the typo errors at profile debugger readme 
> ---
>
> Key: METRON-1522
> URL: https://issues.apache.org/jira/browse/METRON-1522
> Project: Metron
>  Issue Type: Bug
>Reporter: Mohan
>Assignee: Mohan
>Priority: Trivial
>
> https://github.com/apache/metron/tree/master/metron-analytics/metron-profiler#creating-profiles
>  
> There is typo error at step 6 , The profile name has been used as 'p' and 
> 'profiler' at places . 
> {code:java}
> [Stellar]>>> values := PROFILER_FLUSH(profiler) 
> {code}
> it should be 
> {code:java}
> [Stellar]>>> values := PROFILER_FLUSH(p)
> {code}
> Or to keep it consistent across the sections the profile definition should be 
> renamed to 'profiler' instead of 'p'  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] metron issue #992: METRON-1522: Fix the typo errors at profiler debugger rea...

2018-04-12 Thread nickwallen
Github user nickwallen commented on the issue:

https://github.com/apache/metron/pull/992
  
+1 Thanks @MohanDV 


---


[jira] [Commented] (METRON-1516) Support for Ansible 2.5.0

2018-04-12 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/METRON-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435409#comment-16435409
 ] 

ASF GitHub Bot commented on METRON-1516:


Github user asfgit closed the pull request at:

https://github.com/apache/metron/pull/989


> Support for Ansible 2.5.0
> -
>
> Key: METRON-1516
> URL: https://issues.apache.org/jira/browse/METRON-1516
> Project: Metron
>  Issue Type: New Feature
>Reporter: Otto Fowler
>Assignee: Otto Fowler
>Priority: Major
>
> I was forced to update ansible to 2.5.0 to resolve errors with vagrant, but 
> our ansible scripts don't support it.
>  
> I have 'patch' tested and had no issues.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] metron pull request #989: METRON-1516 Support for Ansible 2.5.0

2018-04-12 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/metron/pull/989


---


[jira] [Commented] (METRON-1522) Fix the typo errors at profile debugger readme

2018-04-12 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/METRON-1522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435374#comment-16435374
 ] 

ASF GitHub Bot commented on METRON-1522:


GitHub user MohanDV opened a pull request:

https://github.com/apache/metron/pull/992

METRON-1522: Fix the typo errors at profiler debugger readme

## Contributor Comments
Fix the typo errors at profiler debugger readme to keep the profile name 
consistent in flush profile section and reference to the profile across 
sections.

## Pull Request Checklist

Thank you for submitting a contribution to Apache Metron.  
Please refer to our [Development 
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
 for the complete guide to follow for contributions.  
Please refer also to our [Build Verification 
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
 for complete smoke testing guides.  


In order to streamline the review of the contribution we ask you follow 
these guidelines and ask you to double check the following:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to 
be created at [Metron 
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
- [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?


### For code changes:
- [ ] Have you included steps to reproduce the behavior or problem that is 
being changed or addressed?
- [ ] Have you included steps or a guide to how the change may be verified 
and tested manually?
- [ ] Have you ensured that the full suite of tests and checks have been 
executed in the root metron folder via:
  ```
  mvn -q clean integration-test install && 
dev-utilities/build-utils/verify_licenses.sh 
  ```

- [ ] Have you written or updated unit tests and or integration tests to 
verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] Have you verified the basic functionality of the build by building 
and running locally with Vagrant full-dev environment or the equivalent?

### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in 
which it is rendered by building and verifying the site-book? If not then run 
the following commands and the verify changes via 
`site-book/target/site/index.html`:

  ```
  cd site-book
  mvn site
  ```

 Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up 
for your personal repository such that your branches are built there before 
submitting a pull request.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MohanDV/metron METRON-1522

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/metron/pull/992.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #992


commit b5e151af7602e5bde247dc1b6cd6592fcb467e1a
Author: Mohan Venkateshaiah 
Date:   2018-04-12T11:05:39Z

update the doc to fix typo errors.




> Fix the typo errors at profile debugger readme 
> ---
>
> Key: METRON-1522
> URL: https://issues.apache.org/jira/browse/METRON-1522
> Project: Metron
>  Issue Type: Bug
>Reporter: Mohan
>Assignee: Mohan
>Priority: Trivial
>
> https://github.com/apache/metron/tree/master/metron-analytics/metron-profiler#creating-profiles
>  
> There is typo error at step 6 , The profile name has been used as 'p' and 
> 'profiler' at places . 
> {code:java}
> [Stellar]>>> values := PROFILER_FLUSH(profiler) 
> {code}
> it should be 
> {code:java}
> [Stellar]>>> values := PROFILER_FLUSH(p)
> {code}
> Or to keep it consistent across the sections the profile definition should be 
> renamed to 'profiler' instead of 'p'  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] metron pull request #992: METRON-1522: Fix the typo errors at profiler debug...

2018-04-12 Thread MohanDV
GitHub user MohanDV opened a pull request:

https://github.com/apache/metron/pull/992

METRON-1522: Fix the typo errors at profiler debugger readme

## Contributor Comments
Fix the typo errors at profiler debugger readme to keep the profile name 
consistent in flush profile section and reference to the profile across 
sections.

## Pull Request Checklist

Thank you for submitting a contribution to Apache Metron.  
Please refer to our [Development 
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
 for the complete guide to follow for contributions.  
Please refer also to our [Build Verification 
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
 for complete smoke testing guides.  


In order to streamline the review of the contribution we ask you follow 
these guidelines and ask you to double check the following:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to 
be created at [Metron 
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
- [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?


### For code changes:
- [ ] Have you included steps to reproduce the behavior or problem that is 
being changed or addressed?
- [ ] Have you included steps or a guide to how the change may be verified 
and tested manually?
- [ ] Have you ensured that the full suite of tests and checks have been 
executed in the root metron folder via:
  ```
  mvn -q clean integration-test install && 
dev-utilities/build-utils/verify_licenses.sh 
  ```

- [ ] Have you written or updated unit tests and or integration tests to 
verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] Have you verified the basic functionality of the build by building 
and running locally with Vagrant full-dev environment or the equivalent?

### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in 
which it is rendered by building and verifying the site-book? If not then run 
the following commands and the verify changes via 
`site-book/target/site/index.html`:

  ```
  cd site-book
  mvn site
  ```

 Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up 
for your personal repository such that your branches are built there before 
submitting a pull request.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MohanDV/metron METRON-1522

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/metron/pull/992.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #992


commit b5e151af7602e5bde247dc1b6cd6592fcb467e1a
Author: Mohan Venkateshaiah 
Date:   2018-04-12T11:05:39Z

update the doc to fix typo errors.




---


[jira] [Updated] (METRON-1522) Fix the typo errors at profile debugger readme

2018-04-12 Thread Mohan (JIRA)

 [ 
https://issues.apache.org/jira/browse/METRON-1522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mohan updated METRON-1522:
--
Summary: Fix the typo errors at profile debugger readme   (was: Fix the 
typo error at flushing profile in the profile debugger readme )

> Fix the typo errors at profile debugger readme 
> ---
>
> Key: METRON-1522
> URL: https://issues.apache.org/jira/browse/METRON-1522
> Project: Metron
>  Issue Type: Bug
>Reporter: Mohan
>Assignee: Mohan
>Priority: Trivial
>
> https://github.com/apache/metron/tree/master/metron-analytics/metron-profiler#creating-profiles
>  
> There is typo error at step 6 , The profile name has been used as 'p' and 
> 'profiler' at places . 
> {code:java}
> [Stellar]>>> values := PROFILER_FLUSH(profiler) 
> {code}
> it should be 
> {code:java}
> [Stellar]>>> values := PROFILER_FLUSH(p)
> {code}
> Or to keep it consistent across the sections the profile definition should be 
> renamed to 'profiler' instead of 'p'  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (METRON-1522) Fix the typo error at flushing profile in the profile debugger readme

2018-04-12 Thread Mohan (JIRA)

 [ 
https://issues.apache.org/jira/browse/METRON-1522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mohan updated METRON-1522:
--
Description: 
https://github.com/apache/metron/tree/master/metron-analytics/metron-profiler#creating-profiles
 

There is typo error at step 6 , The profile name has been used as 'p' and 
'profiler' at places . 

{code:java}
[Stellar]>>> values := PROFILER_FLUSH(profiler) 
{code}

it should be 

{code:java}
[Stellar]>>> values := PROFILER_FLUSH(p)
{code}

Or to keep it consistent across the sections the profile definition should be 
renamed to 'profiler' instead of 'p'  

  was:
https://github.com/apache/metron/tree/master/metron-analytics/metron-profiler#creating-profiles
 

There is typo error at step 6 

{code:java}
[Stellar]>>> values := PROFILER_FLUSH(profiler) 
{code}

it should be 

{code:java}
[Stellar]>>> values := PROFILER_FLUSH(p)
{code}



> Fix the typo error at flushing profile in the profile debugger readme 
> --
>
> Key: METRON-1522
> URL: https://issues.apache.org/jira/browse/METRON-1522
> Project: Metron
>  Issue Type: Bug
>Reporter: Mohan
>Assignee: Mohan
>Priority: Trivial
>
> https://github.com/apache/metron/tree/master/metron-analytics/metron-profiler#creating-profiles
>  
> There is typo error at step 6 , The profile name has been used as 'p' and 
> 'profiler' at places . 
> {code:java}
> [Stellar]>>> values := PROFILER_FLUSH(profiler) 
> {code}
> it should be 
> {code:java}
> [Stellar]>>> values := PROFILER_FLUSH(p)
> {code}
> Or to keep it consistent across the sections the profile definition should be 
> renamed to 'profiler' instead of 'p'  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (METRON-1522) Fix the typo error at flushing profile in the profile debugger readme

2018-04-12 Thread Mohan (JIRA)
Mohan created METRON-1522:
-

 Summary: Fix the typo error at flushing profile in the profile 
debugger readme 
 Key: METRON-1522
 URL: https://issues.apache.org/jira/browse/METRON-1522
 Project: Metron
  Issue Type: Bug
Reporter: Mohan
Assignee: Mohan


https://github.com/apache/metron/tree/master/metron-analytics/metron-profiler#creating-profiles
 

There is typo error at step 6 

{code:java}
[Stellar]>>> values := PROFILER_FLUSH(profiler) 
{code}

it should be 

{code:java}
[Stellar]>>> values := PROFILER_FLUSH(p)
{code}




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)