[jira] [Created] (METRON-1640) Allow the user to store or not the original_string in ES
Michel Sumbul created METRON-1640: - Summary: Allow the user to store or not the original_string in ES Key: METRON-1640 URL: https://issues.apache.org/jira/browse/METRON-1640 Project: Metron Issue Type: Improvement Reporter: Michel Sumbul Hi, Currently, all the messages stored in ES have the original_string. Keeping the original string and all the parse data might conduct to store up to 2 times more data. This implied that the needed infrastructure to handle this will have to be much more important, so a bigger cost. The user might be interested to keep it for legal reason or to be able to do text search on it but he might also decide to remove it because it has no added value and cost space. Moreover the original_string will remain in HDFS in case they need it, so no lost of data. The goal of this request is: * to have a check box (or another UI interface) in the configuration of the sensor specifying if the original string has to be ingested in ES. * Modifying the indexing storm topology to remove that field before saving the data to ES -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (METRON-1416) Upgrade Solr
[ https://issues.apache.org/jira/browse/METRON-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524216#comment-16524216 ] ASF GitHub Bot commented on METRON-1416: Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/1076 > Upgrade Solr > > > Key: METRON-1416 > URL: https://issues.apache.org/jira/browse/METRON-1416 > Project: Metron > Issue Type: Bug >Reporter: Justin Leet >Priority: Major > > From the discussion thread: > > Now that we have ES at a modern version, we should consider bringing Solr to > a modern version as well. > > The focus of this work would be to get us in a place where Solr is upgraded, > along with the related work of building out the Solr functionality to parity > with Elasticsearch. The goal would not be to add net new functionality, just > to get Solr and ES in the same place for the alerts UI and REST interface. > Additionally, it would include the various supporting necessities such as > ensuring associated DAOs are testable, and so on. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] metron pull request #1076: METRON-1416: Upgrade Solr
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/1076 ---
[jira] [Commented] (METRON-1416) Upgrade Solr
[ https://issues.apache.org/jira/browse/METRON-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524140#comment-16524140 ] ASF GitHub Bot commented on METRON-1416: Github user justinleet commented on the issue: https://github.com/apache/metron/pull/1076 I pulled master one more time. Once Travis goes through, I'll merge this into master, per the thread. > Upgrade Solr > > > Key: METRON-1416 > URL: https://issues.apache.org/jira/browse/METRON-1416 > Project: Metron > Issue Type: Bug >Reporter: Justin Leet >Priority: Major > > From the discussion thread: > > Now that we have ES at a modern version, we should consider bringing Solr to > a modern version as well. > > The focus of this work would be to get us in a place where Solr is upgraded, > along with the related work of building out the Solr functionality to parity > with Elasticsearch. The goal would not be to add net new functionality, just > to get Solr and ES in the same place for the alerts UI and REST interface. > Additionally, it would include the various supporting necessities such as > ensuring associated DAOs are testable, and so on. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (METRON-1639) Grok Parser does not handle missing year well in syslog rfc3164 timestamps
Simon Elliston Ball created METRON-1639: --- Summary: Grok Parser does not handle missing year well in syslog rfc3164 timestamps Key: METRON-1639 URL: https://issues.apache.org/jira/browse/METRON-1639 Project: Metron Issue Type: Improvement Affects Versions: 0.5.0 Reporter: Simon Elliston Ball Assignee: Simon Elliston Ball The grok parser does not handle timestamp fields in rfc3164 format well, since the format omits a year from the date, the year defaults to 1970. We should either switch this to default year to current, or create a "dateFormat" config option "syslog" which runs the SyslogUtils parser used in other parsers on the captured fields for the field specified in "timestampField" config. This capability should also reflect the timezone for the sensor, which is not currently applied to Grok parsing but is honoured in parsers like BasicASAParser. Note that it is not universally applied across all parsers, but probably should be. "Mmm dd hh:mm:ss" is the canonical date format in rfc3164, with options to include a timezone and year. We currently handle this and variants found in the wild in SyslogUtils::parseTimestampToEpochMillis, which also accounts for timezone based on a Clock parameter. This function assumes that any date more than 4 days in the future is in the past, which seems acceptable and consistent for our purposes and covers the possibility of year end discrepancies. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] metron issue #1076: METRON-1416: Upgrade Solr
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/1076 I pulled master one more time. Once Travis goes through, I'll merge this into master, per the thread. ---
[jira] [Created] (METRON-1638) Retrieve Pcap results in pdml format
Ryan Merriman created METRON-1638: - Summary: Retrieve Pcap results in pdml format Key: METRON-1638 URL: https://issues.apache.org/jira/browse/METRON-1638 Project: Metron Issue Type: Sub-task Reporter: Ryan Merriman There should be a REST endpoint that allows a user to retrieve pcap page results in pdml format. Assuming tshark is installed, there should be a "GET /api/v1/pcap/pdml//" endpoint that will return pcap results for the given page in pdml format ([https://wiki.wireshark.org/PDML]), converted to json for easier consumption by a UI. This endpoint will call out to the tskark utility for the raw to pdml conversion. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (METRON-1634) Alerts UI add comment doesn't immediately show up.
[ https://issues.apache.org/jira/browse/METRON-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523875#comment-16523875 ] ASF GitHub Bot commented on METRON-1634: Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/1077 > Alerts UI add comment doesn't immediately show up. > -- > > Key: METRON-1634 > URL: https://issues.apache.org/jira/browse/METRON-1634 > Project: Metron > Issue Type: Bug >Reporter: Ryan Merriman >Priority: Major > > For ES (and potentially Solr), when the Alerts UI adds a comment to an alert, > it calls the update, then immediately calls a findOne to retrieve it. This > comment might not immediately be available, so it doesn't show the new > comment. > Instead of running a findOne, assuming the update responds appropriately, we > should probably just add it directly in the UI. > Also applies to removing a comment -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] metron pull request #1077: METRON-1634: Alerts UI add comment doesn't immedi...
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/1077 ---
[jira] [Commented] (METRON-1489) Retrofit UI tests to run reliably during nightly QE runs
[ https://issues.apache.org/jira/browse/METRON-1489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523823#comment-16523823 ] ASF GitHub Bot commented on METRON-1489: Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/1004 > Retrofit UI tests to run reliably during nightly QE runs > > > Key: METRON-1489 > URL: https://issues.apache.org/jira/browse/METRON-1489 > Project: Metron > Issue Type: Improvement >Reporter: Daniel Toth >Assignee: Daniel Toth >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] metron pull request #1004: METRON-1489: Retrofit UI tests to run reliably
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/1004 ---
[jira] [Commented] (METRON-1489) Retrofit UI tests to run reliably during nightly QE runs
[ https://issues.apache.org/jira/browse/METRON-1489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523740#comment-16523740 ] ASF GitHub Bot commented on METRON-1489: Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/1004 +1 Thanks for all the hard work on this one. I know this was a battle to get it over the finish line. I will get this merged once the CI build completes. > Retrofit UI tests to run reliably during nightly QE runs > > > Key: METRON-1489 > URL: https://issues.apache.org/jira/browse/METRON-1489 > Project: Metron > Issue Type: Improvement >Reporter: Daniel Toth >Assignee: Daniel Toth >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (METRON-1635) Alerts UI status update doesn't immediately show up
[ https://issues.apache.org/jira/browse/METRON-1635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523739#comment-16523739 ] ASF GitHub Bot commented on METRON-1635: GitHub user merrimanr opened a pull request: https://github.com/apache/metron/pull/1080 METRON-1635: Alerts UI status update doesn't immediately show up ## Contributor Comments This PR changes the behavior of the Alerts UI by applying alert status updates optimistically. The approach is similar to the change in https://github.com/apache/metron/pull/1077. I also changed the process of renaming a metaalert to be optimistic as well since it follows the same pattern. I'm happy to split that off into a separate PR. ### Changes Included - Refactored the getData method by moving logic to update an alert to it's own method. - Removed the toggleAlertEditor parameter from the getData function. This should be called separately in my opinion. - Moved redundant code to a single updateAlertState function - Updated the alert update process to immediately apply the update to the UI and revert to the previous state when an update fails. - Updated the metaalert name update process to immediately apply the update to the UI and revert to the previous state when an update fails. ### Testing This has been tested in full dev. Navigate to the Alerts UI and open the details panel for an alert. Changing the status of an alert should be reflected in the UI immediately. To test the case of an error being returned from the back end, I stopped the REST application and then tried to change the alert status. You should see the alert status change for no more than a split second before reverting to the previous state. The name change fix can also be tested this way by creating a metaalert and changing the name. ## Pull Request Checklist Thank you for submitting a contribution to Apache Metron. Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions. Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides. In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). - [x] Does your PR title start with METRON- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? ### For code changes: - [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed? - [x] Have you included steps or a guide to how the change may be verified and tested manually? - [x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via: ``` mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh ``` - [x] Have you written or updated unit tests and or integration tests to verify your changes? - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`: ``` cd site-book mvn site ``` Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request. You can merge this pull request into a Git repository by running: $ git pull https://github.com/merrimanr/incubator-metron METRON-1635 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/metron/pull/1080.patch To close this pull request,
[GitHub] metron issue #1004: METRON-1489: Retrofit UI tests to run reliably
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/1004 +1 Thanks for all the hard work on this one. I know this was a battle to get it over the finish line. I will get this merged once the CI build completes. ---
[GitHub] metron pull request #1080: METRON-1635: Alerts UI status update doesn't imme...
GitHub user merrimanr opened a pull request: https://github.com/apache/metron/pull/1080 METRON-1635: Alerts UI status update doesn't immediately show up ## Contributor Comments This PR changes the behavior of the Alerts UI by applying alert status updates optimistically. The approach is similar to the change in https://github.com/apache/metron/pull/1077. I also changed the process of renaming a metaalert to be optimistic as well since it follows the same pattern. I'm happy to split that off into a separate PR. ### Changes Included - Refactored the getData method by moving logic to update an alert to it's own method. - Removed the toggleAlertEditor parameter from the getData function. This should be called separately in my opinion. - Moved redundant code to a single updateAlertState function - Updated the alert update process to immediately apply the update to the UI and revert to the previous state when an update fails. - Updated the metaalert name update process to immediately apply the update to the UI and revert to the previous state when an update fails. ### Testing This has been tested in full dev. Navigate to the Alerts UI and open the details panel for an alert. Changing the status of an alert should be reflected in the UI immediately. To test the case of an error being returned from the back end, I stopped the REST application and then tried to change the alert status. You should see the alert status change for no more than a split second before reverting to the previous state. The name change fix can also be tested this way by creating a metaalert and changing the name. ## Pull Request Checklist Thank you for submitting a contribution to Apache Metron. Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions. Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides. In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). - [x] Does your PR title start with METRON- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? ### For code changes: - [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed? - [x] Have you included steps or a guide to how the change may be verified and tested manually? - [x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via: ``` mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh ``` - [x] Have you written or updated unit tests and or integration tests to verify your changes? - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`: ``` cd site-book mvn site ``` Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request. You can merge this pull request into a Git repository by running: $ git pull https://github.com/merrimanr/incubator-metron METRON-1635 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/metron/pull/1080.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1080 commit 6204911ac6d99d9f2321267b8c947f2682b9f2d7 Author: merrimanr Date: 2018-06-22T20:25:32Z initial commit
[jira] [Commented] (METRON-1620) Fixes for forensic clustering use case example
[ https://issues.apache.org/jira/browse/METRON-1620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523722#comment-16523722 ] ASF GitHub Bot commented on METRON-1620: Github user justinleet commented on the issue: https://github.com/apache/metron/pull/1065 @mmiklavc I definitely agree that it's ideal if we can keep these up to date, but I suspect that even if we tie the functionality in, updates to the docs will slip here and there. I'm honestly not sure what the best solution to that is. Thanks for the update, +1. > Fixes for forensic clustering use case example > -- > > Key: METRON-1620 > URL: https://issues.apache.org/jira/browse/METRON-1620 > Project: Metron > Issue Type: Bug >Reporter: Michael Miklavcic >Assignee: Michael Miklavcic >Priority: Major > > ES mapping needed some adjustments. Change to dynamic template mapping so it > will work for non-existent indexes yet to be created. Make work with ES 5.6.x > data types. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] metron issue #1065: METRON-1620: Fixes for forensic clustering use case exam...
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/1065 @mmiklavc I definitely agree that it's ideal if we can keep these up to date, but I suspect that even if we tie the functionality in, updates to the docs will slip here and there. I'm honestly not sure what the best solution to that is. Thanks for the update, +1. ---
[jira] [Commented] (METRON-1634) Alerts UI add comment doesn't immediately show up.
[ https://issues.apache.org/jira/browse/METRON-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523706#comment-16523706 ] ASF GitHub Bot commented on METRON-1634: Github user tiborm commented on the issue: https://github.com/apache/metron/pull/1077 +1 nice improvement > Alerts UI add comment doesn't immediately show up. > -- > > Key: METRON-1634 > URL: https://issues.apache.org/jira/browse/METRON-1634 > Project: Metron > Issue Type: Bug >Reporter: Ryan Merriman >Priority: Major > > For ES (and potentially Solr), when the Alerts UI adds a comment to an alert, > it calls the update, then immediately calls a findOne to retrieve it. This > comment might not immediately be available, so it doesn't show the new > comment. > Instead of running a findOne, assuming the update responds appropriately, we > should probably just add it directly in the UI. > Also applies to removing a comment -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] metron issue #1077: METRON-1634: Alerts UI add comment doesn't immediately s...
Github user tiborm commented on the issue: https://github.com/apache/metron/pull/1077 +1 nice improvement ---
[jira] [Commented] (METRON-1637) Wrong path to escalate alert REST endpoint
[ https://issues.apache.org/jira/browse/METRON-1637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523696#comment-16523696 ] ASF GitHub Bot commented on METRON-1637: Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/1078 > Wrong path to escalate alert REST endpoint > -- > > Key: METRON-1637 > URL: https://issues.apache.org/jira/browse/METRON-1637 > Project: Metron > Issue Type: Bug >Reporter: Ryan Merriman >Priority: Major > > A regression was introduced when the path to the REST escalation endpoint was > changed. This needs to be updated to match the current path. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] metron pull request #1078: METRON-1637: Wrong path to escalate alert REST en...
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/1078 ---
[GitHub] metron issue #1078: METRON-1637: Wrong path to escalate alert REST endpoint
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/1078 +1 Good fix ---
[jira] [Commented] (METRON-1637) Wrong path to escalate alert REST endpoint
[ https://issues.apache.org/jira/browse/METRON-1637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523695#comment-16523695 ] ASF GitHub Bot commented on METRON-1637: Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/1078 +1 Good fix > Wrong path to escalate alert REST endpoint > -- > > Key: METRON-1637 > URL: https://issues.apache.org/jira/browse/METRON-1637 > Project: Metron > Issue Type: Bug >Reporter: Ryan Merriman >Priority: Major > > A regression was introduced when the path to the REST escalation endpoint was > changed. This needs to be updated to match the current path. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (METRON-1637) Wrong path to escalate alert REST endpoint
[ https://issues.apache.org/jira/browse/METRON-1637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523679#comment-16523679 ] ASF GitHub Bot commented on METRON-1637: Github user sardell commented on the issue: https://github.com/apache/metron/pull/1078 +1 tested on full-dev. > Wrong path to escalate alert REST endpoint > -- > > Key: METRON-1637 > URL: https://issues.apache.org/jira/browse/METRON-1637 > Project: Metron > Issue Type: Bug >Reporter: Ryan Merriman >Priority: Major > > A regression was introduced when the path to the REST escalation endpoint was > changed. This needs to be updated to match the current path. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] metron issue #1078: METRON-1637: Wrong path to escalate alert REST endpoint
Github user sardell commented on the issue: https://github.com/apache/metron/pull/1078 +1 tested on full-dev. ---
[jira] [Commented] (METRON-1631) Alerts UI: Dash score does not show if only filtering by one group
[ https://issues.apache.org/jira/browse/METRON-1631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523664#comment-16523664 ] ASF GitHub Bot commented on METRON-1631: GitHub user sardell opened a pull request: https://github.com/apache/metron/pull/1079 Fix dash score so that it always shows a value if a group-by is selected ## Contributor Comments [As described in this issue](https://issues.apache.org/jira/browse/METRON-1631), the dash score in the tree view wouldn't have a value if only one Group By button was selected. This was caused by logic in the tree view executing before the required data was returned by the global configuration service. For a quick and simple solution, I removed the service subscription and instead chose to pass the global configuration as an `@Input` since the parent component is already fetching that data with its own service subscription on app load. I also removed `getGroupRequest()` from the tree view selector 's `*ngIf` logic because the parent component already fetches that information too. While doing this work, I noticed that there are several repetitive subscriptions for data. In the future, we may want to switch to injecting these services in the app module or using a store solution like ngrx so they can be singletons. ## Pull Request Checklist Thank you for submitting a contribution to Apache Metron. Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions. Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides. In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). - [ ] Does your PR title start with METRON- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? ### For code changes: - [ ] Have you included steps to reproduce the behavior or problem that is being changed or addressed? - [ ] Have you included steps or a guide to how the change may be verified and tested manually? - [ ] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via: ``` mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh ``` - [ ] Have you written or updated unit tests and or integration tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`: ``` cd site-book mvn site ``` Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request. You can merge this pull request into a Git repository by running: $ git pull https://github.com/sardell/metron METRON-1631 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/metron/pull/1079.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1079 commit 7346a0f3f06376e2288d4109add95fb4ecca2356 Author: Shane Ardell Date: 2018-06-26T12:01:34Z pass globalConfig and remove unnecessary function call > Alerts UI: Dash score does not show if only filtering by one group > -- > > Key: METRON-1631 > URL: https://issues.apache.org/jira/browse/METRON-1631 >
[GitHub] metron pull request #1079: Fix dash score so that it always shows a value if...
GitHub user sardell opened a pull request: https://github.com/apache/metron/pull/1079 Fix dash score so that it always shows a value if a group-by is selected ## Contributor Comments [As described in this issue](https://issues.apache.org/jira/browse/METRON-1631), the dash score in the tree view wouldn't have a value if only one Group By button was selected. This was caused by logic in the tree view executing before the required data was returned by the global configuration service. For a quick and simple solution, I removed the service subscription and instead chose to pass the global configuration as an `@Input` since the parent component is already fetching that data with its own service subscription on app load. I also removed `getGroupRequest()` from the tree view selector 's `*ngIf` logic because the parent component already fetches that information too. While doing this work, I noticed that there are several repetitive subscriptions for data. In the future, we may want to switch to injecting these services in the app module or using a store solution like ngrx so they can be singletons. ## Pull Request Checklist Thank you for submitting a contribution to Apache Metron. Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions. Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides. In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). - [ ] Does your PR title start with METRON- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? ### For code changes: - [ ] Have you included steps to reproduce the behavior or problem that is being changed or addressed? - [ ] Have you included steps or a guide to how the change may be verified and tested manually? - [ ] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via: ``` mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh ``` - [ ] Have you written or updated unit tests and or integration tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`: ``` cd site-book mvn site ``` Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request. You can merge this pull request into a Git repository by running: $ git pull https://github.com/sardell/metron METRON-1631 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/metron/pull/1079.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1079 commit 7346a0f3f06376e2288d4109add95fb4ecca2356 Author: Shane Ardell Date: 2018-06-26T12:01:34Z pass globalConfig and remove unnecessary function call ---
[jira] [Commented] (METRON-1489) Retrofit UI tests to run reliably during nightly QE runs
[ https://issues.apache.org/jira/browse/METRON-1489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523497#comment-16523497 ] ASF GitHub Bot commented on METRON-1489: Github user sardell commented on the issue: https://github.com/apache/metron/pull/1004 @nickwallen I wasn't able to reproduce the failure you experienced, but I added a note to the README stating the parsers will sometimes cause failures for users. > Retrofit UI tests to run reliably during nightly QE runs > > > Key: METRON-1489 > URL: https://issues.apache.org/jira/browse/METRON-1489 > Project: Metron > Issue Type: Improvement >Reporter: Daniel Toth >Assignee: Daniel Toth >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] metron issue #1004: METRON-1489: Retrofit UI tests to run reliably
Github user sardell commented on the issue: https://github.com/apache/metron/pull/1004 @nickwallen I wasn't able to reproduce the failure you experienced, but I added a note to the README stating the parsers will sometimes cause failures for users. ---
