[GitHub] metron pull request #1118: METRON-1662: Adding download button
Github user tiborm commented on a diff in the pull request:
https://github.com/apache/metron/pull/1118#discussion_r207506822
--- Diff:
metron-interface/metron-alerts/src/app/pcap/pcap-panel/pcap-panel.component.ts
---
@@ -22,33 +22,35 @@ import { PcapRequest } from '../model/pcap.request'
import { Pdml } from '../model/pdml'
import {Subscription} from "rxjs/Rx";
+class Query {
--- End diff --
Thanks Ryan! It's dead code left there from some previous state of impl.
Removed.
---
[GitHub] metron pull request #1118: METRON-1662: Adding download button
Github user tiborm commented on a diff in the pull request:
https://github.com/apache/metron/pull/1118#discussion_r207506818
--- Diff:
metron-interface/metron-alerts/src/app/pcap/pcap-panel/pcap-panel.component.ts
---
@@ -22,33 +22,35 @@ import { PcapRequest } from '../model/pcap.request'
import { Pdml } from '../model/pdml'
import {Subscription} from "rxjs/Rx";
+class Query {
+ id: String
+}
+
@Component({
selector: 'app-pcap-panel',
templateUrl: './pcap-panel.component.html',
styleUrls: ['./pcap-panel.component.scss']
})
-export class PcapPanelComponent implements OnInit {
+export class PcapPanelComponent {
@Input() pdml: Pdml = null;
-
@Input() pcapRequest: PcapRequest;
statusSubscription: Subscription;
queryRunning: boolean = false;
+ queryId: string;
progressWidth: number = 0;
selectedPage: number = 1;
errorMsg: string;
- constructor(private pcapService: PcapService ) { }
-
- ngOnInit() {
- }
+ constructor(private pcapService: PcapService ) {}
onSearch(pcapRequest) {
console.log(pcapRequest);
this.pdml = null;
this.progressWidth = 0;
this.pcapService.submitRequest(pcapRequest).subscribe(id => {
+ this.queryId = id;
--- End diff --
Nice catch, thanks! Turned this into PcapStatusResponse.
---
[jira] [Commented] (METRON-1662) PCAP UI - Downloading PCAP page files
[
https://issues.apache.org/jira/browse/METRON-1662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16568081#comment-16568081
]
ASF GitHub Bot commented on METRON-1662:
Github user tiborm commented on a diff in the pull request:
https://github.com/apache/metron/pull/1118#discussion_r207506822
--- Diff:
metron-interface/metron-alerts/src/app/pcap/pcap-panel/pcap-panel.component.ts
---
@@ -22,33 +22,35 @@ import { PcapRequest } from '../model/pcap.request'
import { Pdml } from '../model/pdml'
import {Subscription} from "rxjs/Rx";
+class Query {
--- End diff --
Thanks Ryan! It's dead code left there from some previous state of impl.
Removed.
> PCAP UI - Downloading PCAP page files
> -
>
> Key: METRON-1662
> URL: https://issues.apache.org/jira/browse/METRON-1662
> Project: Metron
> Issue Type: Sub-task
>Reporter: Tibor Meller
>Priority: Major
>
> As a user, I like to be able to download the filtered PCAP query output in
> PCAP binary format.
> As a user, when I click the download button below the result grid, I like to
> get the result page selected by the paginator component.
>
> *Acceptance criteria*
> Given
> * the user is logged in
> * and navigated to the PCAP panel
> * submitted a PCAP query
> * the valid result appeared on the UI
> When
> * the user clicking the download button below the result grid
> Then
> * the selected page of the result should download in PCAP binary format
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (METRON-1662) PCAP UI - Downloading PCAP page files
[
https://issues.apache.org/jira/browse/METRON-1662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16568080#comment-16568080
]
ASF GitHub Bot commented on METRON-1662:
Github user tiborm commented on a diff in the pull request:
https://github.com/apache/metron/pull/1118#discussion_r207506818
--- Diff:
metron-interface/metron-alerts/src/app/pcap/pcap-panel/pcap-panel.component.ts
---
@@ -22,33 +22,35 @@ import { PcapRequest } from '../model/pcap.request'
import { Pdml } from '../model/pdml'
import {Subscription} from "rxjs/Rx";
+class Query {
+ id: String
+}
+
@Component({
selector: 'app-pcap-panel',
templateUrl: './pcap-panel.component.html',
styleUrls: ['./pcap-panel.component.scss']
})
-export class PcapPanelComponent implements OnInit {
+export class PcapPanelComponent {
@Input() pdml: Pdml = null;
-
@Input() pcapRequest: PcapRequest;
statusSubscription: Subscription;
queryRunning: boolean = false;
+ queryId: string;
progressWidth: number = 0;
selectedPage: number = 1;
errorMsg: string;
- constructor(private pcapService: PcapService ) { }
-
- ngOnInit() {
- }
+ constructor(private pcapService: PcapService ) {}
onSearch(pcapRequest) {
console.log(pcapRequest);
this.pdml = null;
this.progressWidth = 0;
this.pcapService.submitRequest(pcapRequest).subscribe(id => {
+ this.queryId = id;
--- End diff --
Nice catch, thanks! Turned this into PcapStatusResponse.
> PCAP UI - Downloading PCAP page files
> -
>
> Key: METRON-1662
> URL: https://issues.apache.org/jira/browse/METRON-1662
> Project: Metron
> Issue Type: Sub-task
>Reporter: Tibor Meller
>Priority: Major
>
> As a user, I like to be able to download the filtered PCAP query output in
> PCAP binary format.
> As a user, when I click the download button below the result grid, I like to
> get the result page selected by the paginator component.
>
> *Acceptance criteria*
> Given
> * the user is logged in
> * and navigated to the PCAP panel
> * submitted a PCAP query
> * the valid result appeared on the UI
> When
> * the user clicking the download button below the result grid
> Then
> * the selected page of the result should download in PCAP binary format
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] metron issue #1118: METRON-1662: Adding download button
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/1118 Thanks @tiborm looks good. +1 ---
[jira] [Commented] (METRON-1662) PCAP UI - Downloading PCAP page files
[ https://issues.apache.org/jira/browse/METRON-1662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16568184#comment-16568184 ] ASF GitHub Bot commented on METRON-1662: Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/1118 Thanks @tiborm looks good. +1 > PCAP UI - Downloading PCAP page files > - > > Key: METRON-1662 > URL: https://issues.apache.org/jira/browse/METRON-1662 > Project: Metron > Issue Type: Sub-task >Reporter: Tibor Meller >Priority: Major > > As a user, I like to be able to download the filtered PCAP query output in > PCAP binary format. > As a user, when I click the download button below the result grid, I like to > get the result page selected by the paginator component. > > *Acceptance criteria* > Given > * the user is logged in > * and navigated to the PCAP panel > * submitted a PCAP query > * the valid result appeared on the UI > When > * the user clicking the download button below the result grid > Then > * the selected page of the result should download in PCAP binary format -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (METRON-1700) Create REST endpoint to get job configuration
[ https://issues.apache.org/jira/browse/METRON-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16568201#comment-16568201 ] ASF GitHub Bot commented on METRON-1700: Github user merrimanr closed the pull request at: https://github.com/apache/metron/pull/1135 > Create REST endpoint to get job configuration > - > > Key: METRON-1700 > URL: https://issues.apache.org/jira/browse/METRON-1700 > Project: Metron > Issue Type: Sub-task >Reporter: Ryan Merriman >Priority: Major > > We need a REST endpoint that will allow us to retrieve the job configuration > properties. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] metron pull request #1135: METRON-1700: Create REST endpoint to get job conf...
Github user merrimanr closed the pull request at: https://github.com/apache/metron/pull/1135 ---
[GitHub] metron pull request #1118: METRON-1662: Adding download button
Github user tiborm closed the pull request at: https://github.com/apache/metron/pull/1118 ---
[GitHub] metron issue #1118: METRON-1662: Adding download button
Github user tiborm commented on the issue: https://github.com/apache/metron/pull/1118 Thanks Guys! ---
[jira] [Commented] (METRON-1662) PCAP UI - Downloading PCAP page files
[ https://issues.apache.org/jira/browse/METRON-1662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16568220#comment-16568220 ] ASF GitHub Bot commented on METRON-1662: Github user tiborm commented on the issue: https://github.com/apache/metron/pull/1118 Thanks Guys! > PCAP UI - Downloading PCAP page files > - > > Key: METRON-1662 > URL: https://issues.apache.org/jira/browse/METRON-1662 > Project: Metron > Issue Type: Sub-task >Reporter: Tibor Meller >Priority: Major > > As a user, I like to be able to download the filtered PCAP query output in > PCAP binary format. > As a user, when I click the download button below the result grid, I like to > get the result page selected by the paginator component. > > *Acceptance criteria* > Given > * the user is logged in > * and navigated to the PCAP panel > * submitted a PCAP query > * the valid result appeared on the UI > When > * the user clicking the download button below the result grid > Then > * the selected page of the result should download in PCAP binary format -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (METRON-1662) PCAP UI - Downloading PCAP page files
[ https://issues.apache.org/jira/browse/METRON-1662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16568221#comment-16568221 ] ASF GitHub Bot commented on METRON-1662: Github user tiborm closed the pull request at: https://github.com/apache/metron/pull/1118 > PCAP UI - Downloading PCAP page files > - > > Key: METRON-1662 > URL: https://issues.apache.org/jira/browse/METRON-1662 > Project: Metron > Issue Type: Sub-task >Reporter: Tibor Meller >Priority: Major > > As a user, I like to be able to download the filtered PCAP query output in > PCAP binary format. > As a user, when I click the download button below the result grid, I like to > get the result page selected by the paginator component. > > *Acceptance criteria* > Given > * the user is logged in > * and navigated to the PCAP panel > * submitted a PCAP query > * the valid result appeared on the UI > When > * the user clicking the download button below the result grid > Then > * the selected page of the result should download in PCAP binary format -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] metron pull request #1119: METRON-1676: Adding date range selector to PCAP f...
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/1119#discussion_r207554704 --- Diff: metron-interface/metron-alerts/src/app/pcap/pcap.routing.ts --- @@ -1,4 +1,4 @@ -/** +/* --- End diff -- Was this intentional? ---
[jira] [Commented] (METRON-1676) PCAP UI - Add data range selector to the filter bar
[ https://issues.apache.org/jira/browse/METRON-1676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16568236#comment-16568236 ] ASF GitHub Bot commented on METRON-1676: Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/1119#discussion_r207554704 --- Diff: metron-interface/metron-alerts/src/app/pcap/pcap.routing.ts --- @@ -1,4 +1,4 @@ -/** +/* --- End diff -- Was this intentional? > PCAP UI - Add data range selector to the filter bar > --- > > Key: METRON-1676 > URL: https://issues.apache.org/jira/browse/METRON-1676 > Project: Metron > Issue Type: Sub-task >Reporter: Tibor Meller >Priority: Major > > As a user, I like to set a date range for my PCAP query request. > * Strat time (From) and end time (To) selectors should appear as the first > two elements of the filter bar > * Time selectors should have default values (end time: now, start time: now > - 5 days) > * Due to these fields are mandatory, the user should not be able to set time > selectors to an invalid state (eg. missing value, null value or any value > other than time) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (METRON-1720) Better error messages when there are no results or wireshark is not installed
Ryan Merriman created METRON-1720: - Summary: Better error messages when there are no results or wireshark is not installed Key: METRON-1720 URL: https://issues.apache.org/jira/browse/METRON-1720 Project: Metron Issue Type: Sub-task Reporter: Ryan Merriman We should report why pcap data cannot be retrieved in pdml format after a query has run. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (METRON-1721) New default input path is wrong in pcap CLI
Ryan Merriman created METRON-1721: - Summary: New default input path is wrong in pcap CLI Key: METRON-1721 URL: https://issues.apache.org/jira/browse/METRON-1721 Project: Metron Issue Type: Sub-task Reporter: Ryan Merriman We needed a separate HDFS directory to store pcap files so the default was changed from /apps/metron/pcap to /apps/metron/pcap/input. The CLI should be updated to reflect this change. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] metron pull request #1137: METRON-1721: New default input path is wrong in p...
GitHub user merrimanr opened a pull request: https://github.com/apache/metron/pull/1137 METRON-1721: New default input path is wrong in pcap CLI ## Contributor Comments This PR includes a simple 1 line change that updates the default pcap input path in the CLI. The CLI should work as expected after generating pcap data with the pcap topology. Override the input path should not be required. ## Pull Request Checklist Thank you for submitting a contribution to Apache Metron. Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions. Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides. In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). - [x] Does your PR title start with METRON- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? ### For code changes: - [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed? - [x] Have you included steps or a guide to how the change may be verified and tested manually? - [x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via: ``` mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh ``` - [x] Have you written or updated unit tests and or integration tests to verify your changes? - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`: ``` cd site-book mvn site ``` Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request. You can merge this pull request into a Git repository by running: $ git pull https://github.com/merrimanr/incubator-metron METRON-1721 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/metron/pull/1137.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1137 commit f94f7311b70bf013dfd1a6568ae9c69ff19a8966 Author: merrimanr Date: 2018-08-03T21:37:46Z initial commit ---
[jira] [Commented] (METRON-1721) New default input path is wrong in pcap CLI
[ https://issues.apache.org/jira/browse/METRON-1721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16568823#comment-16568823 ] ASF GitHub Bot commented on METRON-1721: GitHub user merrimanr opened a pull request: https://github.com/apache/metron/pull/1137 METRON-1721: New default input path is wrong in pcap CLI ## Contributor Comments This PR includes a simple 1 line change that updates the default pcap input path in the CLI. The CLI should work as expected after generating pcap data with the pcap topology. Override the input path should not be required. ## Pull Request Checklist Thank you for submitting a contribution to Apache Metron. Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions. Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides. In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). - [x] Does your PR title start with METRON- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? ### For code changes: - [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed? - [x] Have you included steps or a guide to how the change may be verified and tested manually? - [x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via: ``` mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh ``` - [x] Have you written or updated unit tests and or integration tests to verify your changes? - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`: ``` cd site-book mvn site ``` Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request. You can merge this pull request into a Git repository by running: $ git pull https://github.com/merrimanr/incubator-metron METRON-1721 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/metron/pull/1137.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1137 commit f94f7311b70bf013dfd1a6568ae9c69ff19a8966 Author: merrimanr Date: 2018-08-03T21:37:46Z initial commit > New default input path is wrong in pcap CLI > --- > > Key: METRON-1721 > URL: https://issues.apache.org/jira/browse/METRON-1721 > Project: Metron > Issue Type: Sub-task >Reporter: Ryan Merriman >Priority: Major > > We needed a separate HDFS directory to store pcap files so the default was > changed from /apps/metron/pcap to /apps/metron/pcap/input. The CLI should be > updated to reflect this change. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (METRON-1722) PcapCLI should print progress to stdout
Ryan Merriman created METRON-1722: - Summary: PcapCLI should print progress to stdout Key: METRON-1722 URL: https://issues.apache.org/jira/browse/METRON-1722 Project: Metron Issue Type: Sub-task Reporter: Ryan Merriman It would be helpful if the Pcap CLI reported job status included state and percent complete. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] metron pull request #1138: METRON-1722: PcapCLI should print progress to std...
GitHub user merrimanr opened a pull request: https://github.com/apache/metron/pull/1138 METRON-1722: PcapCLI should print progress to stdout ## Contributor Comments This PR updates the Pcap CLI to print the status of a running job. I took a fairly simple approach as a first pass: - Added a `PrintStream` member variable to PcapJob - Added a `reportStatus` method that configures that variable - Added logic to the `PcapJob.get` method to print status if the printStream variable is set This approach keeps us from having to change the Statusable interface. For those reviewing, what do you think of the message? Should we format it differently or include more information? I am also considering adding a unit test for `PcapJob.get` in this PR since it doesn't exist and the changes in this PR affect that method. Let me know what you think. There are several different ways to solve this. ## Pull Request Checklist Thank you for submitting a contribution to Apache Metron. Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions. Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides. In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). - [ ] Does your PR title start with METRON- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? ### For code changes: - [ ] Have you included steps to reproduce the behavior or problem that is being changed or addressed? - [ ] Have you included steps or a guide to how the change may be verified and tested manually? - [ ] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via: ``` mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh ``` - [ ] Have you written or updated unit tests and or integration tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`: ``` cd site-book mvn site ``` Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request. You can merge this pull request into a Git repository by running: $ git pull https://github.com/merrimanr/incubator-metron METRON-1722 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/metron/pull/1138.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1138 commit 4bc0438d2c59df4753a266764ffed27975c28717 Author: merrimanr Date: 2018-08-03T21:44:04Z initial commit ---
[jira] [Commented] (METRON-1722) PcapCLI should print progress to stdout
[ https://issues.apache.org/jira/browse/METRON-1722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16568835#comment-16568835 ] ASF GitHub Bot commented on METRON-1722: GitHub user merrimanr opened a pull request: https://github.com/apache/metron/pull/1138 METRON-1722: PcapCLI should print progress to stdout ## Contributor Comments This PR updates the Pcap CLI to print the status of a running job. I took a fairly simple approach as a first pass: - Added a `PrintStream` member variable to PcapJob - Added a `reportStatus` method that configures that variable - Added logic to the `PcapJob.get` method to print status if the printStream variable is set This approach keeps us from having to change the Statusable interface. For those reviewing, what do you think of the message? Should we format it differently or include more information? I am also considering adding a unit test for `PcapJob.get` in this PR since it doesn't exist and the changes in this PR affect that method. Let me know what you think. There are several different ways to solve this. ## Pull Request Checklist Thank you for submitting a contribution to Apache Metron. Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions. Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides. In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). - [ ] Does your PR title start with METRON- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? ### For code changes: - [ ] Have you included steps to reproduce the behavior or problem that is being changed or addressed? - [ ] Have you included steps or a guide to how the change may be verified and tested manually? - [ ] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via: ``` mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh ``` - [ ] Have you written or updated unit tests and or integration tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`: ``` cd site-book mvn site ``` Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request. You can merge this pull request into a Git repository by running: $ git pull https://github.com/merrimanr/incubator-metron METRON-1722 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/metron/pull/1138.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1138 commit 4bc0438d2c59df4753a266764ffed27975c28717 Author: merrimanr Date: 2018-08-03T21:44:04Z initial commit > PcapCLI should print progress to stdout > --- > > Key: METRON-1722 > URL: https://issues.apache.org/jira/browse/METRON-1722 > Project: Metron > Issue Type: Sub-task >Reporter: Ryan Merriman >Priority: Major > > It would be helpful if the Pcap CLI reported job status included state and > percent complete. -- This message was sent by Atlassian JIRA
[GitHub] metron issue #1137: METRON-1721: New default input path is wrong in pcap CLI
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/1137 lgtm, +1 via inspection ---
[jira] [Commented] (METRON-1721) New default input path is wrong in pcap CLI
[ https://issues.apache.org/jira/browse/METRON-1721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16568856#comment-16568856 ] ASF GitHub Bot commented on METRON-1721: Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/1137 lgtm, +1 via inspection > New default input path is wrong in pcap CLI > --- > > Key: METRON-1721 > URL: https://issues.apache.org/jira/browse/METRON-1721 > Project: Metron > Issue Type: Sub-task >Reporter: Ryan Merriman >Priority: Major > > We needed a separate HDFS directory to store pcap files so the default was > changed from /apps/metron/pcap to /apps/metron/pcap/input. The CLI should be > updated to reflect this change. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
