[jira] [Assigned] (METRON-2161) [UI] CSS positioning bugs in Alerts and MGMT UI
[ https://issues.apache.org/jira/browse/METRON-2161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shane Ardell reassigned METRON-2161: Assignee: Shane Ardell > [UI] CSS positioning bugs in Alerts and MGMT UI > --- > > Key: METRON-2161 > URL: https://issues.apache.org/jira/browse/METRON-2161 > Project: Metron > Issue Type: Bug >Reporter: Shane Ardell >Assignee: Shane Ardell >Priority: Major > Attachments: long-message-bug.png, saved-searches-bug.gif, > search-arrow-bug.png > > Time Spent: 10m > Remaining Estimate: 0h > > * Position of the arrow in the Alerts UI search bar seem misaligned and too > close to text. > * Long message notifications will overlap the close button in both Alerts > and Management UI. > * Saved searches panel is opening awkwardly on the right (should open from > the left). > See attached images and gif for details. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [metron] sardell opened a new pull request #1446: METRON-2161: CSS positioning bugs in Alerts and MGMT UI
sardell opened a new pull request #1446: METRON-2161: CSS positioning bugs in Alerts and MGMT UI URL: https://github.com/apache/metron/pull/1446 ## Contributor Comments Link to ASF Jira ticket: https://issues.apache.org/jira/browse/METRON-2161 This PR fixes a handful of CSS bugs found in the Alerts and Management UI. I've included sceenshots/gifs below to show the issues and fixes. * Position of the arrow in the Alerts UI time range selector button seem misaligned and too close to text. **Bug:**  **Fix in this PR:**  * Long message notifications will overlap the close button in both Alerts and Management UI. **Bug:**  **Fix in this PR:**  * Saved searches panel is opening awkwardly on the right (should open from the left). **Bug:**  **Fix in this PR:**  ## Testing All these changes can be tested manually with full dev. Please refer to the screenshots/gifs above for clarification on how it should look and behave. **Misaligned arrow in the datepicker:** This can be seen by simply opening the Alerts UI and visually checking the button. **Saved searches panel opens from wrong side:** Open the Alerts UI and click on the Saved Searches button. The panel should open from the left instead of the right. **Long message notification:** This is a little trickier because message notifications only last for 5 seconds, and you will need to edit the message to simulate a long message. First, start the UI from `metron-interface/metron-config` by running `npm ci` and `scripts/start-dev.sh` (this must be done so the UI can compile with the changes you're about to make in the next step). Open the alert file in metron-interface/metron-config/src/app/shared/metron-alerts.ts and update the SUCESS_MESSAGE_DISPALY_TIME const to something large (like 10). Stop or start a parser. When the success message pops up, inspect the element and edit the content of the message in the browsers inspector. There should now be plenty of padding between the 'x' close button and the message. The message should also have margin on both the left and right side of it. ## Pull Request Checklist Thank you for submitting a contribution to Apache Metron. Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions. Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides. In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). - [ ] Does your PR title start with METRON- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? ### For code changes: - [ ] Have you included steps to reproduce the behavior or problem that is being changed or addressed? - [ ] Have you included steps or a guide to how the change may be verified and tested manually? - [ ] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via: ``` mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh ``` - [ ] Have you written or updated unit tests and or integration tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent? ### For documentation
[jira] [Updated] (METRON-2161) [UI] CSS positioning bugs in Alerts and MGMT UI
[ https://issues.apache.org/jira/browse/METRON-2161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shane Ardell updated METRON-2161: - Description: * Position of the arrow in the Alerts UI search bar seem misaligned and too close to text. * Long message notifications will overlap the close button in both Alerts and Management UI. * Saved searches panel is opening awkwardly on the right (should open from the left). See attached images and gif for details. was: * Position of the arrow in the Alerts UI search bar seem misaligned and too close to text. * Long message notifications will overlap the close button in both Alerts and Management UI. * Saved searches panel is opening awkwardly on the right (should open from the left). > [UI] CSS positioning bugs in Alerts and MGMT UI > --- > > Key: METRON-2161 > URL: https://issues.apache.org/jira/browse/METRON-2161 > Project: Metron > Issue Type: Bug >Reporter: Shane Ardell >Priority: Major > Attachments: long-message-bug.png, saved-searches-bug.gif, > search-arrow-bug.png > > > * Position of the arrow in the Alerts UI search bar seem misaligned and too > close to text. > * Long message notifications will overlap the close button in both Alerts > and Management UI. > * Saved searches panel is opening awkwardly on the right (should open from > the left). > See attached images and gif for details. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (METRON-2161) [UI] CSS positioning bugs in Alerts and MGMT UI
[ https://issues.apache.org/jira/browse/METRON-2161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shane Ardell updated METRON-2161: - Description: * Position of the arrow in the Alerts UI search bar seem misaligned and too close to text. * Long message notifications will overlap the close button in both Alerts and Management UI. * Saved searches panel is opening awkwardly on the right (should open from the left). was: * Position of the arrow in the Alerts UI search bar seem misaligned and too close to text. * Long message notifications will overlap the close button in both Alerts and Management UI. * Saved searches panel is opening awkwardly on the right (should open from the left). > [UI] CSS positioning bugs in Alerts and MGMT UI > --- > > Key: METRON-2161 > URL: https://issues.apache.org/jira/browse/METRON-2161 > Project: Metron > Issue Type: Bug >Reporter: Shane Ardell >Priority: Major > Attachments: long-message-bug.png, saved-searches-bug.gif, > search-arrow-bug.png > > > * Position of the arrow in the Alerts UI search bar seem misaligned and too > close to text. > * Long message notifications will overlap the close button in both Alerts > and Management UI. > * Saved searches panel is opening awkwardly on the right (should open from > the left). > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (METRON-2161) [UI] CSS positioning bugs in Alerts and MGMT UI
[ https://issues.apache.org/jira/browse/METRON-2161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shane Ardell updated METRON-2161: - Attachment: search-arrow-bug.png > [UI] CSS positioning bugs in Alerts and MGMT UI > --- > > Key: METRON-2161 > URL: https://issues.apache.org/jira/browse/METRON-2161 > Project: Metron > Issue Type: Bug >Reporter: Shane Ardell >Priority: Major > Attachments: long-message-bug.png, saved-searches-bug.gif, > search-arrow-bug.png > > > * Position of the arrow in the Alerts UI search bar seem misaligned and too > close to text. > * Long message notifications will overlap the close button in both Alerts > and Management UI. > * Saved searches panel is opening awkwardly on the right (should open from > the left). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (METRON-2161) [UI] CSS positioning bugs in Alerts and MGMT UI
[ https://issues.apache.org/jira/browse/METRON-2161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shane Ardell updated METRON-2161: - Attachment: saved-searches-bug.gif > [UI] CSS positioning bugs in Alerts and MGMT UI > --- > > Key: METRON-2161 > URL: https://issues.apache.org/jira/browse/METRON-2161 > Project: Metron > Issue Type: Bug >Reporter: Shane Ardell >Priority: Major > Attachments: long-message-bug.png, saved-searches-bug.gif, > search-arrow-bug.png > > > * Position of the arrow in the Alerts UI search bar seem misaligned and too > close to text. > * Long message notifications will overlap the close button in both Alerts > and Management UI. > * Saved searches panel is opening awkwardly on the right (should open from > the left). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (METRON-2161) [UI] CSS positioning bugs in Alerts and MGMT UI
[ https://issues.apache.org/jira/browse/METRON-2161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shane Ardell updated METRON-2161: - Attachment: long-message-bug.png > [UI] CSS positioning bugs in Alerts and MGMT UI > --- > > Key: METRON-2161 > URL: https://issues.apache.org/jira/browse/METRON-2161 > Project: Metron > Issue Type: Bug >Reporter: Shane Ardell >Priority: Major > Attachments: long-message-bug.png, saved-searches-bug.gif, > search-arrow-bug.png > > > * Position of the arrow in the Alerts UI search bar seem misaligned and too > close to text. > * Long message notifications will overlap the close button in both Alerts > and Management UI. > * Saved searches panel is opening awkwardly on the right (should open from > the left). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (METRON-2161) [UI] CSS positioning bugs in Alerts and MGMT UI
[ https://issues.apache.org/jira/browse/METRON-2161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shane Ardell updated METRON-2161: - Attachment: long-message-bug.png > [UI] CSS positioning bugs in Alerts and MGMT UI > --- > > Key: METRON-2161 > URL: https://issues.apache.org/jira/browse/METRON-2161 > Project: Metron > Issue Type: Bug >Reporter: Shane Ardell >Priority: Major > > * Position of the arrow in the Alerts UI search bar seem misaligned and too > close to text. > * Long message notifications will overlap the close button in both Alerts > and Management UI. > * Saved searches panel is opening awkwardly on the right (should open from > the left). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (METRON-2161) [UI] CSS positioning bugs in Alerts and MGMT UI
[ https://issues.apache.org/jira/browse/METRON-2161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shane Ardell updated METRON-2161: - Attachment: (was: saved-searches-bug.gif) > [UI] CSS positioning bugs in Alerts and MGMT UI > --- > > Key: METRON-2161 > URL: https://issues.apache.org/jira/browse/METRON-2161 > Project: Metron > Issue Type: Bug >Reporter: Shane Ardell >Priority: Major > > * Position of the arrow in the Alerts UI search bar seem misaligned and too > close to text. > * Long message notifications will overlap the close button in both Alerts > and Management UI. > * Saved searches panel is opening awkwardly on the right (should open from > the left). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (METRON-2161) [UI] CSS positioning bugs in Alerts and MGMT UI
[ https://issues.apache.org/jira/browse/METRON-2161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shane Ardell updated METRON-2161: - Attachment: (was: search-arrow-original.png) > [UI] CSS positioning bugs in Alerts and MGMT UI > --- > > Key: METRON-2161 > URL: https://issues.apache.org/jira/browse/METRON-2161 > Project: Metron > Issue Type: Bug >Reporter: Shane Ardell >Priority: Major > > * Position of the arrow in the Alerts UI search bar seem misaligned and too > close to text. > * Long message notifications will overlap the close button in both Alerts > and Management UI. > * Saved searches panel is opening awkwardly on the right (should open from > the left). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (METRON-2161) [UI] CSS positioning bugs in Alerts and MGMT UI
[ https://issues.apache.org/jira/browse/METRON-2161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shane Ardell updated METRON-2161: - Attachment: search-arrow-original.png > [UI] CSS positioning bugs in Alerts and MGMT UI > --- > > Key: METRON-2161 > URL: https://issues.apache.org/jira/browse/METRON-2161 > Project: Metron > Issue Type: Bug >Reporter: Shane Ardell >Priority: Major > > * Position of the arrow in the Alerts UI search bar seem misaligned and too > close to text. > * Long message notifications will overlap the close button in both Alerts > and Management UI. > * Saved searches panel is opening awkwardly on the right (should open from > the left). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (METRON-2161) [UI] CSS positioning bugs in Alerts and MGMT UI
[ https://issues.apache.org/jira/browse/METRON-2161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shane Ardell updated METRON-2161: - Attachment: saved-searches-bug.gif > [UI] CSS positioning bugs in Alerts and MGMT UI > --- > > Key: METRON-2161 > URL: https://issues.apache.org/jira/browse/METRON-2161 > Project: Metron > Issue Type: Bug >Reporter: Shane Ardell >Priority: Major > > * Position of the arrow in the Alerts UI search bar seem misaligned and too > close to text. > * Long message notifications will overlap the close button in both Alerts > and Management UI. > * Saved searches panel is opening awkwardly on the right (should open from > the left). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (METRON-2161) [UI] CSS positioning bugs in Alerts and MGMT UI
[ https://issues.apache.org/jira/browse/METRON-2161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shane Ardell updated METRON-2161: - Attachment: (was: long-message-bug.png) > [UI] CSS positioning bugs in Alerts and MGMT UI > --- > > Key: METRON-2161 > URL: https://issues.apache.org/jira/browse/METRON-2161 > Project: Metron > Issue Type: Bug >Reporter: Shane Ardell >Priority: Major > > * Position of the arrow in the Alerts UI search bar seem misaligned and too > close to text. > * Long message notifications will overlap the close button in both Alerts > and Management UI. > * Saved searches panel is opening awkwardly on the right (should open from > the left). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (METRON-2161) [UI] CSS positioning bugs in Alerts and MGMT UI
[ https://issues.apache.org/jira/browse/METRON-2161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shane Ardell updated METRON-2161: - Summary: [UI] CSS positioning bugs in Alerts and MGMT UI (was: [UI]CSS positioning bugs in Alerts and MGMT UI) > [UI] CSS positioning bugs in Alerts and MGMT UI > --- > > Key: METRON-2161 > URL: https://issues.apache.org/jira/browse/METRON-2161 > Project: Metron > Issue Type: Bug >Reporter: Shane Ardell >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (METRON-2161) [UI]CSS positioning bugs in Alerts and MGMT UI
[ https://issues.apache.org/jira/browse/METRON-2161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shane Ardell updated METRON-2161: - Summary: [UI]CSS positioning bugs in Alerts and MGMT UI (was: Fix a few CSS positioning bugs) > [UI]CSS positioning bugs in Alerts and MGMT UI > -- > > Key: METRON-2161 > URL: https://issues.apache.org/jira/browse/METRON-2161 > Project: Metron > Issue Type: Bug >Reporter: Shane Ardell >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (METRON-2161) [UI] CSS positioning bugs in Alerts and MGMT UI
[ https://issues.apache.org/jira/browse/METRON-2161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shane Ardell updated METRON-2161: - Description: * Position of the arrow in the Alerts UI search bar seem misaligned and too close to text. * Long message notifications will overlap the close button in both Alerts and Management UI. * Saved searches panel is opening awkwardly on the right (should open from the left). > [UI] CSS positioning bugs in Alerts and MGMT UI > --- > > Key: METRON-2161 > URL: https://issues.apache.org/jira/browse/METRON-2161 > Project: Metron > Issue Type: Bug >Reporter: Shane Ardell >Priority: Major > > * Position of the arrow in the Alerts UI search bar seem misaligned and too > close to text. > * Long message notifications will overlap the close button in both Alerts > and Management UI. > * Saved searches panel is opening awkwardly on the right (should open from > the left). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (METRON-2161) Fix a few CSS positioning bugs
Shane Ardell created METRON-2161: Summary: Fix a few CSS positioning bugs Key: METRON-2161 URL: https://issues.apache.org/jira/browse/METRON-2161 Project: Metron Issue Type: Bug Reporter: Shane Ardell -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [metron] ottobackwards commented on issue #1445: METRON-2155 Cache Maven in Travis CI Builds
ottobackwards commented on issue #1445: METRON-2155 Cache Maven in Travis CI Builds URL: https://github.com/apache/metron/pull/1445#issuecomment-505018050 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [metron] nickwallen commented on issue #1445: METRON-2155 Cache Maven in Travis CI Builds
nickwallen commented on issue #1445: METRON-2155 Cache Maven in Travis CI Builds URL: https://github.com/apache/metron/pull/1445#issuecomment-505009605 I added back the retry logic from #1433. I have retried the build a few times and have yet to see a failure. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
