[GitHub] [metron] mmiklavc commented on issue #1499: METRON-2241 Profiler Integration Test Fails After Storm 1.2.1 Upgrade
mmiklavc commented on issue #1499: METRON-2241 Profiler Integration Test Fails After Storm 1.2.1 Upgrade URL: https://github.com/apache/metron/pull/1499#issuecomment-526693199 @nickwallen I think that is reasonable here, specifically because I don't think your change is going to have ripple effects on the classpath. I did a quick comparison of the transitive dependencies and they don't seem to have changed. This is generally the type of exercise I'd use when deciding how far to go with a test plan. 1.2.2  1.2.3  +1 by inspection This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [metron] nickwallen commented on issue #1499: METRON-2241 Profiler Integration Test Fails After Storm 1.2.1 Upgrade
nickwallen commented on issue #1499: METRON-2241 Profiler Integration Test Fails After Storm 1.2.1 Upgrade URL: https://github.com/apache/metron/pull/1499#issuecomment-526678480 I just did the basic 'vagrant up'. I added that to the description. Let me know if you think we should do more. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [metron] nickwallen commented on issue #1499: METRON-2241 Profiler Integration Test Fails After Storm 1.2.1 Upgrade
nickwallen commented on issue #1499: METRON-2241 Profiler Integration Test Fails After Storm 1.2.1 Upgrade URL: https://github.com/apache/metron/pull/1499#issuecomment-526675769 What do you suggest? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [metron] mmiklavc commented on issue #1499: METRON-2241 Profiler Integration Test Fails After Storm 1.2.1 Upgrade
mmiklavc commented on issue #1499: METRON-2241 Profiler Integration Test Fails After Storm 1.2.1 Upgrade URL: https://github.com/apache/metron/pull/1499#issuecomment-526670030 Considering the high exposure to classpath issues we have, what's the test plan for this beyond the basic Travis build? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [metron] mmiklavc commented on issue #1483: METRON-2217 Migrate current HBase client from HTableInterface to Table
mmiklavc commented on issue #1483: METRON-2217 Migrate current HBase client from HTableInterface to Table URL: https://github.com/apache/metron/pull/1483#issuecomment-526668757 @MohanDV that makes sense then - this would be an expected exception in that case. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [metron] MohanDV commented on issue #1483: METRON-2217 Migrate current HBase client from HTableInterface to Table
MohanDV commented on issue #1483: METRON-2217 Migrate current HBase client from HTableInterface to Table URL: https://github.com/apache/metron/pull/1483#issuecomment-526644929 @mmiklavc Yes I have an entry `1567166198.507 0 ::1 TAG_NONE/400 3983 GET ;i=1;doned42.7630722pwdd-88.2142563 - HIER_NONE/- text/html ` in the squid access log for `squidclient "https://www.google.com/maps/place/Waterford,+WI/@42.7639877,-88.2867248,12z/data=!4m5!3m4!1s0x88059e67de9a3861:0x2d24f51aad34c80b!8m2!3d42.7630722!4d-88.2142563; ` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [metron] asfgit closed pull request #1477: METRON-2199: [UI] Add ability to turn off query building in Alerts UI search input
asfgit closed pull request #1477: METRON-2199: [UI] Add ability to turn off query building in Alerts UI search input URL: https://github.com/apache/metron/pull/1477 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [metron] mmiklavc commented on issue #1483: METRON-2217 Migrate current HBase client from HTableInterface to Table
mmiklavc commented on issue #1483: METRON-2217 Migrate current HBase client from HTableInterface to Table URL: https://github.com/apache/metron/pull/1483#issuecomment-526643205 @MohanDV thanks for the review! The enrichment I constructed wasn't robust in the sense that if an ip_dst_addr is missing, it would be expected to blow up like this. The data samples I provided for squid should all have had an ip_dst_addr. This looks like one of the records may be null for some reason or another. Can you share the sample squid access log? I suspect there's a record in there that doesn't look right. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [metron] MohanDV commented on issue #1483: METRON-2217 Migrate current HBase client from HTableInterface to Table
MohanDV commented on issue #1483: METRON-2217 Migrate current HBase client from HTableInterface to Table URL: https://github.com/apache/metron/pull/1483#issuecomment-526633319 @mmiklavc I have completed tests on a 5 node cluster, for the profiler tests I see below exceptions in the worker log of enrichment `java.lang.IllegalStateException: ENRICHMENT error with stellar failed: Unable to parse: PROFILE_GET( 'hello-world', ip_dst_addr, PROFILE_FIXED(2, 'MINUTES')) due to: null with relevant variables ip_dst_addr=missing at org.apache.metron.enrichment.parallel.ParallelEnricher.lambda$apply$0(ParallelEnricher.java:195) ~[stormjar.jar:?] at java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1590) ~[?:1.8.0_112] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) ~[?:1.8.0_112] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) ~[?:1.8.0_112]` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [metron] sardell opened a new pull request #1500: METRON-2243: [UI] Update npm dependencies to resolve audit warnings
sardell opened a new pull request #1500: METRON-2243: [UI] Update npm
dependencies to resolve audit warnings
URL: https://github.com/apache/metron/pull/1500
## Contributor Comments
Link to ASF Jira ticket: https://issues.apache.org/jira/browse/METRON-2243
This PR updates a few direct dependencies and multiple nested dependencies
in the Alerts and Management UIs due to vulnerabilities listed when running an
`npm audit` report. I updated the dependencies using `npm audit fix`, which
only updates to patch or minor versions of packages. In theory, this ensures we
do not introduce breaking changes into the project.
After using the command mentioned above, there is a single low severity
vulnerability in a nested dependency for our unit test runner, Karma. You can
read more about the vulnerability here: https://www.npmjs.com/advisories/786.
Because of the low-risk nature of the issue, I chose not to bump this
dependency to its next major version and risk the chance of introducing a
breaking change. Whenever we update to Angular 8, this issue will be resolved
(that version of Angular uses the next major version release of Karma).
## Testing
Clone this branch and run `npm audit` in either of the UI application
directories. The audit report should only show the low-level vulnerability
mentioned above.
Since this PR doesn't update anything but minor and patch releases of
dependencies, there should be no changes in the appearance or behavior of
either the Alerts or Management UI. Unit and e2e tests pass as expect, and a
manual visual regression test will show no changes have been introduced into
either UIs.
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
for the complete guide to follow for contributions.
Please refer also to our [Build Verification
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow
these guidelines and ask you to double check the following:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? If not one needs to be
created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [ ] Does your PR title start with METRON- where is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
### For code changes:
- [ ] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [ ] Have you included steps or a guide to how the change may be verified
and tested manually?
- [ ] Have you ensured that the full suite of tests and checks have been
executed in the root metron folder via:
```
mvn -q clean integration-test install &&
dev-utilities/build-utils/verify_licenses.sh
```
- [ ] Have you written or updated unit tests and or integration tests to
verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] Have you verified the basic functionality of the build by building and
running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered by building and verifying the site-book? If not then run the
following commands and the verify changes via
`site-book/target/site/index.html`:
```
cd site-book
mvn site
```
- [ ] Have you ensured that any documentation diagrams have been updated,
along with their source files, using [draw.io](https://www.draw.io/)? See
[Metron Development
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Development+Guidelines)
for instructions.
Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up for
your personal repository such that your branches are built there before
submitting a pull request.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[jira] [Created] (METRON-2243) [UI] Update npm dependencies to resolve audit warnings
Shane Ardell created METRON-2243: Summary: [UI] Update npm dependencies to resolve audit warnings Key: METRON-2243 URL: https://issues.apache.org/jira/browse/METRON-2243 Project: Metron Issue Type: Improvement Reporter: Shane Ardell After running `npm audit` in both UIs, we have a few dependencies and quite a few nested dependencies needing version updates. This should be as simple as running `npm audit fix`, although there may be a few dependencies needing major version updates that require manual updates. -- This message was sent by Atlassian Jira (v8.3.2#803003)
