[GitHub] [metron] JonZeolla commented on pull request #1580: METRON-2348 fix prepare-commit
JonZeolla commented on pull request #1580: URL: https://github.com/apache/metron/pull/1580#issuecomment-620020230 +1 by inspection, pending successful CI This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [metron] ottobackwards opened a new pull request #1580: METRON-2348 fix prepare-commit
ottobackwards opened a new pull request #1580:
URL: https://github.com/apache/metron/pull/1580
Fix the prepare-commit script by changing the check for "Status" to
instead two checks, for the PR being open, and it being cleanly
mergable.
NOTE: this adds a dependency on [jq](https://stedolan.github.io/jq/)
Testing : run prepare-commit for a PR that exists in either repo, see that
it doesn't work.
run again with this fix
> NOTE: this pr introduces a requirement for
[jq](https://stedolan.github.io/jq/)
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
for the complete guide to follow for contributions.
Please refer also to our [Build Verification
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow
these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to be
created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON- where is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified
and tested manually?
- [-] Have you ensured that the full suite of tests and checks have been
executed in the root metron folder via:
```
mvn -q clean integration-test install &&
dev-utilities/build-utils/verify_licenses.sh
```
- [-] Have you written or updated unit tests and or integration tests to
verify your changes?
- [-] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [-] Have you verified the basic functionality of the build by building and
running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [-] Have you ensured that format looks appropriate for the output in which
it is rendered by building and verifying the site-book? If not then run the
following commands and the verify changes via
`site-book/target/site/index.html`:
```
cd site-book
mvn site
```
- [-] Have you ensured that any documentation diagrams have been updated,
along with their source files, using [draw.io](https://www.draw.io/)? See
[Metron Development
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Development+Guidelines)
for instructions.
Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up for
your personal repository such that your branches are built there before
submitting a pull request.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (METRON-2348) prepare-commit broken by github api change
Otto Fowler created METRON-2348: --- Summary: prepare-commit broken by github api change Key: METRON-2348 URL: https://issues.apache.org/jira/browse/METRON-2348 Project: Metron Issue Type: Bug Reporter: Otto Fowler Assignee: Otto Fowler You can no longer find the PR, because the return doesn't have the Status: field. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [metron-bro-plugin-kafka] nickwallen commented on pull request #41: METRON-2346: Update kafka plugin testing dependencies
nickwallen commented on pull request #41: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/41#issuecomment-619990282 +1 Thanks @JonZeolla ! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (METRON-2347) Move kafka plugin testing to docker compose
Jon Zeolla created METRON-2347: -- Summary: Move kafka plugin testing to docker compose Key: METRON-2347 URL: https://issues.apache.org/jira/browse/METRON-2347 Project: Metron Issue Type: Improvement Reporter: Jon Zeolla Assignee: Jon Zeolla Currently we use a series of bash scripts to run our tests in docker containers, but we should use docker compose instead. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [metron-bro-plugin-kafka] JonZeolla opened a new pull request #41: METRON-2346: Update kafka plugin testing dependencies
JonZeolla opened a new pull request #41: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/41 ## Contributor Comments As a part of the bro rename to zeek, our testing environment broke. To test, run `./run_end_to_end.sh` and confirm it now succeeds. ## Pull Request Checklist Thank you for submitting a contribution to Apache Metron's Bro kafka writer plugin. In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following: ### For all changes: - [X] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). - [X] Does your PR title start with METRON- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [X] Has your PR been rebased against the latest commit within the target branch (typically master)? ### For code changes: - [X] Have you included steps to reproduce the behavior or problem that is being changed or addressed? - [X] Have you included steps or a guide to how the change may be verified and tested manually? - [X] Have you ensured that the full suite of tests and checks have been executed via: ``` bro-pkg test $GITHUB_USERNAME/metron-bro-plugin-kafka --version $BRANCH ``` - [ ] Have you written or updated unit tests and or integration tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] Have you verified the basic functionality of the build by building and running locally with Apache Metron's [Vagrant full-dev environment](https://github.com/apache/metron/tree/master/metron-deployment/development/centos6) or the equivalent? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (METRON-2346) Update kafka plugin testing dependencies
[ https://issues.apache.org/jira/browse/METRON-2346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jon Zeolla updated METRON-2346: --- Summary: Update kafka plugin testing dependencies (was: Kafka Plugin no longer builds) > Update kafka plugin testing dependencies > > > Key: METRON-2346 > URL: https://issues.apache.org/jira/browse/METRON-2346 > Project: Metron > Issue Type: Improvement >Reporter: Jon Zeolla >Assignee: Jon Zeolla >Priority: Major > > The kafka plugin no longer builds after the bro -> zeek renaming. This is an > interim step to get the docker testing environment functional again by > repointing some download locations. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (METRON-2346) Kafka Plugin no longer builds
Jon Zeolla created METRON-2346: -- Summary: Kafka Plugin no longer builds Key: METRON-2346 URL: https://issues.apache.org/jira/browse/METRON-2346 Project: Metron Issue Type: Improvement Reporter: Jon Zeolla Assignee: Jon Zeolla The kafka plugin no longer builds after the bro -> zeek renaming. This is an interim step to get the docker testing environment functional again by repointing some download locations. -- This message was sent by Atlassian Jira (v8.3.4#803005)
