[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on pull request #44: METRON-2270 Update to reflect bro project rename
JonZeolla commented on pull request #44: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/44#issuecomment-623701958 End to end tests are succeeding, but the unit tests appear to be failing so that needs addressed. Converting this PR to a draft since it's still WIP it seems. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on a change in pull request #44: METRON-2270 Update to reflect bro project rename
JonZeolla commented on a change in pull request #44: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/44#discussion_r419702207 ## File path: README.md ## @@ -12,68 +12,68 @@ This software is a part of the [Apache Metron](http://metron.apache.org/) projec ## Installation Review comment: I think that the installation instructions need an update. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on pull request #44: METRON-2270 Update to reflect bro project rename
JonZeolla commented on pull request #44: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/44#issuecomment-623645487 My concern with writing it in a README is that it would be prone to being incorrect. In `zkg.meta` do we say it requires `zeek >=3.0.0`. I tested against 3.0.5 and 3.1.2. I would rather us pursue a CI process that has a testing matrix for multiple zeek versions, and embed that into the README. What do you think? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on pull request #44: METRON-2270 Update to reflect bro project rename
JonZeolla commented on pull request #44: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/44#issuecomment-623587568 Done This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [metron-bro-plugin-kafka] ottobackwards commented on pull request #44: METRON-2270 Update to reflect bro project rename
ottobackwards commented on pull request #44: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/44#issuecomment-623586512 We should mention specifically in the PR description that we are updating to zeek version X. If this is the PR that does it This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on pull request #8: METRON-1768: Adjust versioning of metron-bro-plugin-kafka to be x.y.z
JonZeolla commented on pull request #8: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/8#issuecomment-623586297 This is no longer waiting on a 3.0 release. Depends on #44 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (METRON-2270) Update to reflect bro project rename
[ https://issues.apache.org/jira/browse/METRON-2270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099131#comment-17099131 ] Jon Zeolla commented on METRON-2270: https://github.com/apache/metron-bro-plugin-kafka/pull/44 > Update to reflect bro project rename > > > Key: METRON-2270 > URL: https://issues.apache.org/jira/browse/METRON-2270 > Project: Metron > Issue Type: Improvement >Reporter: Jon Zeolla >Assignee: Jon Zeolla >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > The bro project underwent a large rename, including renaming functions that > we use, such as `bro_init` (which is now `zeek_init`) as well as an overall > project name change. We should update our code and repo name to reflect that. > https://github.com/zeek/zeek/blob/v3.0.0/NEWS#L6 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [metron-bro-plugin-kafka] JonZeolla opened a new pull request #44: METRON-2270 Update to reflect bro project rename
JonZeolla opened a new pull request #44: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/44 ## Contributor Comments This is a breaking change in order to update the plugin to work with more recent versions of zeek (previously bro). There were a few cascading issues that required upgrades, most notably due to [this](https://github.com/zeek/zeek/blob/fda94982769e4216c6b2270f4f276149b1b6d7d1/NEWS#L261-L265) and [this](https://github.com/edenhill/librdkafka/issues/2681). As of this PR, `zkg.meta` points to a librdkafka 1.4.2-RC2. We may want to wait to merge until 1.4.2 or 1.5.0 are released and update `zkg.meta`. ### Testing Run `./run_end_to_end.sh` ## Pull Request Checklist Thank you for submitting a contribution to Apache Metron's Bro kafka writer plugin. In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following: ### For all changes: - [X] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). - [X] Does your PR title start with METRON- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [X] Has your PR been rebased against the latest commit within the target branch (typically master)? ### For code changes: - [X] Have you included steps to reproduce the behavior or problem that is being changed or addressed? - [X] Have you included steps or a guide to how the change may be verified and tested manually? - [X] Have you ensured that the full suite of tests and checks have been executed via: ``` bro-pkg test $GITHUB_USERNAME/metron-bro-plugin-kafka --version $BRANCH ``` - [ ] Have you written or updated unit tests and or integration tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] Have you verified the basic functionality of the build by building and running locally with Apache Metron's [Vagrant full-dev environment](https://github.com/apache/metron/tree/master/metron-deployment/development/centos6) or the equivalent? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
