[GitHub] [metron-bro-plugin-kafka] ottobackwards commented on pull request #45: METRON-2353: Plugin e2e tests should support multiple brokers

2020-05-18 Thread GitBox


ottobackwards commented on pull request #45:
URL: 
https://github.com/apache/metron-bro-plugin-kafka/pull/45#issuecomment-630470979


   Great work @JonZeolla, thanks!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [metron-bro-plugin-kafka] asfgit closed pull request #45: METRON-2353: Plugin e2e tests should support multiple brokers

2020-05-18 Thread GitBox


asfgit closed pull request #45:
URL: https://github.com/apache/metron-bro-plugin-kafka/pull/45


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on pull request #45: METRON-2353: Plugin e2e tests should support multiple brokers

2020-05-18 Thread GitBox


JonZeolla commented on pull request #45:
URL: 
https://github.com/apache/metron-bro-plugin-kafka/pull/45#issuecomment-630408339


   @ottobackwards ready for review now.  In troubleshooting some issues running 
this up locally I found that I was hitting the consumer timeout; hence 
increasing it from 1000 to 5000 based on the additional resources needed for 
multiple brokers/partitions.  However, I found many other small bugs along the 
way which are fixed in this PR.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org