[GitHub] [metron] JonZeolla commented on a change in pull request #1580: METRON-2348 fix prepare-commit
JonZeolla commented on a change in pull request #1580: URL: https://github.com/apache/metron/pull/1580#discussion_r420477673 ## File path: dev-utilities/committer-utils/metron-committer-common ## @@ -135,8 +135,8 @@ function read_pull_request { exit 1 fi -if [[ "$PR_MERGEABLE" != "\"clean\"" ]]; then - echo "Error: pull request #$PR is not mergable" +if [[ "$PR_MERGEABLE" == "\"clean\"" ]] || [[ "$PR_MERGEABLE" == "unstable" ]]; then Review comment: Not sure what you were getting at with this change. Did you mean to change `!=` to `==`? Also, if it's `!= "\"clean\""` then it doesn't matter if it's `== "unstable"` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [metron] JonZeolla commented on a change in pull request #1580: METRON-2348 fix prepare-commit
JonZeolla commented on a change in pull request #1580: URL: https://github.com/apache/metron/pull/1580#discussion_r420477673 ## File path: dev-utilities/committer-utils/metron-committer-common ## @@ -135,8 +135,8 @@ function read_pull_request { exit 1 fi -if [[ "$PR_MERGEABLE" != "\"clean\"" ]]; then - echo "Error: pull request #$PR is not mergable" +if [[ "$PR_MERGEABLE" == "\"clean\"" ]] || [[ "$PR_MERGEABLE" == "unstable" ]]; then Review comment: Not sure what you were getting at with this change. Did you mean to change `!=` to `==`? Also, if it's `!= "\"clean\""` then it doesn't matter if it's `== "unstable"` or `== "literallyanything"` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [metron] JonZeolla commented on a change in pull request #1580: METRON-2348 fix prepare-commit
JonZeolla commented on a change in pull request #1580: URL: https://github.com/apache/metron/pull/1580#discussion_r420477673 ## File path: dev-utilities/committer-utils/metron-committer-common ## @@ -135,8 +135,8 @@ function read_pull_request { exit 1 fi -if [[ "$PR_MERGEABLE" != "\"clean\"" ]]; then - echo "Error: pull request #$PR is not mergable" +if [[ "$PR_MERGEABLE" == "\"clean\"" ]] || [[ "$PR_MERGEABLE" == "unstable" ]]; then Review comment: I think you meant `if [[ "$PR_MERGEABLE" != "\"clean\"" ]] || [[ "$PR_MERGEABLE" == "unstable" ]]; then` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org