[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on pull request #44: METRON-2270 Update to reflect bro project rename

2020-05-06 Thread GitBox 


JonZeolla commented on pull request #44:
URL: 
https://github.com/apache/metron-bro-plugin-kafka/pull/44#issuecomment-624657441


   That's just a side effect of our merging process, which doesn't use the 
github built-ins.  This was squash merged as 
587e9dac9b915f7d0c1116a4432447b5d92e meaning it's in master.  At some point 
probably not too far out I expect to cut a 1.0.0 release



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on pull request #44: METRON-2270 Update to reflect bro project rename

2020-05-05 Thread GitBox 


JonZeolla commented on pull request #44:
URL: 
https://github.com/apache/metron-bro-plugin-kafka/pull/44#issuecomment-624043661


   @ottobackwards Unit tests and e2e are both passing now.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on pull request #44: METRON-2270 Update to reflect bro project rename

2020-05-04 Thread GitBox 


JonZeolla commented on pull request #44:
URL: 
https://github.com/apache/metron-bro-plugin-kafka/pull/44#issuecomment-623701958


   End to end tests are succeeding, but the unit tests appear to be failing so 
that needs addressed.  Converting this PR to a draft since it's still WIP it 
seems.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on pull request #44: METRON-2270 Update to reflect bro project rename

2020-05-04 Thread GitBox 


JonZeolla commented on pull request #44:
URL: 
https://github.com/apache/metron-bro-plugin-kafka/pull/44#issuecomment-623645487


   My concern with writing it in a README is that it would be prone to being 
incorrect.  In `zkg.meta` do we say it requires `zeek >=3.0.0`.  I tested 
against 3.0.5 and 3.1.2.  I would rather us pursue a CI process that has a 
testing matrix for multiple zeek versions, and embed that into the README.  
What do you think?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on pull request #44: METRON-2270 Update to reflect bro project rename

2020-05-04 Thread GitBox 


JonZeolla commented on pull request #44:
URL: 
https://github.com/apache/metron-bro-plugin-kafka/pull/44#issuecomment-623587568


   Done



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org