[GitHub] metron issue #1014: METRON-1563 : Base Stellar assign for feature branch
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/1014 @ottobackwards If it's a feature branch, the PR on Github doesn't automatically close. It only happens for merges into a master. It's a bit annoying, but I'm not sure there's a whole lot to do about it ---
[GitHub] metron issue #1014: METRON-1563 : Base Stellar assign for feature branch
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/1014 This is in, not sure why it isn't closed ---
[GitHub] metron issue #1014: METRON-1563 : Base Stellar assign for feature branch
Github user cestella commented on the issue: https://github.com/apache/metron/pull/1014 Ok, this looks good. +1 to go to the feature branch ---
[GitHub] metron issue #1014: METRON-1563 : Base Stellar assign for feature branch
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/1014 ok, I updated the feature base to track master, and pulled that into this. I also added support for `:=` @cestella ---
[GitHub] metron issue #1014: METRON-1563 : Base Stellar assign for feature branch
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/1014 I'll expand the assignment to include := in literal stellar, maybe that will bump some review ---
[GitHub] metron issue #1014: METRON-1563 : Base Stellar assign for feature branch
Github user JonZeolla commented on the issue: https://github.com/apache/metron/pull/1014 I wonder if it's good enough just to keep `:=` and `=` around, but not have that affect the format of `++`, `+=`, etc. ---
[GitHub] metron issue #1014: METRON-1563 : Base Stellar assign for feature branch
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/1014 Can I ask how we do ++, --, += etc with the := notation? ---
[GitHub] metron issue #1014: METRON-1563 : Base Stellar assign for feature branch
Github user cestella commented on the issue: https://github.com/apache/metron/pull/1014 Do we want to expand assignment to `:=` as part of this PR or make it a follow-on in this feature branch? I'm ok with either way. ---
[GitHub] metron issue #1014: METRON-1563 : Base Stellar assign for feature branch
Github user cestella commented on the issue: https://github.com/apache/metron/pull/1014 >Ultimately, I'd like to see us move to supporting = as that is just way more intuitive for most people. Maybe that means supporting both = and := for some period of time? In my opinion we should support both for at least a release. ---
[GitHub] metron issue #1014: METRON-1563 : Base Stellar assign for feature branch
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/1014 > I am not sure how this PR impacts all the places where Stellar is used and assignment .. Or maybe that is left to a future PR? Sorry, its a little hard to digest that old PR, but I think from [this comment](https://github.com/apache/metron/pull/687#issuecomment-387840955), @ottobackwards is saying that all the other touch points would be updated in a future PR on this feature branch. ---
[GitHub] metron issue #1014: METRON-1563 : Base Stellar assign for feature branch
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/1014 > Should assignment be = or :=? Ultimately, I'd like to see us move to supporting `=` as that is just way more intuitive for most people. Maybe that means supporting both `=` and `:=` for some period of time? It looks like `StellarAssignment` was not altered here, so maybe both are supported in this PR? Is that what you are thinking @ottobackwards ? I am not sure how this PR impacts all the places where Stellar is used and assignment might already occur; field transforms, enrichment, REPL, profiler, etc. There is some other way in which assignment is handled in at least some of these places. I imagine that we would need to update these to use the new mechanism here? Or maybe that is left to a future PR? ---
[GitHub] metron issue #1014: METRON-1563 : Base Stellar assign for feature branch
Github user cestella commented on the issue: https://github.com/apache/metron/pull/1014 Should assignment be `=` or `:=`? I'm not super opinionated other than we have been using `:=` and we'd break existing installations if we move to `=`, right? ---
[GitHub] metron issue #1014: METRON-1563 : Base Stellar assign for feature branch
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/1014 ok, @cestella I have fixed up the feature branch and this pr so it is clean ---
[GitHub] metron issue #1014: METRON-1563 : Base Stellar assign for feature branch
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/1014 @cestella I rebased this on the new feature branch ( after rebasing on the same master ) and I get all of these other commits. I don't know how to get rid of them? ---
