[GitHub] metron issue #1156: METRON-1702: Reload a running job in the UI

2018-08-10 Thread sardell 
Github user sardell commented on the issue:

https://github.com/apache/metron/pull/1156
  
+1. Tested on full dev.


---

[GitHub] metron issue #1156: METRON-1702: Reload a running job in the UI

2018-08-10 Thread ruffle1986 
Github user ruffle1986 commented on the issue:

https://github.com/apache/metron/pull/1156
  
@merrimanr Looks good to me.


---

[GitHub] metron issue #1156: METRON-1702: Reload a running job in the UI

2018-08-09 Thread sardell 
Github user sardell commented on the issue:

https://github.com/apache/metron/pull/1156
  
@merrimanr I reviewed and tested on full dev. I have the same thought as 
@ruffle1986 regarding the cancelling of the subscription. We should add that 
line inside the ngOnDestroy lifecycle hook. Besides that, tested on full dev 
and everything works as described. This is really great work and will 
significantly improve the user experience. +1 once the subscription 
cancellation is added.


---

[GitHub] metron issue #1156: METRON-1702: Reload a running job in the UI

2018-08-09 Thread merrimanr 
Github user merrimanr commented on the issue:

https://github.com/apache/metron/pull/1156
  
Thanks @tiborm and @ruffle1986.  I merged in the latest feature branch 
which included the onDestroy code.  I also fixed a regression introduced by 
https://github.com/apache/metron/pull/1142 and added test to catch it in the 
future.  Let me know what you think.


---