[GitHub] metron pull request #1119: METRON-1676: Adding date range selector to PCAP f...

2018-08-06 Thread tiborm
Github user tiborm closed the pull request at:

https://github.com/apache/metron/pull/1119


---


[GitHub] metron pull request #1119: METRON-1676: Adding date range selector to PCAP f...

2018-08-03 Thread merrimanr
Github user merrimanr commented on a diff in the pull request:

https://github.com/apache/metron/pull/1119#discussion_r207554704
  
--- Diff: metron-interface/metron-alerts/src/app/pcap/pcap.routing.ts ---
@@ -1,4 +1,4 @@
-/**
+/*
--- End diff --

Was this intentional?


---


[GitHub] metron pull request #1119: METRON-1676: Adding date range selector to PCAP f...

2018-07-19 Thread tiborm
GitHub user tiborm opened a pull request:

https://github.com/apache/metron/pull/1119

METRON-1676: Adding date range selector to PCAP filter bar

## Contributor Comments
PR adding the missing date range selector to the PCAP filter bar.

https://user-images.githubusercontent.com/2437400/42957374-c71fdbae-8b82-11e8-9338-818ca861f3ca.png;>tc.]


## Pull Request Checklist

Thank you for submitting a contribution to Apache Metron.  
Please refer to our [Development 
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
 for the complete guide to follow for contributions.  
Please refer also to our [Build Verification 
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
 for complete smoke testing guides.  


In order to streamline the review of the contribution we ask you follow 
these guidelines and ask you to double check the following:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? If not one needs to 
be created at [Metron 
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [ ] Does your PR title start with METRON- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?


### For code changes:
- [ ] Have you included steps to reproduce the behavior or problem that is 
being changed or addressed?
- [ ] Have you included steps or a guide to how the change may be verified 
and tested manually?
- [ ] Have you ensured that the full suite of tests and checks have been 
executed in the root metron folder via:
  ```
  mvn -q clean integration-test install && 
dev-utilities/build-utils/verify_licenses.sh 
  ```

- [ ] Have you written or updated unit tests and or integration tests to 
verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] Have you verified the basic functionality of the build by building 
and running locally with Vagrant full-dev environment or the equivalent?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered by building and verifying the site-book? If not then run 
the following commands and the verify changes via 
`site-book/target/site/index.html`:

  ```
  cd site-book
  mvn site
  ```

 Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up 
for your personal repository such that your branches are built there before 
submitting a pull request.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tiborm/metron METRON-1676

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/metron/pull/1119.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1119


commit 872d1b1ee13e358c18956945d71d3667d19fca8a
Author: merrimanr 
Date:   2018-04-12T14:57:48Z

Merge branch 'pcap-front' of https://github.com/simonellistonball/metron 
into pcaprest

Conflicts:
metron-interface/metron-alerts/src/app/app.module.ts

commit b1b6a7dabea1a1d0d132482c8d97af29c0ac2683
Author: merrimanr 
Date:   2018-04-13T15:00:15Z

initial commit

 Conflicts:

metron-interface/metron-rest/src/main/java/org/apache/metron/rest/MetronRestApplication.java

metron-interface/metron-rest/src/main/java/org/apache/metron/rest/controller/PcapQueryController.java

metron-interface/metron-rest/src/main/java/org/apache/metron/rest/util/pcapQueryThread.java

commit 55cf2d945a4fcff1e7e2e47a234037ed6f394b2e
Author: merrimanr 
Date:   2018-04-18T15:52:56Z

added license headers

commit 70696d047c6ef4b8ce5fcda03588474ff5b2c506
Author: tiborm 
Date:   2018-07-11T14:58:56Z

METRON-1662: adding download button to pcap tab

commit 4a83d46259736d8c721fb9f640b6ad522f91a559
Author: tiborm 
Date:   2018-07-12T07:09:14Z

METRON-1662: removing unused function from the first iteration

commit 9f57724597240a05d1caeec73882a4ed50aadd9a
Author: tiborm 
Date:   2018-07-12T08:36:15Z

METRON-1662: changing download button label from pdml to pcap

commit 49385eeab612d4f02882888f45defe5cca61f0b9
Author: tiborm 
Date:   2018-07-16T15:00:55Z

METRON-1662: cleaning pdml.ts

commit