[GitHub] metron pull request #1176: METRON-1751 Storm Profiler dies when consuming nu...

2018-08-29 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/metron/pull/1176


---


[GitHub] metron pull request #1176: METRON-1751 Storm Profiler dies when consuming nu...

2018-08-27 Thread nickwallen
GitHub user nickwallen opened a pull request:

https://github.com/apache/metron/pull/1176

METRON-1751 Storm Profiler dies when consuming null message

The Storm Profiler dies if a null message is consumed from the input Kafka 
topic.  The Profiler should skip past any null messages and continue processing.

## Testing

1. Create a "hello-world" profile using the Storm Profiler as outlined in 
the README.

1. Push a null message on to the "indexing" Kafka topic.

1. Make sure the Storm topology does not die and that a profile measurement 
is flushed.

## Pull Request Checklist

- [ ] Is there a JIRA ticket associated with this PR? If not one needs to 
be created at [Metron 
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [ ] Does your PR title start with METRON- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?
- [ ] Have you included steps to reproduce the behavior or problem that is 
being changed or addressed?
- [ ] Have you included steps or a guide to how the change may be verified 
and tested manually?
- [ ] Have you ensured that the full suite of tests and checks have been 
executed in the root metron folder via:
- [ ] Have you written or updated unit tests and or integration tests to 
verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] Have you verified the basic functionality of the build by building 
and running locally with Vagrant full-dev environment or the equivalent?



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nickwallen/metron METRON-1751

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/metron/pull/1176.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1176


commit 5123f28ea76ac47d97772d2d4bf0c193aa156697
Author: Nick Allen 
Date:   2018-08-27T13:56:28Z

METRON-1751 Storm Profiler dies when consuming null message




---