[GitHub] metron pull request #1207: METRON-1695: Expose pcap properties through Ambar...
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/1207 ---
[GitHub] metron pull request #1207: METRON-1695: Expose pcap properties through Ambar...
Github user anandsubbu commented on a diff in the pull request: https://github.com/apache/metron/pull/1207#discussion_r222726135 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/params/status_params.py --- @@ -119,8 +119,8 @@ metron_keytab_path = config['configurations']['metron-env']['metron_service_keytab'] # Pcap -metron_pcap_topology = 'pcap' -pcap_input_topic = 'pcap' +metron_pcap_topology = config['configurations']['metron-pcap-env']['spout_kafka_topic_pcap'] --- End diff -- Done, changed. ---
[GitHub] metron pull request #1207: METRON-1695: Expose pcap properties through Ambar...
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/1207#discussion_r222720563 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/params/status_params.py --- @@ -119,8 +119,8 @@ metron_keytab_path = config['configurations']['metron-env']['metron_service_keytab'] # Pcap -metron_pcap_topology = 'pcap' -pcap_input_topic = 'pcap' +metron_pcap_topology = config['configurations']['metron-pcap-env']['spout_kafka_topic_pcap'] --- End diff -- Quick fix needed. ``` metron_pcap_topology = 'pcap' ``` ---
[GitHub] metron pull request #1207: METRON-1695: Expose pcap properties through Ambar...
Github user anandsubbu commented on a diff in the pull request: https://github.com/apache/metron/pull/1207#discussion_r219736069 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/params/params_linux.py --- @@ -387,18 +388,32 @@ bolt_hdfs_rotation_policy_units = config['configurations']['metron-indexing-env']['bolt_hdfs_rotation_policy_units'] bolt_hdfs_rotation_policy_count = config['configurations']['metron-indexing-env']['bolt_hdfs_rotation_policy_count'] -# Pcap +# PCAP metron_pcap_topology = 'pcap' pcap_input_topic = 'pcap' --- End diff -- The latest commit fetches the topology and topic name from Ambari config. ---
[GitHub] metron pull request #1207: METRON-1695: Expose pcap properties through Ambar...
Github user MohanDV commented on a diff in the pull request: https://github.com/apache/metron/pull/1207#discussion_r219501331 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/params/params_linux.py --- @@ -387,18 +388,32 @@ bolt_hdfs_rotation_policy_units = config['configurations']['metron-indexing-env']['bolt_hdfs_rotation_policy_units'] bolt_hdfs_rotation_policy_count = config['configurations']['metron-indexing-env']['bolt_hdfs_rotation_policy_count'] -# Pcap +# PCAP metron_pcap_topology = 'pcap' pcap_input_topic = 'pcap' --- End diff -- pcap input topic is also exposed , so shouldn't we be getting the value from config tab ? ---
[GitHub] metron pull request #1207: METRON-1695: Expose pcap properties through Ambar...
Github user MohanDV commented on a diff in the pull request: https://github.com/apache/metron/pull/1207#discussion_r219503222 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/params/params_linux.py --- @@ -387,18 +388,32 @@ bolt_hdfs_rotation_policy_units = config['configurations']['metron-indexing-env']['bolt_hdfs_rotation_policy_units'] bolt_hdfs_rotation_policy_count = config['configurations']['metron-indexing-env']['bolt_hdfs_rotation_policy_count'] -# Pcap +# PCAP metron_pcap_topology = 'pcap' pcap_input_topic = 'pcap' --- End diff -- pcap input topic is also hardcoded in [status_param.py ](https://github.com/MohanDV/metron/blob/a46fda45b46a9f317e2ef7c3755ce6f072ed893b/metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/params/status_params.py#L123) we should get the value from config tab here too. ---
[GitHub] metron pull request #1207: METRON-1695: Expose pcap properties through Ambar...
GitHub user anandsubbu opened a pull request: https://github.com/apache/metron/pull/1207 METRON-1695: Expose pcap properties through Ambari ## Contributor Comments This change makes the PCAP config properties available via the Metron service -> Configs tab in Ambari. It also takes care of updating the `pcap.properties` file with relevant values depending on the deploy environment (single node vs. multi node vs. kerberized cluster). Here's a screenshot of the PCAP Config:  ### Testing Steps * Launch full dev * Metron PCAP service should come up successfully. * Go to Ambari -> Metron services -> Configs -> PCAP tab; change any config parameter; * Restart the required services and the config change take effect. ### Testing Done I ran the following different tests to validate the fix. A. Full Dev * Verified Metron PCAP service comes up successfully * Changed some of the PCAP config values from the Ambari UI, validated that this is reflected in the `pcap.properties` file upon service restart. - **Note**: I ran into [METRON-1786](https://issues.apache.org/jira/browse/METRON-1786) during testing. I was able to resolve the issue by applying the fix in PR #1206 B. Multi-node Cluster * Validated that the `kafka.zk` property in `pcap.properties` is updated with the correct Broker details * Changed a PCAP service-related property (E.g. `kafka_pcap_numpackets`) and validated that the `pcap.properties` file is updated. * Changed a PCAP REST-related property (E.g. `pcap_page_size`) and validated that the `/etc/default/metron` file is updated. C. Kerberized Cluster * Kerberized the multi-node cluster and setup pycapa * Ingested PCAP into the cluster * Ran queries through the PCAP panel and validated that the modified config settings are in effect (E.g. `pcap_page_size` set to 50). ## Pull Request Checklist Thank you for submitting a contribution to Apache Metron. Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions. Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides. In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). - [x] Does your PR title start with METRON- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? ### For code changes: - [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed? - [x] Have you included steps or a guide to how the change may be verified and tested manually? - [NA] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via: ``` mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh ``` - [ ] Have you written or updated unit tests and or integration tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`: ``` cd site-book mvn site ``` Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request. You can merge this pull request into a Git repository by running: $ git pull https://github.com/anandsubbu/incubator-metron METRON-1695-2
