[jira] [Commented] (METRON-1476) Update to Angular 6.1.3
[ https://issues.apache.org/jira/browse/METRON-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16613973#comment-16613973 ] ASF GitHub Bot commented on METRON-1476: Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/1096 > Update to Angular 6.1.3 > --- > > Key: METRON-1476 > URL: https://issues.apache.org/jira/browse/METRON-1476 > Project: Metron > Issue Type: Improvement >Reporter: Daniel Toth >Assignee: Daniel Toth >Priority: Major > > Update angular to speed up development -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (METRON-1476) Update to Angular 6.1.3
[ https://issues.apache.org/jira/browse/METRON-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16604184#comment-16604184 ] ASF GitHub Bot commented on METRON-1476: Github user sardell commented on a diff in the pull request: https://github.com/apache/metron/pull/1096#discussion_r215198334 --- Diff: metron-interface/metron-alerts/README.md --- @@ -45,7 +45,7 @@ Alerts that are contained in a a meta alert are generally excluded from search r * The Management UI should be installed (which includes [Express](https://expressjs.com/)) * The alerts can be populated using Full Dev or any other setup * UI is developed using angular4 and uses angular-cli -* node.JS >= 7.8.0 +* nvm (or a similar node verison manager) should be installed. The node version required for this project is listed in the [.nvmrc](https://github.com/creationix/nvm#nvmrc) file. --- End diff -- @ruffle1986 Fixed. I also updated `angular-cli` to `Angular CLI` since that seems to be how it's referenced [when mentioned in documentation](https://cli.angular.io/). Thanks for catching that! > Update to Angular 6.1.3 > --- > > Key: METRON-1476 > URL: https://issues.apache.org/jira/browse/METRON-1476 > Project: Metron > Issue Type: Improvement >Reporter: Daniel Toth >Assignee: Daniel Toth >Priority: Major > > Update angular to speed up development -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (METRON-1476) Update to Angular 6.1.3
[ https://issues.apache.org/jira/browse/METRON-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16604086#comment-16604086 ] ASF GitHub Bot commented on METRON-1476: Github user ruffle1986 commented on a diff in the pull request: https://github.com/apache/metron/pull/1096#discussion_r215171209 --- Diff: metron-interface/metron-alerts/README.md --- @@ -45,7 +45,7 @@ Alerts that are contained in a a meta alert are generally excluded from search r * The Management UI should be installed (which includes [Express](https://expressjs.com/)) * The alerts can be populated using Full Dev or any other setup * UI is developed using angular4 and uses angular-cli -* node.JS >= 7.8.0 +* nvm (or a similar node verison manager) should be installed. The node version required for this project is listed in the [.nvmrc](https://github.com/creationix/nvm#nvmrc) file. --- End diff -- We should also update the line above (line 47.): > UI is developed using angular4 and uses angular-cli to: > UI is developed using angular 6 and uses angular-cli > Update to Angular 6.1.3 > --- > > Key: METRON-1476 > URL: https://issues.apache.org/jira/browse/METRON-1476 > Project: Metron > Issue Type: Improvement >Reporter: Daniel Toth >Assignee: Daniel Toth >Priority: Major > > Update angular to speed up development -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (METRON-1476) Update to Angular 6.1.3
[ https://issues.apache.org/jira/browse/METRON-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16604080#comment-16604080 ] ASF GitHub Bot commented on METRON-1476: Github user ruffle1986 commented on a diff in the pull request: https://github.com/apache/metron/pull/1096#discussion_r215170216 --- Diff: metron-interface/metron-alerts/README.md --- @@ -45,7 +45,7 @@ Alerts that are contained in a a meta alert are generally excluded from search r * The Management UI should be installed (which includes [Express](https://expressjs.com/)) * The alerts can be populated using Full Dev or any other setup * UI is developed using angular4 and uses angular-cli -* node.JS >= 7.8.0 +* nvm (or a similar node verison manager) should be installed. The node version required for this project is listed in the [.nvmrc](https://github.com/creationix/nvm#nvmrc) file. --- End diff -- I prefer following the instructions in the repo's readme to install nvm. btw, yes you can install it via homebrew on a mac. > Update to Angular 6.1.3 > --- > > Key: METRON-1476 > URL: https://issues.apache.org/jira/browse/METRON-1476 > Project: Metron > Issue Type: Improvement >Reporter: Daniel Toth >Assignee: Daniel Toth >Priority: Major > > Update angular to speed up development -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (METRON-1476) Update to Angular 6.1.3
[ https://issues.apache.org/jira/browse/METRON-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16603737#comment-16603737 ] ASF GitHub Bot commented on METRON-1476: Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/1096 I'd prefer this to not be included in the next release; 0.6.0. This is a rather large change and I'd like it to get more cycles in master before we include it in a release. Let's wait for @justinleet to kick-out at least the first release candidate of 0.6.0 before we merge this. Does that work for you @justinleet ? > Update to Angular 6.1.3 > --- > > Key: METRON-1476 > URL: https://issues.apache.org/jira/browse/METRON-1476 > Project: Metron > Issue Type: Improvement >Reporter: Daniel Toth >Assignee: Daniel Toth >Priority: Major > > Update angular to speed up development -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (METRON-1476) Update to Angular 6.1.3
[ https://issues.apache.org/jira/browse/METRON-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16603322#comment-16603322 ] ASF GitHub Bot commented on METRON-1476: Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/1096 +1 Looks good. Thanks for all the hard work on this. I validated full dev by spinning it up, running service check, manually validated the Alerts UI, manually validated the Management UI, and successfully ran the e2e tests. > Update to Angular 6.1.3 > --- > > Key: METRON-1476 > URL: https://issues.apache.org/jira/browse/METRON-1476 > Project: Metron > Issue Type: Improvement >Reporter: Daniel Toth >Assignee: Daniel Toth >Priority: Major > > Update angular to speed up development -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (METRON-1476) Update to Angular 6.1.3
[ https://issues.apache.org/jira/browse/METRON-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16603190#comment-16603190 ] ASF GitHub Bot commented on METRON-1476: Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/1096#discussion_r214959210 --- Diff: metron-interface/metron-alerts/README.md --- @@ -45,7 +45,7 @@ Alerts that are contained in a a meta alert are generally excluded from search r * The Management UI should be installed (which includes [Express](https://expressjs.com/)) * The alerts can be populated using Full Dev or any other setup * UI is developed using angular4 and uses angular-cli -* node.JS >= 7.8.0 +* nvm (or a similar node verison manager) should be installed. The node version required for this project is listed in the [.nvmrc](https://github.com/creationix/nvm#nvmrc) file. --- End diff -- Actually, I think this was added as part of #1177 . I will update some of these instructions in a separate follow-on PR to help clarify things for new users. No need to address this here. > Update to Angular 6.1.3 > --- > > Key: METRON-1476 > URL: https://issues.apache.org/jira/browse/METRON-1476 > Project: Metron > Issue Type: Improvement >Reporter: Daniel Toth >Assignee: Daniel Toth >Priority: Major > > Update angular to speed up development -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (METRON-1476) Update to Angular 6.1.3
[ https://issues.apache.org/jira/browse/METRON-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16603133#comment-16603133 ] ASF GitHub Bot commented on METRON-1476: Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/1096#discussion_r214945499 --- Diff: metron-interface/metron-alerts/README.md --- @@ -45,7 +45,7 @@ Alerts that are contained in a a meta alert are generally excluded from search r * The Management UI should be installed (which includes [Express](https://expressjs.com/)) * The alerts can be populated using Full Dev or any other setup * UI is developed using angular4 and uses angular-cli -* node.JS >= 7.8.0 +* nvm (or a similar node verison manager) should be installed. The node version required for this project is listed in the [.nvmrc](https://github.com/creationix/nvm#nvmrc) file. --- End diff -- However we update the instructions here, we should also do the same in `metron-interface/metron-config/README.md`. > Update to Angular 6.1.3 > --- > > Key: METRON-1476 > URL: https://issues.apache.org/jira/browse/METRON-1476 > Project: Metron > Issue Type: Improvement >Reporter: Daniel Toth >Assignee: Daniel Toth >Priority: Major > > Update angular to speed up development -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (METRON-1476) Update to Angular 6.1.3
[ https://issues.apache.org/jira/browse/METRON-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16603131#comment-16603131 ] ASF GitHub Bot commented on METRON-1476: Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/1096#discussion_r214944338 --- Diff: metron-interface/metron-alerts/README.md --- @@ -45,7 +45,7 @@ Alerts that are contained in a a meta alert are generally excluded from search r * The Management UI should be installed (which includes [Express](https://expressjs.com/)) * The alerts can be populated using Full Dev or any other setup * UI is developed using angular4 and uses angular-cli -* node.JS >= 7.8.0 +* nvm (or a similar node verison manager) should be installed. The node version required for this project is listed in the [.nvmrc](https://github.com/creationix/nvm#nvmrc) file. --- End diff -- Do you have any recommendations for how we should install NVM? I am assuming a `brew install nvm` will do the trick on a Mac? Or do you prefer what is mentioned [here](https://github.com/creationix/nvm#install-script)? Maybe we should embed a link to [this](https://github.com/creationix/nvm#install-script) if you think this is the right way to install. > Update to Angular 6.1.3 > --- > > Key: METRON-1476 > URL: https://issues.apache.org/jira/browse/METRON-1476 > Project: Metron > Issue Type: Improvement >Reporter: Daniel Toth >Assignee: Daniel Toth >Priority: Major > > Update angular to speed up development -- This message was sent by Atlassian JIRA (v7.6.3#76005)
