[jira] [Commented] (METRON-1667) Remove the JPA and MySQL elements
[ https://issues.apache.org/jira/browse/METRON-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16631853#comment-16631853 ] ASF GitHub Bot commented on METRON-1667: Github user simonellistonball closed the pull request at: https://github.com/apache/metron/pull/1193 > Remove the JPA and MySQL elements > - > > Key: METRON-1667 > URL: https://issues.apache.org/jira/browse/METRON-1667 > Project: Metron > Issue Type: Sub-task >Reporter: Simon Elliston Ball >Assignee: Simon Elliston Ball >Priority: Major > > Once authentication has been moved out of JPA and MySQL, we will no longer > need MySQL, eclipselink or any of the spring-data-jpa pieces. We should > remove these dependencies to reduce our attack surface. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (METRON-1667) Remove the JPA and MySQL elements
[ https://issues.apache.org/jira/browse/METRON-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16612106#comment-16612106 ] ASF GitHub Bot commented on METRON-1667: Github user simonellistonball closed the pull request at: https://github.com/apache/metron/pull/1114 > Remove the JPA and MySQL elements > - > > Key: METRON-1667 > URL: https://issues.apache.org/jira/browse/METRON-1667 > Project: Metron > Issue Type: Sub-task >Reporter: Simon Elliston Ball >Assignee: Simon Elliston Ball >Priority: Major > > Once authentication has been moved out of JPA and MySQL, we will no longer > need MySQL, eclipselink or any of the spring-data-jpa pieces. We should > remove these dependencies to reduce our attack surface. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (METRON-1667) Remove the JPA and MySQL elements
[ https://issues.apache.org/jira/browse/METRON-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16612109#comment-16612109 ] ASF GitHub Bot commented on METRON-1667: GitHub user simonellistonball opened a pull request: https://github.com/apache/metron/pull/1193 METRON-1667 Remove the JPA and MySQL elements ## Contributor Comments Given that the only use of the JPA elements was for persisting a user database, these dependencies are no longer needed, so will be removed to reduce the vulnerability surface. ## Pull Request Checklist Thank you for submitting a contribution to Apache Metron. Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions. Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides. In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). - [x] Does your PR title start with METRON- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? ### For code changes: - [ ] Have you included steps to reproduce the behavior or problem that is being changed or addressed? - [ ] Have you included steps or a guide to how the change may be verified and tested manually? - [x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via: ``` mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh ``` - [ ] Have you written or updated unit tests and or integration tests to verify your changes? - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`: ``` cd site-book mvn site ``` Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request. You can merge this pull request into a Git repository by running: $ git pull https://github.com/simonellistonball/metron METRON-1667 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/metron/pull/1193.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1193 commit eeb7d586ae44d6a2768d3972cd3ff367cd065e50 Author: Simon Elliston Ball Date: 2018-07-04T11:22:42Z Removed plugins for eclipselink since jpa is no longer included commit 181d38243bfdc4d75b28891a3b06510391c8d4f2 Author: Simon Elliston Ball Date: 2018-07-12T17:15:16Z Removed configs for JPA commit b3f888e4f95b79e034afd0ff7865f748dcc5b6d3 Author: Simon Elliston Ball Date: 2018-07-12T17:20:50Z Remove JPA elements commit 2a1cc4ea73419cdb96dc6ee7bdc35daa9c2e5804 Author: Simon Elliston Ball Date: 2018-07-19T13:46:52Z updated dependencies list to reflect removal of JPA commit 85f7911c05b463a1399d5145ee6f1e86079c Author: Simon Elliston Ball Date: 2018-07-20T10:07:37Z Removed bean setup for jdbc authentication commit 91b09e4ceea196965191eada696f11e6a9792f76 Author: Simon Elliston Ball Date: 2018-07-20T11:08:58Z Added in-memory auth for tests commit e1e4f4f300160c8cd0e8270c60605cfc528e91c7 Author: Simon Elliston Ball Date: 2018-07-19T10:04:44Z Fixed security test for UI settings commit 88f83f48d28383cb33eca4e47abd1b830b9b6f5a Author: Simon Elliston Ball Date: 2018-07-20T12:59:32Z Property placeholder is
[jira] [Commented] (METRON-1667) Remove the JPA and MySQL elements
[ https://issues.apache.org/jira/browse/METRON-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16612103#comment-16612103 ] ASF GitHub Bot commented on METRON-1667: GitHub user simonellistonball reopened a pull request: https://github.com/apache/metron/pull/1114 METRON-1667 Remove the JPA and MySQL elements ## Contributor Comments Given that the only use of the JPA elements was for persisting a user database, these dependencies are no longer needed, so will be removed to reduce the vulnerability surface. ## Pull Request Checklist Thank you for submitting a contribution to Apache Metron. Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions. Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides. In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). - [x] Does your PR title start with METRON- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? ### For code changes: - [ ] Have you included steps to reproduce the behavior or problem that is being changed or addressed? - [ ] Have you included steps or a guide to how the change may be verified and tested manually? - [x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via: ``` mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh ``` - [ ] Have you written or updated unit tests and or integration tests to verify your changes? - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`: ``` cd site-book mvn site ``` Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request. You can merge this pull request into a Git repository by running: $ git pull https://github.com/simonellistonball/metron METRON-1667 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/metron/pull/1114.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1114 commit eeb7d586ae44d6a2768d3972cd3ff367cd065e50 Author: Simon Elliston Ball Date: 2018-07-04T11:22:42Z Removed plugins for eclipselink since jpa is no longer included commit 181d38243bfdc4d75b28891a3b06510391c8d4f2 Author: Simon Elliston Ball Date: 2018-07-12T17:15:16Z Removed configs for JPA commit b3f888e4f95b79e034afd0ff7865f748dcc5b6d3 Author: Simon Elliston Ball Date: 2018-07-12T17:20:50Z Remove JPA elements commit 2a1cc4ea73419cdb96dc6ee7bdc35daa9c2e5804 Author: Simon Elliston Ball Date: 2018-07-19T13:46:52Z updated dependencies list to reflect removal of JPA commit 85f7911c05b463a1399d5145ee6f1e86079c Author: Simon Elliston Ball Date: 2018-07-20T10:07:37Z Removed bean setup for jdbc authentication commit 91b09e4ceea196965191eada696f11e6a9792f76 Author: Simon Elliston Ball Date: 2018-07-20T11:08:58Z Added in-memory auth for tests commit e1e4f4f300160c8cd0e8270c60605cfc528e91c7 Author: Simon Elliston Ball Date: 2018-07-19T10:04:44Z Fixed security test for UI settings commit 88f83f48d28383cb33eca4e47abd1b830b9b6f5a Author: Simon Elliston Ball Date: 2018-07-20T12:59:32Z Property placeholder i
[jira] [Commented] (METRON-1667) Remove the JPA and MySQL elements
[ https://issues.apache.org/jira/browse/METRON-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16612102#comment-16612102 ] ASF GitHub Bot commented on METRON-1667: Github user simonellistonball closed the pull request at: https://github.com/apache/metron/pull/1114 > Remove the JPA and MySQL elements > - > > Key: METRON-1667 > URL: https://issues.apache.org/jira/browse/METRON-1667 > Project: Metron > Issue Type: Sub-task >Reporter: Simon Elliston Ball >Assignee: Simon Elliston Ball >Priority: Major > > Once authentication has been moved out of JPA and MySQL, we will no longer > need MySQL, eclipselink or any of the spring-data-jpa pieces. We should > remove these dependencies to reduce our attack surface. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (METRON-1667) Remove the JPA and MySQL elements
[ https://issues.apache.org/jira/browse/METRON-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16549312#comment-16549312 ] ASF GitHub Bot commented on METRON-1667: Github user simonellistonball commented on the issue: https://github.com/apache/metron/pull/1113 Apologies, re-submitting against the feature branch. > Remove the JPA and MySQL elements > - > > Key: METRON-1667 > URL: https://issues.apache.org/jira/browse/METRON-1667 > Project: Metron > Issue Type: Sub-task >Reporter: Simon Elliston Ball >Priority: Major > > Once authentication has been moved out of JPA and MySQL, we will no longer > need MySQL, eclipselink or any of the spring-data-jpa pieces. We should > remove these dependencies to reduce our attack surface. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (METRON-1667) Remove the JPA and MySQL elements
[ https://issues.apache.org/jira/browse/METRON-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16549313#comment-16549313 ] ASF GitHub Bot commented on METRON-1667: GitHub user simonellistonball opened a pull request: https://github.com/apache/metron/pull/1114 METRON-1667 Remove the JPA and MySQL elements ## Contributor Comments Given that the only use of the JPA elements was for persisting a user database, these dependencies are no longer needed, so will be removed to reduce the vulnerability surface. ## Pull Request Checklist Thank you for submitting a contribution to Apache Metron. Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions. Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides. In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). - [x] Does your PR title start with METRON- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? ### For code changes: - [ ] Have you included steps to reproduce the behavior or problem that is being changed or addressed? - [ ] Have you included steps or a guide to how the change may be verified and tested manually? - [x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via: ``` mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh ``` - [ ] Have you written or updated unit tests and or integration tests to verify your changes? - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`: ``` cd site-book mvn site ``` Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request. You can merge this pull request into a Git repository by running: $ git pull https://github.com/simonellistonball/metron METRON-1667 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/metron/pull/1114.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1114 commit eeb7d586ae44d6a2768d3972cd3ff367cd065e50 Author: Simon Elliston Ball Date: 2018-07-04T11:22:42Z Removed plugins for eclipselink since jpa is no longer included commit 181d38243bfdc4d75b28891a3b06510391c8d4f2 Author: Simon Elliston Ball Date: 2018-07-12T17:15:16Z Removed configs for JPA commit b3f888e4f95b79e034afd0ff7865f748dcc5b6d3 Author: Simon Elliston Ball Date: 2018-07-12T17:20:50Z Remove JPA elements commit 2a1cc4ea73419cdb96dc6ee7bdc35daa9c2e5804 Author: Simon Elliston Ball Date: 2018-07-19T13:46:52Z updated dependencies list to reflect removal of JPA > Remove the JPA and MySQL elements > - > > Key: METRON-1667 > URL: https://issues.apache.org/jira/browse/METRON-1667 > Project: Metron > Issue Type: Sub-task >Reporter: Simon Elliston Ball >Priority: Major > > Once authentication has been moved out of JPA and MySQL, we will no longer > need MySQL, eclipselink or any of the spring-data-jpa pieces. We should > remove these dependencies to reduce our attack surface. -- This message was sent by Atlassian JIRA
[jira] [Commented] (METRON-1667) Remove the JPA and MySQL elements
[ https://issues.apache.org/jira/browse/METRON-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16549306#comment-16549306 ] ASF GitHub Bot commented on METRON-1667: Github user simonellistonball closed the pull request at: https://github.com/apache/metron/pull/1113 > Remove the JPA and MySQL elements > - > > Key: METRON-1667 > URL: https://issues.apache.org/jira/browse/METRON-1667 > Project: Metron > Issue Type: Sub-task >Reporter: Simon Elliston Ball >Priority: Major > > Once authentication has been moved out of JPA and MySQL, we will no longer > need MySQL, eclipselink or any of the spring-data-jpa pieces. We should > remove these dependencies to reduce our attack surface. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (METRON-1667) Remove the JPA and MySQL elements
[ https://issues.apache.org/jira/browse/METRON-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16549304#comment-16549304 ] ASF GitHub Bot commented on METRON-1667: GitHub user simonellistonball opened a pull request: https://github.com/apache/metron/pull/1113 METRON-1667 Remove the JPA and MySQL elements ## Contributor Comments Given that the only use of the JPA elements was for persisting a user database, these dependencies are no longer needed, so will be removed to reduce the vulnerability surface. ## Pull Request Checklist Thank you for submitting a contribution to Apache Metron. Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions. Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides. In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). - [x] Does your PR title start with METRON- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? ### For code changes: - [ ] Have you included steps to reproduce the behavior or problem that is being changed or addressed? - [ ] Have you included steps or a guide to how the change may be verified and tested manually? - [x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via: ``` mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh ``` - [ ] Have you written or updated unit tests and or integration tests to verify your changes? - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`: ``` cd site-book mvn site ``` Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request. You can merge this pull request into a Git repository by running: $ git pull https://github.com/simonellistonball/metron METRON-1667 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/metron/pull/1113.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1113 commit eeb7d586ae44d6a2768d3972cd3ff367cd065e50 Author: Simon Elliston Ball Date: 2018-07-04T11:22:42Z Removed plugins for eclipselink since jpa is no longer included commit 181d38243bfdc4d75b28891a3b06510391c8d4f2 Author: Simon Elliston Ball Date: 2018-07-12T17:15:16Z Removed configs for JPA commit b3f888e4f95b79e034afd0ff7865f748dcc5b6d3 Author: Simon Elliston Ball Date: 2018-07-12T17:20:50Z Remove JPA elements commit 2a1cc4ea73419cdb96dc6ee7bdc35daa9c2e5804 Author: Simon Elliston Ball Date: 2018-07-19T13:46:52Z updated dependencies list to reflect removal of JPA > Remove the JPA and MySQL elements > - > > Key: METRON-1667 > URL: https://issues.apache.org/jira/browse/METRON-1667 > Project: Metron > Issue Type: Sub-task >Reporter: Simon Elliston Ball >Priority: Major > > Once authentication has been moved out of JPA and MySQL, we will no longer > need MySQL, eclipselink or any of the spring-data-jpa pieces. We should > remove these dependencies to reduce our attack surface. -- This message was sent by Atlassian JIRA
