[jira] [Commented] (METRON-1723) PCAP UI - Unable to select/copy from packets details in PCAP query panel
[ https://issues.apache.org/jira/browse/METRON-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16574885#comment-16574885 ] ASF GitHub Bot commented on METRON-1723: Github user sardell closed the pull request at: https://github.com/apache/metron/pull/1139 > PCAP UI - Unable to select/copy from packets details in PCAP query panel > > > Key: METRON-1723 > URL: https://issues.apache.org/jira/browse/METRON-1723 > Project: Metron > Issue Type: Sub-task >Reporter: Shane Ardell >Assignee: Shane Ardell >Priority: Major > Attachments: expand-collapse-details-PCAP-query.mp4 > > > Upon query completion, a user can click on a row and drill down (up to 2 > levels) for a given packet. > A SOC analyst might find it useful to select/copy specific information from > the 2nd level granular details (E.g. MAC address, IP address, timestamps > etc.) to be used subsequently for analysis/investigation. > Currently, selecting or clicking on nested content fires an event that > expands/collapses the information. See the attached video to view the > behavior. > It would be better if target for the collapse/expand event only applied to > the top of the details section. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (METRON-1723) PCAP UI - Unable to select/copy from packets details in PCAP query panel
[ https://issues.apache.org/jira/browse/METRON-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16574788#comment-16574788 ] ASF GitHub Bot commented on METRON-1723: Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/1139 This has been merge in the the feature branch. Can you close? > PCAP UI - Unable to select/copy from packets details in PCAP query panel > > > Key: METRON-1723 > URL: https://issues.apache.org/jira/browse/METRON-1723 > Project: Metron > Issue Type: Sub-task >Reporter: Shane Ardell >Assignee: Shane Ardell >Priority: Major > Attachments: expand-collapse-details-PCAP-query.mp4 > > > Upon query completion, a user can click on a row and drill down (up to 2 > levels) for a given packet. > A SOC analyst might find it useful to select/copy specific information from > the 2nd level granular details (E.g. MAC address, IP address, timestamps > etc.) to be used subsequently for analysis/investigation. > Currently, selecting or clicking on nested content fires an event that > expands/collapses the information. See the attached video to view the > behavior. > It would be better if target for the collapse/expand event only applied to > the top of the details section. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (METRON-1723) PCAP UI - Unable to select/copy from packets details in PCAP query panel
[ https://issues.apache.org/jira/browse/METRON-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16573694#comment-16573694 ] ASF GitHub Bot commented on METRON-1723: Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/1139 Works as advertised. +1 > PCAP UI - Unable to select/copy from packets details in PCAP query panel > > > Key: METRON-1723 > URL: https://issues.apache.org/jira/browse/METRON-1723 > Project: Metron > Issue Type: Sub-task >Reporter: Shane Ardell >Priority: Major > Attachments: expand-collapse-details-PCAP-query.mp4 > > > Upon query completion, a user can click on a row and drill down (up to 2 > levels) for a given packet. > A SOC analyst might find it useful to select/copy specific information from > the 2nd level granular details (E.g. MAC address, IP address, timestamps > etc.) to be used subsequently for analysis/investigation. > Currently, selecting or clicking on nested content fires an event that > expands/collapses the information. See the attached video to view the > behavior. > It would be better if target for the collapse/expand event only applied to > the top of the details section. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (METRON-1723) PCAP UI - Unable to select/copy from packets details in PCAP query panel
[ https://issues.apache.org/jira/browse/METRON-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16573183#comment-16573183 ] ASF GitHub Bot commented on METRON-1723: Github user sardell commented on the issue: https://github.com/apache/metron/pull/1139 @justinleet Those merge conflicts are now resolved. > PCAP UI - Unable to select/copy from packets details in PCAP query panel > > > Key: METRON-1723 > URL: https://issues.apache.org/jira/browse/METRON-1723 > Project: Metron > Issue Type: Sub-task >Reporter: Shane Ardell >Priority: Major > Attachments: expand-collapse-details-PCAP-query.mp4 > > > Upon query completion, a user can click on a row and drill down (up to 2 > levels) for a given packet. > A SOC analyst might find it useful to select/copy specific information from > the 2nd level granular details (E.g. MAC address, IP address, timestamps > etc.) to be used subsequently for analysis/investigation. > Currently, selecting or clicking on nested content fires an event that > expands/collapses the information. See the attached video to view the > behavior. > It would be better if target for the collapse/expand event only applied to > the top of the details section. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (METRON-1723) PCAP UI - Unable to select/copy from packets details in PCAP query panel
[ https://issues.apache.org/jira/browse/METRON-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16571721#comment-16571721 ] ASF GitHub Bot commented on METRON-1723: Github user justinleet commented on the issue: https://github.com/apache/metron/pull/1139 Spun this up and it worked great. Once we can get the parents in and the merge conflicts resolved, I'm very happy with this, it's a great QoL change. > PCAP UI - Unable to select/copy from packets details in PCAP query panel > > > Key: METRON-1723 > URL: https://issues.apache.org/jira/browse/METRON-1723 > Project: Metron > Issue Type: Sub-task >Reporter: Shane Ardell >Priority: Major > Attachments: expand-collapse-details-PCAP-query.mp4 > > > Upon query completion, a user can click on a row and drill down (up to 2 > levels) for a given packet. > A SOC analyst might find it useful to select/copy specific information from > the 2nd level granular details (E.g. MAC address, IP address, timestamps > etc.) to be used subsequently for analysis/investigation. > Currently, selecting or clicking on nested content fires an event that > expands/collapses the information. See the attached video to view the > behavior. > It would be better if target for the collapse/expand event only applied to > the top of the details section. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (METRON-1723) PCAP UI - Unable to select/copy from packets details in PCAP query panel
[ https://issues.apache.org/jira/browse/METRON-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16570065#comment-16570065 ] ASF GitHub Bot commented on METRON-1723: GitHub user sardell opened a pull request: https://github.com/apache/metron/pull/1139 METRON-1723: Unable to select/copy from packets details in PCAP query panel ## Contributor Comments As pointed out in [METRON-1723](https://issues.apache.org/jira/browse/METRON-1723), a user cannot currently highlight 2nd level packet details without collapsing the details "drawer". I fixed this by stopping event propagation if clicking on a 2nd level packet detail. ## Testing This can be tested on full-dev by submitting a PCAP query with results, drilling down into some 2nd level details (see attached screenshot) and highlighting those details with your cursor as if you were going to copy them. The drawer should not close as it did previously.  ## Pull Request Checklist Thank you for submitting a contribution to Apache Metron. Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions. Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides. In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). - [ ] Does your PR title start with METRON- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? ### For code changes: - [ ] Have you included steps to reproduce the behavior or problem that is being changed or addressed? - [ ] Have you included steps or a guide to how the change may be verified and tested manually? - [ ] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via: ``` mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh ``` - [ ] Have you written or updated unit tests and or integration tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`: ``` cd site-book mvn site ``` Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request. You can merge this pull request into a Git repository by running: $ git pull https://github.com/sardell/metron METRON-1723 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/metron/pull/1139.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1139 commit 872d1b1ee13e358c18956945d71d3667d19fca8a Author: merrimanr Date: 2018-04-12T14:57:48Z Merge branch 'pcap-front' of https://github.com/simonellistonball/metron into pcaprest Conflicts: metron-interface/metron-alerts/src/app/app.module.ts commit b1b6a7dabea1a1d0d132482c8d97af29c0ac2683 Author: merrimanr Date: 2018-04-13T15:00:15Z initial commit Conflicts: metron-interface/metron-rest/src/main/java/org/apache/metron/rest/MetronRestApplication.java metron-interface/metron-rest/src/main/java/org/apache/metron/rest/controller/PcapQueryController.java metro
