[jira] [Commented] (METRON-1791) Add GUID to Messages Produced by Profiler

2018-10-04 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/METRON-1791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638915#comment-16638915
 ] 

ASF GitHub Bot commented on METRON-1791:


Github user asfgit closed the pull request at:

https://github.com/apache/metron/pull/1210


> Add GUID to Messages Produced by Profiler
> -
>
> Key: METRON-1791
> URL: https://issues.apache.org/jira/browse/METRON-1791
> Project: Metron
>  Issue Type: Bug
>Reporter: Nick Allen
>Assignee: Nick Allen
>Priority: Major
>
> If a profile defines a triage result, when that profile is flushed the 
> Profiler will generate a message containing the measurement data so that it 
> can be used for Threat Triage.  The message that is generated does not 
> contain a GUID.  All messages in Metron should contain a GUID.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (METRON-1791) Add GUID to Messages Produced by Profiler

2018-10-04 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/METRON-1791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638845#comment-16638845
 ] 

ASF GitHub Bot commented on METRON-1791:


Github user mmiklavc commented on the issue:

https://github.com/apache/metron/pull/1210
  
lgtm, +1 by inspection.


> Add GUID to Messages Produced by Profiler
> -
>
> Key: METRON-1791
> URL: https://issues.apache.org/jira/browse/METRON-1791
> Project: Metron
>  Issue Type: Bug
>Reporter: Nick Allen
>Assignee: Nick Allen
>Priority: Major
>
> If a profile defines a triage result, when that profile is flushed the 
> Profiler will generate a message containing the measurement data so that it 
> can be used for Threat Triage.  The message that is generated does not 
> contain a GUID.  All messages in Metron should contain a GUID.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (METRON-1791) Add GUID to Messages Produced by Profiler

2018-10-04 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/METRON-1791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638373#comment-16638373
 ] 

ASF GitHub Bot commented on METRON-1791:


Github user merrimanr commented on the issue:

https://github.com/apache/metron/pull/1210
  
Looks good to me.  +1 by inspection.


> Add GUID to Messages Produced by Profiler
> -
>
> Key: METRON-1791
> URL: https://issues.apache.org/jira/browse/METRON-1791
> Project: Metron
>  Issue Type: Bug
>Reporter: Nick Allen
>Assignee: Nick Allen
>Priority: Major
>
> If a profile defines a triage result, when that profile is flushed the 
> Profiler will generate a message containing the measurement data so that it 
> can be used for Threat Triage.  The message that is generated does not 
> contain a GUID.  All messages in Metron should contain a GUID.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (METRON-1791) Add GUID to Messages Produced by Profiler

2018-09-24 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/METRON-1791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16626541#comment-16626541
 ] 

ASF GitHub Bot commented on METRON-1791:


GitHub user nickwallen opened a pull request:

https://github.com/apache/metron/pull/1210

METRON-1791 Add GUID to Messages Produced by Profiler

If a profile defines a triage result when it is flushed the Profiler will 
generate a message containing the measurement data so that profiles can be used 
for Threat Triage.  The message that is generated does not contain a GUID.  All 
messages in Metron should contain a GUID.

## Testing

TODO

## Pull Request Checklist

- [ ] Is there a JIRA ticket associated with this PR? If not one needs to 
be created at [Metron 
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [ ] Does your PR title start with METRON- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?
- [ ] Have you included steps to reproduce the behavior or problem that is 
being changed or addressed?
- [ ] Have you included steps or a guide to how the change may be verified 
and tested manually?
- [ ] Have you ensured that the full suite of tests and checks have been 
executed in the root metron folder via:
- [ ] Have you written or updated unit tests and or integration tests to 
verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] Have you verified the basic functionality of the build by building 
and running locally with Vagrant full-dev environment or the equivalent?


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nickwallen/metron METRON-1791

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/metron/pull/1210.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1210


commit cb49dbd12686646ab052a1f6dfdf5c2d7744
Author: Nick Allen 
Date:   2018-09-24T22:51:36Z

METRON-1791 Add GUID to Messages Produced by Profiler




> Add GUID to Messages Produced by Profiler
> -
>
> Key: METRON-1791
> URL: https://issues.apache.org/jira/browse/METRON-1791
> Project: Metron
>  Issue Type: Bug
>Reporter: Nick Allen
>Assignee: Nick Allen
>Priority: Major
>
> If a profile defines a triage result, when that profile is flushed the 
> Profiler will generate a message containing the measurement data so that it 
> can be used for Threat Triage.  The message that is generated does not 
> contain a GUID.  All messages in Metron should contain a GUID.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)