[jira] [Commented] (METRON-633) Create better logging for HbaseEnrichmentWriter

[Otto Fowler (JIRA)]

[ 
https://issues.apache.org/jira/browse/METRON-633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104447#comment-16104447
 ] 

Otto Fowler commented on METRON-633:


Can you end progress on this as it has been landed?

> Create better logging for HbaseEnrichmentWriter
> ---
>
> Key: METRON-633
> URL: https://issues.apache.org/jira/browse/METRON-633
> Project: Metron
>  Issue Type: Bug
>Reporter: Casey Stella
>Assignee: Tomas Zezula
>  Labels: newbie
>
> Right now our debug logging is nonexistent for this writer and it makes 
> tracking down issues almost impossible.  This should be corrected. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (METRON-633) Create better logging for HbaseEnrichmentWriter

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/METRON-633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16087225#comment-16087225
 ] 

ASF GitHub Bot commented on METRON-633:
---

Github user asfgit closed the pull request at:

https://github.com/apache/metron/pull/572


> Create better logging for HbaseEnrichmentWriter
> ---
>
> Key: METRON-633
> URL: https://issues.apache.org/jira/browse/METRON-633
> Project: Metron
>  Issue Type: Bug
>Reporter: Casey Stella
>Assignee: Tomas Zezula
>  Labels: newbie
>
> Right now our debug logging is nonexistent for this writer and it makes 
> tracking down issues almost impossible.  This should be corrected. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (METRON-633) Create better logging for HbaseEnrichmentWriter

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/METRON-633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16087224#comment-16087224
 ] 

ASF GitHub Bot commented on METRON-633:
---

Github user justinleet commented on the issue:

https://github.com/apache/metron/pull/572
  
+1, thanks again for the contribution.


> Create better logging for HbaseEnrichmentWriter
> ---
>
> Key: METRON-633
> URL: https://issues.apache.org/jira/browse/METRON-633
> Project: Metron
>  Issue Type: Bug
>Reporter: Casey Stella
>Assignee: Tomas Zezula
>  Labels: newbie
>
> Right now our debug logging is nonexistent for this writer and it makes 
> tracking down issues almost impossible.  This should be corrected. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (METRON-633) Create better logging for HbaseEnrichmentWriter

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/METRON-633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16075517#comment-16075517
 ] 

ASF GitHub Bot commented on METRON-633:
---

Github user zezutom commented on the issue:

https://github.com/apache/metron/pull/572
  
@justinleet I can't merge this PR, do you mind merging to master yourself? 
Cheers.


> Create better logging for HbaseEnrichmentWriter
> ---
>
> Key: METRON-633
> URL: https://issues.apache.org/jira/browse/METRON-633
> Project: Metron
>  Issue Type: Bug
>Reporter: Casey Stella
>Assignee: Tomas Zezula
>  Labels: newbie
>
> Right now our debug logging is nonexistent for this writer and it makes 
> tracking down issues almost impossible.  This should be corrected. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (METRON-633) Create better logging for HbaseEnrichmentWriter

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/METRON-633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16074793#comment-16074793
 ] 

ASF GitHub Bot commented on METRON-633:
---

Github user justinleet commented on the issue:

https://github.com/apache/metron/pull/572
  
@zezutom When you have a chance, could you merge in master and deconflict 
this?  The Travis build timeouts should be fixed as of 
https://github.com/apache/metron/pull/624.  Sorry about the trouble with 
Travis, and I look forward to getting this into master.


> Create better logging for HbaseEnrichmentWriter
> ---
>
> Key: METRON-633
> URL: https://issues.apache.org/jira/browse/METRON-633
> Project: Metron
>  Issue Type: Bug
>Reporter: Casey Stella
>Assignee: Tomas Zezula
>  Labels: newbie
>
> Right now our debug logging is nonexistent for this writer and it makes 
> tracking down issues almost impossible.  This should be corrected. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (METRON-633) Create better logging for HbaseEnrichmentWriter

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/METRON-633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16036935#comment-16036935
 ] 

ASF GitHub Bot commented on METRON-633:
---

Github user cestella commented on the issue:

https://github.com/apache/metron/pull/572
  
Just piling in here and saying thanks @zezutom for the contribution.  This 
looks great!


> Create better logging for HbaseEnrichmentWriter
> ---
>
> Key: METRON-633
> URL: https://issues.apache.org/jira/browse/METRON-633
> Project: Metron
>  Issue Type: Bug
>Reporter: Casey Stella
>Assignee: Tomas Zezula
>  Labels: newbie
>
> Right now our debug logging is nonexistent for this writer and it makes 
> tracking down issues almost impossible.  This should be corrected. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (METRON-633) Create better logging for HbaseEnrichmentWriter

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/METRON-633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16033710#comment-16033710
 ] 

ASF GitHub Bot commented on METRON-633:
---

Github user zezutom commented on a diff in the pull request:

https://github.com/apache/metron/pull/572#discussion_r119730181
  
--- Diff: 
metron-platform/metron-enrichment/src/main/java/org/apache/metron/enrichment/writer/SimpleHbaseEnrichmentWriter.java
 ---
@@ -169,16 +188,19 @@ public HTableInterface getTable(Map 
config) throws IOException {
   private List getColumns(Object keyColumnsObj, boolean allowNull) 
{
 Object o = keyColumnsObj;
 if(allowNull && keyColumnsObj == null) {
+  LOG.debug("No key columns were specified");
   return Collections.emptyList();
 }
 if(o instanceof String) {
+  LOG.debug("Key column: '" + o + "'");
--- End diff --

Thanks everyone for a great feedback! @justinleet I will rebase once #599 
is merged, cheers.


> Create better logging for HbaseEnrichmentWriter
> ---
>
> Key: METRON-633
> URL: https://issues.apache.org/jira/browse/METRON-633
> Project: Metron
>  Issue Type: Bug
>Reporter: Casey Stella
>Assignee: Tomas Zezula
>  Labels: newbie
>
> Right now our debug logging is nonexistent for this writer and it makes 
> tracking down issues almost impossible.  This should be corrected. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (METRON-633) Create better logging for HbaseEnrichmentWriter

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/METRON-633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16031691#comment-16031691
 ] 

ASF GitHub Bot commented on METRON-633:
---

Github user mmiklavc commented on a diff in the pull request:

https://github.com/apache/metron/pull/572#discussion_r119442810
  
--- Diff: 
metron-platform/metron-enrichment/src/main/java/org/apache/metron/enrichment/writer/SimpleHbaseEnrichmentWriter.java
 ---
@@ -169,16 +188,19 @@ public HTableInterface getTable(Map 
config) throws IOException {
   private List getColumns(Object keyColumnsObj, boolean allowNull) 
{
 Object o = keyColumnsObj;
 if(allowNull && keyColumnsObj == null) {
+  LOG.debug("No key columns were specified");
   return Collections.emptyList();
 }
 if(o instanceof String) {
+  LOG.debug("Key column: '" + o + "'");
--- End diff --

Better to turn this and similar statements into `LOG.debug("Key column: 
'{}'", o );`. Per the slf4j docs, this has the potential to improve calls by up 
to 30x where debugging is not enabled.


> Create better logging for HbaseEnrichmentWriter
> ---
>
> Key: METRON-633
> URL: https://issues.apache.org/jira/browse/METRON-633
> Project: Metron
>  Issue Type: Bug
>Reporter: Casey Stella
>Assignee: Tomas Zezula
>  Labels: newbie
>
> Right now our debug logging is nonexistent for this writer and it makes 
> tracking down issues almost impossible.  This should be corrected. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (METRON-633) Create better logging for HbaseEnrichmentWriter

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/METRON-633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16031075#comment-16031075
 ] 

ASF GitHub Bot commented on METRON-633:
---

Github user justinleet commented on the issue:

https://github.com/apache/metron/pull/572
  
Can you use parameterized messages for the various log statements or 
`logger.isDebugEnabled()`, rather than constructing the strings every time?  
The common case is for this to not be run, so I'd rather not have this stuff 
constructed to much. See: https://www.slf4j.org/faq.html#logging_performance

If I recall correctly, typically it's better to use parameterized messages 
if it's just using the `toString()` of an object, and `logger.isDebugEnabled()` 
if not (to avoid whatever calls are made).  I'd have to double check that 
though.



> Create better logging for HbaseEnrichmentWriter
> ---
>
> Key: METRON-633
> URL: https://issues.apache.org/jira/browse/METRON-633
> Project: Metron
>  Issue Type: Bug
>Reporter: Casey Stella
>Assignee: Tomas Zezula
>  Labels: newbie
>
> Right now our debug logging is nonexistent for this writer and it makes 
> tracking down issues almost impossible.  This should be corrected. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (METRON-633) Create better logging for HbaseEnrichmentWriter

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/METRON-633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016599#comment-16016599
 ] 

ASF GitHub Bot commented on METRON-633:
---

Github user zezutom commented on the issue:

https://github.com/apache/metron/pull/572
  
Hey folks, this one has been open for a while. Could I please get some 
+1's? Thank you!


> Create better logging for HbaseEnrichmentWriter
> ---
>
> Key: METRON-633
> URL: https://issues.apache.org/jira/browse/METRON-633
> Project: Metron
>  Issue Type: Bug
>Reporter: Casey Stella
>Assignee: Tomas Zezula
>  Labels: newbie
>
> Right now our debug logging is nonexistent for this writer and it makes 
> tracking down issues almost impossible.  This should be corrected. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)