[jira] [Commented] (METRON-944) markdown table causes infinite hanging in site-book's doxia-module-markdown

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/METRON-944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16003485#comment-16003485
 ] 

ASF GitHub Bot commented on METRON-944:
---

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-metron/pull/575


> markdown table causes infinite hanging in site-book's doxia-module-markdown
> ---
>
> Key: METRON-944
> URL: https://issues.apache.org/jira/browse/METRON-944
> Project: Metron
>  Issue Type: Improvement
>Reporter: Justin Leet
>Assignee: Justin Leet
>
> It hangs forever.  Don't like it.
> Most likely https://issues.apache.org/jira/browse/DOXIA-554
> It's theoretically fixed, but the newest version isn't released yet, so we 
> can't use it.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (METRON-944) markdown table causes infinite hanging in site-book's doxia-module-markdown

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/METRON-944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16003403#comment-16003403
 ] 

ASF GitHub Bot commented on METRON-944:
---

Github user justinleet commented on the issue:

https://github.com/apache/incubator-metron/pull/575
  
@mattf-horton Thanks for catching that.  Merged it in.


> markdown table causes infinite hanging in site-book's doxia-module-markdown
> ---
>
> Key: METRON-944
> URL: https://issues.apache.org/jira/browse/METRON-944
> Project: Metron
>  Issue Type: Improvement
>Reporter: Justin Leet
>Assignee: Justin Leet
>
> It hangs forever.  Don't like it.
> Most likely https://issues.apache.org/jira/browse/DOXIA-554
> It's theoretically fixed, but the newest version isn't released yet, so we 
> can't use it.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (METRON-944) markdown table causes infinite hanging in site-book's doxia-module-markdown

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/METRON-944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16003398#comment-16003398
 ] 

ASF GitHub Bot commented on METRON-944:
---

Github user ottobackwards commented on the issue:

https://github.com/apache/incubator-metron/pull/575
  
+1 - generated site and opened in browser, clicked around.  Thanks for 
jumping on this


> markdown table causes infinite hanging in site-book's doxia-module-markdown
> ---
>
> Key: METRON-944
> URL: https://issues.apache.org/jira/browse/METRON-944
> Project: Metron
>  Issue Type: Improvement
>Reporter: Justin Leet
>Assignee: Justin Leet
>
> It hangs forever.  Don't like it.
> Most likely https://issues.apache.org/jira/browse/DOXIA-554
> It's theoretically fixed, but the newest version isn't released yet, so we 
> can't use it.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (METRON-944) markdown table causes infinite hanging in site-book's doxia-module-markdown

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/METRON-944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16003351#comment-16003351
 ] 

ASF GitHub Bot commented on METRON-944:
---

Github user justinleet commented on the issue:

https://github.com/apache/incubator-metron/pull/575
  
Just spin up the site-book and make sure it a) completes (~30s) and b) 
doesn't look like hot garbage in the site-book


> markdown table causes infinite hanging in site-book's doxia-module-markdown
> ---
>
> Key: METRON-944
> URL: https://issues.apache.org/jira/browse/METRON-944
> Project: Metron
>  Issue Type: Improvement
>Reporter: Justin Leet
>Assignee: Justin Leet
>
> It hangs forever.  Don't like it.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (METRON-944) markdown table causes infinite hanging in site-book's doxia-module-markdown

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/METRON-944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16003348#comment-16003348
 ] 

ASF GitHub Bot commented on METRON-944:
---

GitHub user justinleet opened a pull request:

https://github.com/apache/incubator-metron/pull/575

METRON-944: markdown table causes infinite hanging in site-book's 
doxia-module-markdown

## Contributor Comments
Hangs less. Still not performant (takes ~30 seconds), but at least the 
tables aren't trash.  Stripped out as many columns as reasonable, split into 
different tables, etc.

## Pull Request Checklist

Thank you for submitting a contribution to Apache Metron.  
Please refer to our [Development 
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
 for the complete guide to follow for contributions.  
Please refer also to our [Build Verification 
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
 for complete smoke testing guides.  


In order to streamline the review of the contribution we ask you follow 
these guidelines and ask you to double check the following:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to 
be created at [Metron 
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
 
- [x] Does your PR title start with METRON- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
- [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in 
which it is rendered by building and verifying the site-book? If not then run 
the following commands and the verify changes via 
`site-book/target/site/index.html`:

  ```
  cd site-book
  mvn site
  ```

 Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up 
for your personal repository such that your branches are built there before 
submitting a pull request.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/justinleet/incubator-metron readme_fix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-metron/pull/575.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #575


commit a7aa10a1651308e3b7dd625a3fe89b9a28e3047e
Author: justinjleet 
Date:   2017-05-09T19:14:54Z

reformatting table




> markdown table causes infinite hanging in site-book's doxia-module-markdown
> ---
>
> Key: METRON-944
> URL: https://issues.apache.org/jira/browse/METRON-944
> Project: Metron
>  Issue Type: Improvement
>Reporter: Justin Leet
>Assignee: Justin Leet
>
> It hangs forever.  Don't like it.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)