[GitHub] [incubator-milagro-crypto-rust] kealan merged pull request #5: A lot of Formatting and style
kealan merged pull request #5: A lot of Formatting and style URL: https://github.com/apache/incubator-milagro-crypto-rust/pull/5 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: issues-unsubscr...@milagro.apache.org For additional commands, e-mail: issues-h...@milagro.apache.org
[GitHub] [incubator-milagro-crypto-rust] kirk-baird opened a new pull request #5: A lot of Formatting and style
kirk-baird opened a new pull request #5: A lot of Formatting and style URL: https://github.com/apache/incubator-milagro-crypto-rust/pull/5 Large overhaul to change the formatting guide to match Rust. Only breaking changes are switching the naming of `BIG -> Big` and `DBIG -> DBig` and possibly some of the types in `types.rs` but these should only be internally. The mutability of some function and variables has been reduced where possible. This is not a breaking change but will give a warning in some cases where users still pass a mutable reference. E,g, `Big::tostring` did not require a mutable reference and hence has been removed. Improvements to the readme.md Increase the readability of the docs (run `cargo doc --open`) which should increase the usability as a cargo crate. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: issues-unsubscr...@milagro.apache.org For additional commands, e-mail: issues-h...@milagro.apache.org
[GitHub] [incubator-milagro-crypto-rust] kirk-baird opened a new issue #4: bn254CX_64 Compilation Bug
kirk-baird opened a new issue #4: bn254CX_64 Compilation Bug URL: https://github.com/apache/incubator-milagro-crypto-rust/issues/4 A couple of things here contribute to this bug. Firstly the name of the feature is `bn254cx` in `Cargo.toml` however it is named `bn254CX` in `lib.rs` and so can never actually be compiled. After fixing this there is a compilation bug in the line - `pub const FEXCESS: i32 = (((1 as i32) << SH) - 1);` Since the value of `SH = 64` in `rom_bn254CX_64.rs` and hence will cause an overflow when trying to shift an i32. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: issues-unsubscr...@milagro.apache.org For additional commands, e-mail: issues-h...@milagro.apache.org
[GitHub] [incubator-milagro-crypto-js] kealan merged pull request #17: Release 1.0.0
kealan merged pull request #17: Release 1.0.0 URL: https://github.com/apache/incubator-milagro-crypto-js/pull/17 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: issues-unsubscr...@milagro.apache.org For additional commands, e-mail: issues-h...@milagro.apache.org
[GitHub] [incubator-milagro-crypto-c] kealan merged pull request #36: Release 1.0.0
kealan merged pull request #36: Release 1.0.0 URL: https://github.com/apache/incubator-milagro-crypto-c/pull/36 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: issues-unsubscr...@milagro.apache.org For additional commands, e-mail: issues-h...@milagro.apache.org
[GitHub] [incubator-milagro-crypto-js] kealan opened a new pull request #17: Release 1.0.0
kealan opened a new pull request #17: Release 1.0.0 URL: https://github.com/apache/incubator-milagro-crypto-js/pull/17 First release of code This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: issues-unsubscr...@milagro.apache.org For additional commands, e-mail: issues-h...@milagro.apache.org
[GitHub] [incubator-milagro-crypto-js] kealan merged pull request #16: update VERSION
kealan merged pull request #16: update VERSION URL: https://github.com/apache/incubator-milagro-crypto-js/pull/16 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: issues-unsubscr...@milagro.apache.org For additional commands, e-mail: issues-h...@milagro.apache.org
[GitHub] [incubator-milagro-crypto-c] kealan merged pull request #35: Issue34
kealan merged pull request #35: Issue34 URL: https://github.com/apache/incubator-milagro-crypto-c/pull/35 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: issues-unsubscr...@milagro.apache.org For additional commands, e-mail: issues-h...@milagro.apache.org
[GitHub] [incubator-milagro-crypto-c] kealan closed issue #34: generate BLS public keys
kealan closed issue #34: generate BLS public keys URL: https://github.com/apache/incubator-milagro-crypto-c/issues/34 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: issues-unsubscr...@milagro.apache.org For additional commands, e-mail: issues-h...@milagro.apache.org
